[ https://issues.jboss.org/browse/JGRP-2274?page=com.atlassian.jira.plugin.... ] Bela Ban commented on JGRP-2274: -------------------------------- {quote} HMAC needs its own shared key, so this may be one reason to keep the signing as part of the encryption protocol (so it can reuse the same shared secret) {quote} Hmm, I don't like this; as a matter of fact, I removed the signing because I wanted separation of concerns (encryption and signing). But there are ways of fetching the secret key from Encrypt: using GET_SECRET_KEY as event sent up or down the stack does this. This is currently used by SSL_KEY_EXCHANGE, as it also needs access to the secret key. Wrt the changes you mentioned: I prefer _additional (separate) protocols_ to implement something that's different than encryption. But, of course, if you wanted to add GCM mode, than Encrypt itself would have to be modified. If you have suggestions, I'm all ears. If you even want to _implement_ something, I'm all for it, but I can't do this myself! -- This message was sent by Atlassian Jira (v7.12.1#712002)