6:01 a.m.
Invalid fix for JBAS-3573
-------------------------
Key: JBAS-3628
URL: http://jira.jboss.com/jira/browse/JBAS-3628
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Reporter: Luc Texier
Assigned To: Luc Texier
Fix For: JBossAS-4.0.5.GA
in case of an exception, both a PostCommit Task and a PostRollback Task should be added
try
{
if (m.isPersistent())
server.getPersistenceManager().remove(m, txId);
}
catch (Throwable t)
{
// Something is wrong with the persistence manager,
// force a NACK with a rollback/error
Runnable task = new RestoreMessageTask(m);
TxManager txManager = server.getPersistenceManager().getTxManager();
+ txManager.addPostCommitTask(txId, task);
txManager.addPostRollbackTask(txId, task);
SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m,
t);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:07 a.m.
New subject: [JBoss JIRA] Updated: (JBAS-3628) Invalid fix for JBAS-3573
[ http://jira.jboss.com/jira/browse/JBAS-3628?page=all ]
Luc Texier updated JBAS-3628:
-----------------------------
Fix Version/s: JBossAS-5.0.0.Beta
Description:
in case of an exception, both a PostCommit Task and a PostRollback Task should be added
try
{
if (m.isPersistent())
server.getPersistenceManager().remove(m, txId);
}
catch (Throwable t)
{
// Something is wrong with the persistence manager,
// force a NACK with a rollback/error
Runnable task = new RestoreMessageTask(m);
TxManager txManager = server.getPersistenceManager().getTxManager();
+ txManager.addPostCommitTask(txId, task);
txManager.addPostRollbackTask(txId, task);
SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m,
t);
}
was:
in case of an exception, both a PostCommit Task and a PostRollback Task should be added
try
{
if (m.isPersistent())
server.getPersistenceManager().remove(m, txId);
}
catch (Throwable t)
{
// Something is wrong with the persistence manager,
// force a NACK with a rollback/error
Runnable task = new RestoreMessageTask(m);
TxManager txManager = server.getPersistenceManager().getTxManager();
+ txManager.addPostCommitTask(txId, task);
txManager.addPostRollbackTask(txId, task);
SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m,
t);
}
Invalid fix for JBAS-3573
-------------------------
Key: JBAS-3628
URL: http://jira.jboss.com/jira/browse/JBAS-3628
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Reporter: Luc Texier
Assigned To: Luc Texier
Fix For: JBossAS-5.0.0.Beta, JBossAS-4.0.5.GA
in case of an exception, both a PostCommit Task and a PostRollback Task should be added
try
{
if (m.isPersistent())
server.getPersistenceManager().remove(m, txId);
}
catch (Throwable t)
{
// Something is wrong with the persistence manager,
// force a NACK with a rollback/error
Runnable task = new RestoreMessageTask(m);
TxManager txManager = server.getPersistenceManager().getTxManager();
+ txManager.addPostCommitTask(txId, task);
txManager.addPostRollbackTask(txId, task);
SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m,
t);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:12 a.m.
New subject: [JBoss JIRA] Updated: (JBAS-3628) Invalid fix for JBAS-3573
[ http://jira.jboss.com/jira/browse/JBAS-3628?page=all ]
Adrian Brock updated JBAS-3628:
-------------------------------
Component/s: JMS service
Invalid fix for JBAS-3573
-------------------------
Key: JBAS-3628
URL: http://jira.jboss.com/jira/browse/JBAS-3628
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: JMS service
Reporter: Luc Texier
Assigned To: Luc Texier
Fix For: JBossAS-5.0.0.Beta, JBossAS-4.0.5.GA
in case of an exception, both a PostCommit Task and a PostRollback Task should be added
try
{
if (m.isPersistent())
server.getPersistenceManager().remove(m, txId);
}
catch (Throwable t)
{
// Something is wrong with the persistence manager,
// force a NACK with a rollback/error
Runnable task = new RestoreMessageTask(m);
TxManager txManager = server.getPersistenceManager().getTxManager();
+ txManager.addPostCommitTask(txId, task);
txManager.addPostRollbackTask(txId, task);
SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m,
t);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:14 a.m.
New subject: [JBoss JIRA] Assigned: (JBAS-3628) Invalid fix for JBAS-3573
[ http://jira.jboss.com/jira/browse/JBAS-3628?page=all ]
Adrian Brock reassigned JBAS-3628:
----------------------------------
Assignee: Adrian Brock (was: Luc Texier)
Invalid fix for JBAS-3573
-------------------------
Key: JBAS-3628
URL: http://jira.jboss.com/jira/browse/JBAS-3628
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: JMS service
Reporter: Luc Texier
Assigned To: Adrian Brock
Fix For: JBossAS-5.0.0.Beta, JBossAS-4.0.5.GA
in case of an exception, both a PostCommit Task and a PostRollback Task should be added
try
{
if (m.isPersistent())
server.getPersistenceManager().remove(m, txId);
}
catch (Throwable t)
{
// Something is wrong with the persistence manager,
// force a NACK with a rollback/error
Runnable task = new RestoreMessageTask(m);
TxManager txManager = server.getPersistenceManager().getTxManager();
+ txManager.addPostCommitTask(txId, task);
txManager.addPostRollbackTask(txId, task);
SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m,
t);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:06 a.m.
New subject: [JBoss JIRA] Closed: (JBAS-3628) Invalid fix for JBAS-3573
[ http://jira.jboss.com/jira/browse/JBAS-3628?page=all ]
Adrian Brock closed JBAS-3628.
------------------------------
Resolution: Done
Invalid fix for JBAS-3573
-------------------------
Key: JBAS-3628
URL: http://jira.jboss.com/jira/browse/JBAS-3628
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: JMS service
Reporter: Luc Texier
Assigned To: Adrian Brock
Fix For: JBossAS-4.0.5.GA, JBossAS-5.0.0.Beta
in case of an exception, both a PostCommit Task and a PostRollback Task should be added
try
{
if (m.isPersistent())
server.getPersistenceManager().remove(m, txId);
}
catch (Throwable t)
{
// Something is wrong with the persistence manager,
// force a NACK with a rollback/error
Runnable task = new RestoreMessageTask(m);
TxManager txManager = server.getPersistenceManager().getTxManager();
+ txManager.addPostCommitTask(txId, task);
txManager.addPostRollbackTask(txId, task);
SpyJMSException.rethrowAsJMSException("Error during ACK ref=" + m,
t);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7244
days inactive
7259
days old
4 comments
2 participants
participants (2)
-
Adrian Brock (JIRA) -
Luc Texier (JIRA)