11:30 p.m.
Persistence annotation processing is overly restrictive
---------------------------------------------------------
Key: AS7-946
URL: https://issues.jboss.org/browse/AS7-946
Project: Application Server 7
Issue Type: Bug
Components: JPA / Hibernate
Affects Versions: No Release
Reporter: Marius Bogoevici
If a deployment contains classes bearing the @PersistenceContext annotation, the
annotation processor will fail the deployment if a persistence unit is not found. While
this is correct for classes which are a target for container-driven injection, the
application may contain annotated classes that are not injection targets according to the
Java EE specification. This is not illegal according to the specification.
To wit, a Spring application may use @PersistenceContext for performing Spring-driven
injection of Spring-managed entity manager factories.
In the past, such applications could have used the 'metadata-complete' attribute
in web.xml, but this does not seem to work anymore.
Regardless, of that, the server could adopt a more lenient approach, by failing the
injection only when a managed bean is actually injected with a non-existent PU/PC
reference.
The other variant would be to restrict validation to classes which are actual injection
targets according to the Java EE specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:32 p.m.
New subject: [JBoss JIRA] Commented: (AS7-946) Persistence annotation processing is overly restrictive
[
https://issues.jboss.org/browse/AS7-946?page=com.atlassian.jira.plugin.sy...
]
Marius Bogoevici commented on AS7-946:
--------------------------------------
A possible variant for handling annotations more leniently is shown here:
https://github.com/mbogoevici/jboss-as/tree/lenient-pc-injection
Persistence annotation processing is overly restrictive
---------------------------------------------------------
Key: AS7-946
URL: https://issues.jboss.org/browse/AS7-946
Project: Application Server 7
Issue Type: Bug
Components: JPA / Hibernate
Affects Versions: No Release
Reporter: Marius Bogoevici
If a deployment contains classes bearing the @PersistenceContext annotation, the
annotation processor will fail the deployment if a persistence unit is not found. While
this is correct for classes which are a target for container-driven injection, the
application may contain annotated classes that are not injection targets according to the
Java EE specification. This is not illegal according to the specification.
To wit, a Spring application may use @PersistenceContext for performing Spring-driven
injection of Spring-managed entity manager factories.
In the past, such applications could have used the 'metadata-complete' attribute
in web.xml, but this does not seem to work anymore.
Regardless, of that, the server could adopt a more lenient approach, by failing the
injection only when a managed bean is actually injected with a non-existent PU/PC
reference.
The other variant would be to restrict validation to classes which are actual injection
targets according to the Java EE specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:08 a.m.
New subject: [JBoss JIRA] Assigned: (AS7-946) Persistence annotation processing is overly restrictive
[
https://issues.jboss.org/browse/AS7-946?page=com.atlassian.jira.plugin.sy...
]
jaikiran pai reassigned AS7-946:
--------------------------------
Assignee: jaikiran pai
Persistence annotation processing is overly restrictive
---------------------------------------------------------
Key: AS7-946
URL: https://issues.jboss.org/browse/AS7-946
Project: Application Server 7
Issue Type: Bug
Components: JPA / Hibernate
Affects Versions: No Release
Reporter: Marius Bogoevici
Assignee: jaikiran pai
If a deployment contains classes bearing the @PersistenceContext annotation, the
annotation processor will fail the deployment if a persistence unit is not found. While
this is correct for classes which are a target for container-driven injection, the
application may contain annotated classes that are not injection targets according to the
Java EE specification. This is not illegal according to the specification.
To wit, a Spring application may use @PersistenceContext for performing Spring-driven
injection of Spring-managed entity manager factories.
In the past, such applications could have used the 'metadata-complete' attribute
in web.xml, but this does not seem to work anymore.
Regardless, of that, the server could adopt a more lenient approach, by failing the
injection only when a managed bean is actually injected with a non-existent PU/PC
reference.
The other variant would be to restrict validation to classes which are actual injection
targets according to the Java EE specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:13 p.m.
New subject: [JBoss JIRA] Commented: (AS7-946) Persistence annotation processing is overly restrictive
[
https://issues.jboss.org/browse/AS7-946?page=com.atlassian.jira.plugin.sy...
]
Scott Marlow commented on AS7-946:
----------------------------------
Oops, I missed this jira...
Persistence annotation processing is overly restrictive
---------------------------------------------------------
Key: AS7-946
URL: https://issues.jboss.org/browse/AS7-946
Project: Application Server 7
Issue Type: Bug
Components: JPA / Hibernate
Affects Versions: No Release
Reporter: Marius Bogoevici
Assignee: jaikiran pai
If a deployment contains classes bearing the @PersistenceContext annotation, the
annotation processor will fail the deployment if a persistence unit is not found. While
this is correct for classes which are a target for container-driven injection, the
application may contain annotated classes that are not injection targets according to the
Java EE specification. This is not illegal according to the specification.
To wit, a Spring application may use @PersistenceContext for performing Spring-driven
injection of Spring-managed entity manager factories.
In the past, such applications could have used the 'metadata-complete' attribute
in web.xml, but this does not seem to work anymore.
Regardless, of that, the server could adopt a more lenient approach, by failing the
injection only when a managed bean is actually injected with a non-existent PU/PC
reference.
The other variant would be to restrict validation to classes which are actual injection
targets according to the Java EE specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:03 p.m.
New subject: [JBoss JIRA] Commented: (AS7-946) Persistence annotation processing is overly restrictive
[
https://issues.jboss.org/browse/AS7-946?page=com.atlassian.jira.plugin.sy...
]
Scott Marlow commented on AS7-946:
----------------------------------
One other idea, to catch hybrid applications (that use EE JPA and Hibernate JPA), would be
to check for the presence of Hibernate jars in the app. A variation of this (not
currently activated) is in PersistenceProviderProcessor.
In a later release, perhaps 7.1, I would like to use PersistenceProviderProcessor to
detect top level deployments that are persistence providers. Perhaps if the deployment is
not a top level deployment, PersistenceProviderProcessor could mark it as a contained
persistence provider. If the contained persistence provider conflicts with the TLD, we
could know that we should avoid most (if not all) EE JPA deployment activities for that
application.
Or we could try avoiding being so smart about what the application needs and support a
simple way for the needs to be expressed in plain text :-) This is more likely to cure
our current over restrictiveness (IMO).
Persistence annotation processing is overly restrictive
---------------------------------------------------------
Key: AS7-946
URL: https://issues.jboss.org/browse/AS7-946
Project: Application Server 7
Issue Type: Bug
Components: JPA / Hibernate
Affects Versions: No Release
Reporter: Marius Bogoevici
Assignee: jaikiran pai
If a deployment contains classes bearing the @PersistenceContext annotation, the
annotation processor will fail the deployment if a persistence unit is not found. While
this is correct for classes which are a target for container-driven injection, the
application may contain annotated classes that are not injection targets according to the
Java EE specification. This is not illegal according to the specification.
To wit, a Spring application may use @PersistenceContext for performing Spring-driven
injection of Spring-managed entity manager factories.
In the past, such applications could have used the 'metadata-complete' attribute
in web.xml, but this does not seem to work anymore.
Regardless, of that, the server could adopt a more lenient approach, by failing the
injection only when a managed bean is actually injected with a non-existent PU/PC
reference.
The other variant would be to restrict validation to classes which are actual injection
targets according to the Java EE specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:38 p.m.
New subject: [JBoss JIRA] Commented: (AS7-946) Persistence annotation processing is overly restrictive
[
https://issues.jboss.org/browse/AS7-946?page=com.atlassian.jira.plugin.sy...
]
Marius Bogoevici commented on AS7-946:
--------------------------------------
Scott, I agree with you, but I feel the need to articulate a bit clearer the reasons for
opening this issue:
a) Given a web application that deployed on JBAS7, if the deployment of the persistence
unit is suppressed through various means - ranging from deploying META-INF/persistence.xml
under a different name, or instructing the server to ignore it, the @PU/@PC annotations
are handled even on classes which are not managed objects in the Java EE sense - this
causes the application to fail deployment. This happens when the deployment unit is a
top-level PU as well (war). Perhaps a reasonable solution would be to avoid doing any JPA
deployment work, but then the deployment may contain @PersistenceContext references on
things like @EJBs, and in that case the deployment must fail or the application must
break.
b) If the @PU/@PC annotations are placed on methods which are not setters, this will break
the deployment as well, even if a PU is found. Again, this may be requirement for managed
instances, but non-managed instances aren't necessarily bound by that rule, so perhaps
we could simply ignore these cases and issue a warning?
I think that these concerns are somewhat complementary to the ones you formulated in your
comment above.
Overall, I see the solution as a compromise between not doing some very complex and
perhaps expensive checks at deployment time, being as lenient as possible, and throwing
errors as early as possible in the deployment cycle.
Persistence annotation processing is overly restrictive
---------------------------------------------------------
Key: AS7-946
URL: https://issues.jboss.org/browse/AS7-946
Project: Application Server 7
Issue Type: Bug
Components: JPA / Hibernate
Affects Versions: No Release
Reporter: Marius Bogoevici
Assignee: jaikiran pai
If a deployment contains classes bearing the @PersistenceContext annotation, the
annotation processor will fail the deployment if a persistence unit is not found. While
this is correct for classes which are a target for container-driven injection, the
application may contain annotated classes that are not injection targets according to the
Java EE specification. This is not illegal according to the specification.
To wit, a Spring application may use @PersistenceContext for performing Spring-driven
injection of Spring-managed entity manager factories.
In the past, such applications could have used the 'metadata-complete' attribute
in web.xml, but this does not seem to work anymore.
Regardless, of that, the server could adopt a more lenient approach, by failing the
injection only when a managed bean is actually injected with a non-existent PU/PC
reference.
The other variant would be to restrict validation to classes which are actual injection
targets according to the Java EE specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:38 p.m.
New subject: [JBoss JIRA] Updated: (AS7-946) Persistence annotation processing is overly restrictive
[
https://issues.jboss.org/browse/AS7-946?page=com.atlassian.jira.plugin.sy...
]
Scott Marlow updated AS7-946:
-----------------------------
Fix Version/s: 7.1.0.Alpha1
Affects Version/s: 7.0.0.Beta3
(was: No Release)
Persistence annotation processing is overly restrictive
---------------------------------------------------------
Key: AS7-946
URL: https://issues.jboss.org/browse/AS7-946
Project: Application Server 7
Issue Type: Bug
Components: JPA / Hibernate
Affects Versions: 7.0.0.Beta3
Reporter: Marius Bogoevici
Assignee: jaikiran pai
Fix For: 7.1.0.Alpha1
If a deployment contains classes bearing the @PersistenceContext annotation, the
annotation processor will fail the deployment if a persistence unit is not found. While
this is correct for classes which are a target for container-driven injection, the
application may contain annotated classes that are not injection targets according to the
Java EE specification. This is not illegal according to the specification.
To wit, a Spring application may use @PersistenceContext for performing Spring-driven
injection of Spring-managed entity manager factories.
In the past, such applications could have used the 'metadata-complete' attribute
in web.xml, but this does not seem to work anymore.
Regardless, of that, the server could adopt a more lenient approach, by failing the
injection only when a managed bean is actually injected with a non-existent PU/PC
reference.
The other variant would be to restrict validation to classes which are actual injection
targets according to the Java EE specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:20 p.m.
New subject: [JBoss JIRA] Resolved: (AS7-946) Persistence annotation processing is overly restrictive
[
https://issues.jboss.org/browse/AS7-946?page=com.atlassian.jira.plugin.sy...
]
Stuart Douglas resolved AS7-946.
--------------------------------
Assignee: Stuart Douglas (was: jaikiran pai)
Fix Version/s: 7.0.0.CR1
(was: 7.1.0.Alpha1)
Resolution: Done
I changed the processor to only throw a deployment exception if the PU is actually used as
an EE interceptor or component.
Persistence annotation processing is overly restrictive
---------------------------------------------------------
Key: AS7-946
URL: https://issues.jboss.org/browse/AS7-946
Project: Application Server 7
Issue Type: Bug
Components: JPA / Hibernate
Affects Versions: 7.0.0.Beta3
Reporter: Marius Bogoevici
Assignee: Stuart Douglas
Fix For: 7.0.0.CR1
If a deployment contains classes bearing the @PersistenceContext annotation, the
annotation processor will fail the deployment if a persistence unit is not found. While
this is correct for classes which are a target for container-driven injection, the
application may contain annotated classes that are not injection targets according to the
Java EE specification. This is not illegal according to the specification.
To wit, a Spring application may use @PersistenceContext for performing Spring-driven
injection of Spring-managed entity manager factories.
In the past, such applications could have used the 'metadata-complete' attribute
in web.xml, but this does not seem to work anymore.
Regardless, of that, the server could adopt a more lenient approach, by failing the
injection only when a managed bean is actually injected with a non-existent PU/PC
reference.
The other variant would be to restrict validation to classes which are actual injection
targets according to the Java EE specification.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5508
days inactive
5517
days old
7 comments
4 participants
participants (4)
-
jaikiran pai (JIRA) -
Marius Bogoevici (JIRA)
-
Scott Marlow (JIRA)
-
Stuart Douglas (JIRA)