Client.invoke() should check isConnected(). ------------------------------------------- Key: JBREM-614 URL: http://jira.jboss.com/jira/browse/JBREM-614 Project: JBoss Remoting Issue Type: Task Security Level: Public(Everyone can see) Affects Versions: 2.2.0.Alpha3 (Bluto) Reporter: Ron Sigal Assigned To: Ron Sigal Priority: Minor Fix For: 2.2.0.Beta1 (Bluto) This changed due to a leasing bug that Clebert found within messaging. The problem was that the isConnected() calls on it's invoker to see if it is connected (assuming the invoker is not null). So is possible that another Client is using the same client invoker and that invoker is already connected. This would cause the new Client to not set up leasing (which it would need to do). I guess the isConnected() call could be added back in, but would need to change the Client.isConnected() to use an member variable keeping track of state (connect or not connected) instead of calling on the invoker to see if it's connect. Ron Sigal wrote: > Hi Tom, > > I noticed something about Client.connect() and CallbackPoller.start(). In particular, CallbackPoller.start() calls Client.connect(), as it should. If leasing is configured, the Client will be registered with the LeasePinger. When the application calls Client.connect(), the Client will be re-registered with the LeasePinger. It doesn't cause an error, but it's a bit redundant. Looks like Client.connect() should start with > > if (isConnected()) > return; > > ?? > > -Ron

Client.invoke() should check isConnected(). ------------------------------------------- Key: JBREM-614 URL: http://jira.jboss.com/jira/browse/JBREM-614 Project: JBoss Remoting Issue Type: Task Security Level: Public(Everyone can see) Affects Versions: 2.2.0.Alpha3 (Bluto) Reporter: Ron Sigal Assigned To: Ron Sigal Priority: Minor Fix For: 2.2.0.Beta1 (Bluto) This changed due to a leasing bug that Clebert found within messaging. The problem was that the isConnected() calls on it's invoker to see if it is connected (assuming the invoker is not null). So is possible that another Client is using the same client invoker and that invoker is already connected. This would cause the new Client to not set up leasing (which it would need to do). I guess the isConnected() call could be added back in, but would need to change the Client.isConnected() to use an member variable keeping track of state (connect or not connected) instead of calling on the invoker to see if it's connect. Ron Sigal wrote: > Hi Tom, > > I noticed something about Client.connect() and CallbackPoller.start(). In particular, CallbackPoller.start() calls Client.connect(), as it should. If leasing is configured, the Client will be registered with the LeasePinger. When the application calls Client.connect(), the Client will be re-registered with the LeasePinger. It doesn't cause an error, but it's a bit redundant. Looks like Client.connect() should start with > > if (isConnected()) > return; > > ?? > > -Ron