12:18 p.m.
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url field
is used as a key to the DeploymentInfo collections, this key should be always unique, i.e.
canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:28 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=comments#action_12340113 ]
Ralph Apel commented on JBAS-3433:
----------------------------------
Test org.jboss.test.naming.test.EjbLinkUnitTestCase may be run to reproduce this issue.
Previously, replace the server "all" config's tmp subdir by e.g. tmp -->
/tmp
You should then see something like
14:51:45,255 INFO [EARDeployer] Init J2EE application:
file:/usr/share/jbossas/testsuite/output/lib/naming.ear
14:51:45,438 INFO [EjbModule] Deploying SessionB
14:51:45,530 INFO [EjbModule] Deploying SessionA
14:51:45,539 INFO [EjbModule] Deploying SessionB
****************************
14:51:45,576 WARN [EjbUtil] Can't locate deploymentInfo for target:
file:/tmp/deploy/tmp52106naming.ear-
contents/subdir/naminga.jar
****************************
14:51:45,579 WARN [ServiceController] Problem starting service
jboss.j2ee:jndiName=naming/SessionB,service=EJB
org.jboss.deployment.DeploymentException: Failed to resolve ejb-link:
subdir/naminga.jar#SessionA make by ejb-name: ejb/RelativeSessionA
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:49 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=comments#action_12340775 ]
Ralph Apel commented on JBAS-3433:
----------------------------------
Running testsuite target jboss-all-config-tests against a symlinked deployment of
jbossas-4.0.4 it can be observed that all invocations of MBeanServer (MBeanServerImpl)
operation "getDeployment" occur with correctly canonicalized file URLs.
At the same time, DeploymentInfo are sometimes created with not fully canonicalized URLs.
"Not Fully" canonicalized here refers to the fact that although one first level
of indirection in file paths was correctly resolved even in this cases, a second symlink
indirection was not.
Detailed traces will follow as attachments.
This tests setup was as follows:
jboss.home=/usr/share/jbossas
/usr/share/jbossas/bin --> /var/lib/jbossas/bin
/usr/share/jbossas/client/ (a normal dir)
/usr/share/jbossas/docs --> /usr/share/doc/jbossas-4.0.4
/usr/share/jbossas/lib/ (a normal dir)
/usr/share/jbossas/server --> /var/lib/jbossas/server
/var/lib/jbossas/server/all/conf -> /etc/jbossas/all
/var/lib/jbossas/server/all/data/ (a normal dir)
/var/lib/jbossas/server/all/deploy/ (a normal dir)
/var/lib/jbossas/server/all/deploy-hasingleton/ (a normal dir)
/var/lib/jbossas/server/all/farm/ (a normal dir)
/var/lib/jbossas/server/all/lib/ (a normal dir)
/var/lib/jbossas/server/all/log -> /var/log/jbossas/all
/var/lib/jbossas/server/all/tmp -> /var/cache/jbossas/all/tmp
/var/lib/jbossas/server/all/work -> /var/cache/jbossas/all/work
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:23 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=all ]
Ralph Apel updated JBAS-3433:
-----------------------------
Attachment: JBAS-3433-Case2.txt
search for relative.jar
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
Attachments: JBAS-3433-Case1.txt, JBAS-3433-Case2.txt
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:23 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=all ]
Ralph Apel updated JBAS-3433:
-----------------------------
Attachment: JBAS-3433-Case1.txt
This case repeats 8 times almost identically
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
Attachments: JBAS-3433-Case1.txt, JBAS-3433-Case2.txt
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:25 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=all ]
Ralph Apel updated JBAS-3433:
-----------------------------
Attachment: JBAS-3433-Case4.txt
search for ws4ee-simple-client-ejb.jar
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
Attachments: JBAS-3433-Case1.txt, JBAS-3433-Case2.txt, JBAS-3433-Case3.txt,
JBAS-3433-Case4.txt
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:25 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=all ]
Ralph Apel updated JBAS-3433:
-----------------------------
Attachment: JBAS-3433-Case3.txt
search for ws4ee-jbws331-ejb.jar
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
Attachments: JBAS-3433-Case1.txt, JBAS-3433-Case2.txt, JBAS-3433-Case3.txt,
JBAS-3433-Case4.txt
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=comments#action_12340784 ]
Adrian Brock commented on JBAS-3433:
------------------------------------
The original problem was identified WRT to relative urls on Windows.
Without using the canonical path, you get a correct but "too long" path
that breaks the windows path limit (255 characters?)
e.g.
c:\my\long\folder\path\to\jboss\..\..\..\path\to\jboss\some\more\path\etc.
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
Attachments: JBAS-3433-Case1.txt, JBAS-3433-Case2.txt, JBAS-3433-Case3.txt,
JBAS-3433-Case4.txt
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:33 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=comments#action_12340834 ]
Ralph Apel commented on JBAS-3433:
----------------------------------
In my opinion, the cause of the reported and perhaps other similar issues may be tracked
down to
system/src/main/org/jboss/system/server/ServerConfigImpl.java
Here, several File and URL objects are created without canonicalization. For example, take
the "getServerTempDir()" method, which is the relevant one for the reported
issues:
public File getServerTempDir()
{
if (serverTempDir == null)
{
serverTempDir = getFile(ServerConfig.SERVER_TEMP_DIR);
if (serverTempDir == null)
{
serverTempDir = new File(getServerHomeDir(),
ServerConfig.SERVER_TEMP_DIR_SUFFIX);
System.setProperty(ServerConfig.SERVER_TEMP_DIR, serverTempDir.toString());
}
}
return serverTempDir;
}
In the described cases, this method will simply append SERVER_TEMP_DIR_SUFFIX to the
return value of getServerHomeDir() and proceed without considering canonicalization.
But in the described cases, symlinks involved in serverHomeDir were correctly resolved for
their canonical path. Why?
The corresponding method reads:
public File getServerHomeDir()
{
if (serverHomeDir == null)
{
serverHomeDir = getFile(ServerConfig.SERVER_HOME_DIR);
if (serverHomeDir == null)
{
serverHomeDir = new File(getServerBaseDir(), getServerName());
System.setProperty(ServerConfig.SERVER_HOME_DIR, serverHomeDir.toString());
}
}
return serverHomeDir;
}
The crucial difference lies in the call to getFile(). The getFile method DOES consider
canonicalization, by calling getCanonicalFile() as
private File getFile(final String name)
{
String value = props.getProperty(name, null);
if (value != null)
{
try
{
File f = new File(value);
return f.getCanonicalFile();
}
catch(IOException e)
{
return new File(value);
}
}
return null;
}
In conclusion, for each line of code like
fileVar = new File(args,..);
I would add a line like
fileVar = fileVar.getCanonicalFile();
at least in class
org.jboss.system.server.ServerConfigImpl
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
Attachments: JBAS-3433-Case1.txt, JBAS-3433-Case2.txt, JBAS-3433-Case3.txt,
JBAS-3433-Case4.txt
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
noon
New subject: [JBoss JIRA] Updated: (JBAS-3433) Canonical paths enforced inconsistently
[ http://jira.jboss.com/jira/browse/JBAS-3433?page=all ]
Ralph Apel updated JBAS-3433:
-----------------------------
Attachment: jboss4-4.0.4-ServerConfigImpl.patch
Attached please find the patch I applied to my build on
system/src/main/org/jboss/system/server/ServerConfigImpl.java
in order to avoid typical symlink related failures on Unix/Linux.
You wil probably code it differently.
Canonical paths enforced inconsistently
---------------------------------------
Key: JBAS-3433
URL: http://jira.jboss.com/jira/browse/JBAS-3433
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Deployment services
Affects Versions: JBossAS-4.0.4.GA
Environment: Linux/Unix
Reporter: Ralph Apel
Assigned To: Dimitris Andreadis
Attachments: JBAS-3433-Case1.txt, JBAS-3433-Case2.txt, JBAS-3433-Case3.txt,
JBAS-3433-Case4.txt, jboss4-4.0.4-ServerConfigImpl.patch
DeploymentInfo objects are created with file-URLs without previously canonicalizing the
file's path.
If the original URL wasn't canonical (e.g. with Linux/Unix symlinks involved), this
discrepancy leads to failure of at least EjbUtil's resolution of ejb-link:
The URL to be searched for among DeploymentInfos by the MBeanServer is constructed from
the canonicalized path, but the DeploymentInfo which should be found has a
non canonical file URL (i.e. without symlinks resolved).
I have been able to provisionally solve this issue by patching EjbUtil to not invoke
target = Strings.toURL(ourPath);
(which directly or indirectly calls getCanonicalPath()) but a particular code fragment
instead.
This kind of solution surely isn't the right one. IMO, as the DeploymentInfo.url
field is used as a key to the DeploymentInfo collections, this key should be always
unique, i.e. canonicalized.
My suggestion would be to change any DeploymentInfo instantiation AND any search for
DeploymentInfo instances to use canonicalized file URLs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7233
days inactive
7249
days old
9 comments
2 participants
participants (2)
-
Adrian Brock (JIRA) -
Ralph Apel (JIRA)