[ https://issues.jboss.org/browse/AS7-355?page=com.atlassian.jira.plugin.sy... ] Brian Stansberry updated AS7-355: --------------------------------- Fix Version/s: 7.1.0.Beta2 (was: 7.0.0.CR1) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-355?page=com.atlassian.jira.plugin.sy... ] Serge Emmanuel Pagop commented on AS7-355: ------------------------------------------ I got the same issue. I would appreciate it, if we could have a fix. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-355?page=com.atlassian.jira.plugin.sy... ] Guillaume Grossetie edited comment on AS7-355 at 7/29/12 10:58 AM: ------------------------------------------------------------------- I started working on this feature by adding the [getTagComment() method on XMLExtendedStreamReader |https://issues.jboss.org/browse/STXM-6] but I didn't find the AbstractModelElement class. I found the [ManagementXml class|https://github.com/jbossas/jboss-as/blob/master/domain-management/s...] but I'm not sure how to implement this feature... Can you give me some advice ? was (Author: grossetieg): I started working on this feature by adding the [test|https://issues.jboss.org/browse/STXM-6 getTagComment() ] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-355?page=com.atlassian.jira.plugin.sy... ] Guillaume Grossetie edited comment on AS7-355 at 7/29/12 10:59 AM: ------------------------------------------------------------------- I started working on this feature by adding the #getTagComment() method on XMLExtendedStreamReader (1) but I didn't find the AbstractModelElement class. I found the ManagementXml class (2) but I'm not sure how to implement this feature... Can you give me some advice ? (1) https://issues.jboss.org/browse/STXM-6 (2) https://github.com/jbossas/jboss-as/blob/master/domain-management/src/mai... was (Author: grossetieg): I started working on this feature by adding the getTagComment() method on XMLExtendedStreamReader(1) but I didn't find the AbstractModelElement class. I found the ManagementXml class(2) but I'm not sure how to implement this feature... Can you give me some advice ? (1) https://issues.jboss.org/browse/STXM-6 (2) https://github.com/jbossas/jboss-as/blob/master/domain-management/src/mai... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/AS7-355?page=com.atlassian.jira.plugin.sy... ] Guillaume Grossetie edited comment on AS7-355 at 8/1/12 4:59 PM: ----------------------------------------------------------------- Hi Brian, Thanks for taking some time on your holidays to answer :) My biggest concern is to know where the comment must be stored. As far as I understand ModelNode represents, in this particular context, elements of an xml file. The AbstractConfigurationPersister marshall as xml from a ModelNode but where and how the xml is parsed into ModelNode ? ModelNode (jboss-dmr) is quite low level and adding an additional variable to store the comment is maybe a bad idea ? But can a StringModelValue represent a comment ? I also have a question about STXM-6, Do we need to support comment on comment like : {code:xml} <!-- Comment 1 --> <!-- Comment 2 --> <root name="root"/> {code} Must #getTagComment() on root return "Comment 2" ? Do we need to support #getTagComment() on <!-- Comment 2 --> ? Thanks, Guillaume was (Author: grossetieg): Hi Brian, Thanks for taking some time on your holidays to answer :) My biggest concern is to know where the comment must be stored. As far as I understand ModelNode represents, in this particular context, elements of an xml file. The AbstractConfigurationPersister marshall as xml from a ModelNode but where and how the xml is parsed into ModelNode ? ModelNode (jboss-dmr) is quite low level and adding an additional variable to store the comment is maybe a bad idea ? But can a StringModelValue represent a comment ? I also have a question about STXM-6, Do we need to support comment on comment like : {{<!-- Comment 1 --> <!-- Comment 2 --> <root name="root"/>}} Must #getTagComment() on root return "Comment 2" ? Do we need to support #getTagComment() on <!-- Comment 2 --> ? Thanks, Guillaume -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira