]
Brian Stansberry commented on WFWIP-81:
---------------------------------------
[~rsvoboda] I replied on CLOUD-2730.
We already have liveness and readiness probes on our images and MP Health is not replacing
them. We are not relying on MP Health to deal with things like this.
We could in theory incorporate the existing checks the probes in our images already
perform into the MP Health report and thus make it the sole source of checks, but I see no
reason to do that in the first iteration.
MP Health reports UP when there is port collision for port 8080
---------------------------------------------------------------
Key: WFWIP-81
URL:
https://issues.jboss.org/browse/WFWIP-81
Project: WildFly WIP
Issue Type: Bug
Components: MP Health
Reporter: Rostislav Svoboda
Assignee: Jeff Mesnil
Priority: Critical
MP Health reports UP when there is port collision for port 8080.
I have simple python app to acquire port 8080 and once it runs I start WF server
{code}
import SimpleHTTPServer
import SocketServer
PORT = 8080
Handler = SimpleHTTPServer.SimpleHTTPRequestHandler
httpd = SocketServer.TCPServer(("127.0.0.1", PORT), Handler)
print "serving at port", PORT
httpd.serve_forever()
{code}
WF reports Address already in use /127.0.0.1:8080, deployments are not deployed.
Accessing
http://localhost:9990/health/ reports "outcome":"UP"
I think this is wrong and DOWN should be reported.
Spec is misleading because it says {{A producer without health check procedures installed
MUST returns positive overall outcome (i.e. HTTP 200)}} but it silently assumes server
started correctly.
I believe authors of the spec expected that if there is some trouble like port collision
the server doesn't start, WildFly is a bit further as it allows to boot even if some
services are not started properly.