8:22 a.m.
Problem with QueuedPessimisticEJBLock and Arjuna
------------------------------------------------
Key: JBAS-6348
URL: https://jira.jboss.org/jira/browse/JBAS-6348
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Transaction Manager (Arjuna)
Affects Versions: JBossAS-4.2.3.GA
Reporter: Ole Husgaard
Assignee: Jonathan Halliday
When using Arjuna, QueuedPessimisticEJBLock does not always properly detect that a waiting
tx has timed out. The problem is that QueuedPessimisticEJBLock was written for the old TM,
which did not rollback transactions on timeout, but only marked them for rollback. Now
that Arjuna is in play, it has to check for rolled back transactions too.
The isTxExpired() method should be changed to something like this:
protected boolean isTxExpired(Transaction miTx) throws Exception {
if (miTx != null
&& (miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK || miTx.getStatus() ==
Status.STATUS_ROLLEDBACK)) {
return true;
}
return false;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:01 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-6348) Problem with QueuedPessimisticEJBLock and Arjuna
[
https://jira.jboss.org/jira/browse/JBAS-6348?page=com.atlassian.jira.plug...
]
Pieter Bos commented on JBAS-6348:
----------------------------------
I can confirm this issue. We are somehow facing a lock that never gets released. When this
happens, transaction timeouts occur while waiting for a lock on that object in other
threads. Due to the fauly isTxExpired() method, they never time out and keep waiting. In
the end, all threads in the thread pool are in the waitForTx method. This in turn freezes
the entire application because at the end every thread in the threadpool spents his time
waiting for the lock to free or the transaction to expire - which will never happen.
We had an application freeze many times - all threads in the thread pool spent their time
in the QueuesPessimisticEJBLock.waitForTX() function, so the application no longer
responded. After fixing this issue with the patch in the description of this issue (adding
"ROLLING_BACK" as a condition too), RuntimeExceptions happen instead and the
application remains running.
Problem with QueuedPessimisticEJBLock and Arjuna
------------------------------------------------
Key: JBAS-6348
URL: https://jira.jboss.org/jira/browse/JBAS-6348
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transaction Manager (Arjuna)
Affects Versions: JBossAS-4.2.3.GA
Reporter: Ole Husgaard
Assignee: Jonathan Halliday
When using Arjuna, QueuedPessimisticEJBLock does not always properly detect that a
waiting tx has timed out. The problem is that QueuedPessimisticEJBLock was written for the
old TM, which did not rollback transactions on timeout, but only marked them for rollback.
Now that Arjuna is in play, it has to check for rolled back transactions too.
The isTxExpired() method should be changed to something like this:
protected boolean isTxExpired(Transaction miTx) throws Exception {
if (miTx != null
&& (miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK || miTx.getStatus() ==
Status.STATUS_ROLLEDBACK)) {
return true;
}
return false;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:55 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-6348) Problem with QueuedPessimisticEJBLock and Arjuna
[
https://jira.jboss.org/jira/browse/JBAS-6348?page=com.atlassian.jira.plug...
]
Vadim Kopichenko commented on JBAS-6348:
----------------------------------------
JBoss 4.2.0.GA is also affected.
Threads happen to hang with stacktrace like this:
threadState:TIMED_WAITING,
lockName:org.jboss.ejb.plugins.lock.QueuedPessimisticEJBLock$TxLock@db42b8
java.lang.Object.wait(Native Method)
org.jboss.ejb.plugins.lock.QueuedPessimisticEJBLock.waitForTx(QueuedPessimisticEJBLock.java:323)
org.jboss.ejb.plugins.lock.QueuedPessimisticEJBLock.doSchedule(QueuedPessimisticEJBLock.java:230)
Problem with QueuedPessimisticEJBLock and Arjuna
------------------------------------------------
Key: JBAS-6348
URL: https://jira.jboss.org/jira/browse/JBAS-6348
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transaction Manager (Arjuna)
Affects Versions: JBossAS-4.2.3.GA
Reporter: Ole Husgaard
Assignee: Jonathan Halliday
When using Arjuna, QueuedPessimisticEJBLock does not always properly detect that a
waiting tx has timed out. The problem is that QueuedPessimisticEJBLock was written for the
old TM, which did not rollback transactions on timeout, but only marked them for rollback.
Now that Arjuna is in play, it has to check for rolled back transactions too.
The isTxExpired() method should be changed to something like this:
protected boolean isTxExpired(Transaction miTx) throws Exception {
if (miTx != null
&& (miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK || miTx.getStatus() ==
Status.STATUS_ROLLEDBACK)) {
return true;
}
return false;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:01 a.m.
New subject: [JBoss JIRA] Updated: (JBAS-6348) Problem with QueuedPessimisticEJBLock and Arjuna
[
https://issues.jboss.org/browse/JBAS-6348?page=com.atlassian.jira.plugin....
]
Alexey Loubyansky updated JBAS-6348:
------------------------------------
Assignee: Alexey Loubyansky (was: Jonathan Halliday)
Fix Version/s: 6.0.0.Final
Problem with QueuedPessimisticEJBLock and Arjuna
------------------------------------------------
Key: JBAS-6348
URL: https://issues.jboss.org/browse/JBAS-6348
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transaction Manager Integration (Arjuna)
Affects Versions: JBossAS-4.2.3.GA
Reporter: Ole Husgaard
Assignee: Alexey Loubyansky
Fix For: 6.0.0.Final
When using Arjuna, QueuedPessimisticEJBLock does not always properly detect that a
waiting tx has timed out. The problem is that QueuedPessimisticEJBLock was written for the
old TM, which did not rollback transactions on timeout, but only marked them for rollback.
Now that Arjuna is in play, it has to check for rolled back transactions too.
The isTxExpired() method should be changed to something like this:
protected boolean isTxExpired(Transaction miTx) throws Exception {
if (miTx != null
&& (miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK || miTx.getStatus() ==
Status.STATUS_ROLLEDBACK)) {
return true;
}
return false;
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:03 a.m.
New subject: [JBoss JIRA] Resolved: (JBAS-6348) Problem with QueuedPessimisticEJBLock and Arjuna
[
https://issues.jboss.org/browse/JBAS-6348?page=com.atlassian.jira.plugin....
]
Alexey Loubyansky resolved JBAS-6348.
-------------------------------------
Resolution: Done
It's been committed to the AS trunk and will be available in 6.0.0.Final.
Thanks!
--- src/main/java/org/jboss/ejb/plugins/lock/QueuedPessimisticEJBLock.java (revision
109990)
+++ src/main/java/org/jboss/ejb/plugins/lock/QueuedPessimisticEJBLock.java (working copy)
@@ -177,11 +177,12 @@
protected boolean isTxExpired(Transaction miTx) throws Exception
{
- if (miTx != null && miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK)
- {
- return true;
- }
- return false;
+ if(miTx == null)
+ return false;
+ int status = miTx.getStatus();
+ return status == Status.STATUS_MARKED_ROLLBACK ||
+ status == Status.STATUS_ROLLEDBACK ||
+ status == Status.STATUS_ROLLING_BACK;
Problem with QueuedPessimisticEJBLock and Arjuna
------------------------------------------------
Key: JBAS-6348
URL: https://issues.jboss.org/browse/JBAS-6348
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transaction Manager Integration (Arjuna)
Affects Versions: JBossAS-4.2.3.GA
Reporter: Ole Husgaard
Assignee: Alexey Loubyansky
Fix For: 6.0.0.Final
When using Arjuna, QueuedPessimisticEJBLock does not always properly detect that a
waiting tx has timed out. The problem is that QueuedPessimisticEJBLock was written for the
old TM, which did not rollback transactions on timeout, but only marked them for rollback.
Now that Arjuna is in play, it has to check for rolled back transactions too.
The isTxExpired() method should be changed to something like this:
protected boolean isTxExpired(Transaction miTx) throws Exception {
if (miTx != null
&& (miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK || miTx.getStatus() ==
Status.STATUS_ROLLEDBACK)) {
return true;
}
return false;
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:25 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-6348) Problem with QueuedPessimisticEJBLock and Arjuna
[
https://issues.jboss.org/browse/JBAS-6348?page=com.atlassian.jira.plugin....
]
Jan Nielsen commented on JBAS-6348:
-----------------------------------
I can't help but notice that the method isTxExpired(...) with the particular
implementation can be found in three different classes, but the patch only affects one of
them. Should the other two not have the same fix as well?
jboss-4.2.3.GA-src\aspects\src\main\org\jboss\aspects\txlock\QueuedTxLock.java
jboss-4.2.3.GA-src\server\src\main\org\jboss\ejb\plugins\EntityReentranceInterceptor.java
jboss-4.2.3.GA-src\server\src\main\org\jboss\ejb\plugins\lock\QueuedPessimisticEJBLock.java
Problem with QueuedPessimisticEJBLock and Arjuna
------------------------------------------------
Key: JBAS-6348
URL: https://issues.jboss.org/browse/JBAS-6348
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transaction Manager Integration (Arjuna)
Affects Versions: JBossAS-4.2.3.GA
Reporter: Ole Husgaard
Assignee: Alexey Loubyansky
Fix For: 6.0.0.Final
When using Arjuna, QueuedPessimisticEJBLock does not always properly detect that a
waiting tx has timed out. The problem is that QueuedPessimisticEJBLock was written for the
old TM, which did not rollback transactions on timeout, but only marked them for rollback.
Now that Arjuna is in play, it has to check for rolled back transactions too.
The isTxExpired() method should be changed to something like this:
protected boolean isTxExpired(Transaction miTx) throws Exception {
if (miTx != null
&& (miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK || miTx.getStatus() ==
Status.STATUS_ROLLEDBACK)) {
return true;
}
return false;
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:49 a.m.
New subject: [JBoss JIRA] Reopened: (JBAS-6348) Problem with QueuedPessimisticEJBLock and Arjuna
[
https://issues.jboss.org/browse/JBAS-6348?page=com.atlassian.jira.plugin....
]
Alexey Loubyansky reopened JBAS-6348:
-------------------------------------
Right. I've searched and found a couple of places that need fixing as well.
Not sure about the maintenance of the aspects though. They are not a part of the AS. At
least a different jira issue as to be created for that.
Problem with QueuedPessimisticEJBLock and Arjuna
------------------------------------------------
Key: JBAS-6348
URL: https://issues.jboss.org/browse/JBAS-6348
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transaction Manager Integration (Arjuna)
Affects Versions: JBossAS-4.2.3.GA
Reporter: Ole Husgaard
Assignee: Alexey Loubyansky
Fix For: 6.0.0.Final
When using Arjuna, QueuedPessimisticEJBLock does not always properly detect that a
waiting tx has timed out. The problem is that QueuedPessimisticEJBLock was written for the
old TM, which did not rollback transactions on timeout, but only marked them for rollback.
Now that Arjuna is in play, it has to check for rolled back transactions too.
The isTxExpired() method should be changed to something like this:
protected boolean isTxExpired(Transaction miTx) throws Exception {
if (miTx != null
&& (miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK || miTx.getStatus() ==
Status.STATUS_ROLLEDBACK)) {
return true;
}
return false;
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:02 a.m.
New subject: [JBoss JIRA] Resolved: (JBAS-6348) Problem with QueuedPessimisticEJBLock and Arjuna
[
https://issues.jboss.org/browse/JBAS-6348?page=com.atlassian.jira.plugin....
]
Alexey Loubyansky resolved JBAS-6348.
-------------------------------------
Resolution: Done
Fixed.
Problem with QueuedPessimisticEJBLock and Arjuna
------------------------------------------------
Key: JBAS-6348
URL: https://issues.jboss.org/browse/JBAS-6348
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Transaction Manager Integration (Arjuna)
Affects Versions: JBossAS-4.2.3.GA
Reporter: Ole Husgaard
Assignee: Alexey Loubyansky
Fix For: 6.0.0.Final
When using Arjuna, QueuedPessimisticEJBLock does not always properly detect that a
waiting tx has timed out. The problem is that QueuedPessimisticEJBLock was written for the
old TM, which did not rollback transactions on timeout, but only marked them for rollback.
Now that Arjuna is in play, it has to check for rolled back transactions too.
The isTxExpired() method should be changed to something like this:
protected boolean isTxExpired(Transaction miTx) throws Exception {
if (miTx != null
&& (miTx.getStatus() == Status.STATUS_MARKED_ROLLBACK || miTx.getStatus() ==
Status.STATUS_ROLLEDBACK)) {
return true;
}
return false;
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5714
days inactive
6435
days old
7 comments
5 participants
participants (5)
-
Alexey Loubyansky (JIRA) -
Jan Nielsen (JIRA)
-
Ole Husgaard (JIRA)
-
Pieter Bos (JIRA)
-
Vadim Kopichenko (JIRA)