[ http://jira.jboss.com/jira/browse/JBAOP-560?page=all ] Flavia Rainone reassigned JBAOP-560: ------------------------------------ Assignee: Flavia Rainone -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-560?page=comments#action_12409789 ] Flavia Rainone commented on JBAOP-560: -------------------------------------- On generated advisor mode, we need to check how we are going to do this. Since the calls to advices is hard coded, we will need either an if statement to check if the aspect is null before calling the advice, or we will need to create dummy aspects. I wonder what would affect less the performance: calling a dummy advice, or having the extra cost of a check for null for each aspect every time the intercepted joinpoint gets invoked. We need to take into account how frequent is this feature going to be used. If it will be rarely used (i.e., only a few scenarios), I vote for the dummy aspect, because this is not going to affect the performance of the common scenario, where the factories return non-null aspects. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-560?page=comments#action_12411504 ] Flavia Rainone commented on JBAOP-560: -------------------------------------- I was mistaken. There is not need for dummy aspects and the like. The joinpoint classes are generated based on interceptor chains. So, implementing this feature only requires changes to the class advisor class... during the moment in which chains are built. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-560?page=comments#action_12412495 ] Kabir Khan commented on JBAOP-560: ---------------------------------- Yeah some constant value should do -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-560?page=comments#action_12413360 ] Flavia Rainone commented on JBAOP-560: -------------------------------------- The mentioned problem is currently a corner case. We are going to ignore it for now, and we will return to it later if needed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-560?page=all ] Kabir Khan reopened JBAOP-560: ------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAOP-560?page=all ] Kabir Khan closed JBAOP-560. ---------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira