[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Brian Stansberry updated EJBTHREE-1442: --------------------------------------- Attachment: EJB3-CL-Leak-Report.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger commented on EJBTHREE-1442: ----------------------------------------------- This is the first TestSuite run after the upgrade to EJB3 Core 0.1.8, which binds for the first time interface-specific proxies. Ensure they're unbound. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger commented on EJBTHREE-1442: ----------------------------------------------- Maybe this one will help: http://fisheye.jboss.org/changelog/~author=alrubinger/JBossAS/?cs=77085 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger commented on EJBTHREE-1442: ----------------------------------------------- EJBTHREE-1473 brings errors to: Tests run: 5, Failures: 1, Errors: 0, Time elapsed: 112.329 sec ...with the remaining failure in testSimpleEjb. This is due to an InvocationResponse holding a reference to a Proxy. CL Leaks will persist in AS TestSuite until at least the next release of EJB3 Core. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger updated EJBTHREE-1442: ------------------------------------------ Attachment: EJBTHREE-1442.png Attached screenshot of heap graph during profiling, showing a Proxy held by an InvocationResponse. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Ron Sigal commented on EJBTHREE-1442: ------------------------------------- I think I might see what's happening, though I don't know why the problem would suddenly appear. In Remoting 1.x, we used to marshal objects like so: oos.writeObject(dataObject); oos.reset(); // to make sure stream gets reset // Stupid ObjectInputStream holds object graph // can only be set by the client/server sending a TC_RESET oos.writeObject(Boolean.TRUE); oos.flush(); oos.reset(); Each call to ObjectOutputStream.reset() clears the HandleTable that shows up in Andrew's picture. It also writes a TC_RESET byte to the stream, which interfered with the version byte we started writing in Remoting 2.0. So, I changed the marshalling code to oos.reset(); oos.writeObject(dataObject); oos.flush(); So HandleTable gets cleared every time except the last time, which is probably the source of the problem. Clebert tracked the problem down on the input side (ObjectInputStream) when Brian's classloader leak test failed, and he used reflection to grab the private method ObjectInputStream.clear(), which clears HandleTable without sending the TC_RESET byte. It looks like I should do the same on the sending ObjectOutputStream. Make sense? How urgent is this? Given that the component cutoff date is Friday, the fix probably won't make it into AS 5.0.0.CR2. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger commented on EJBTHREE-1442: ----------------------------------------------- I'd like to see the impact of calling ObjectOutputStream.clear() via reflection; we can even test it by bringing in a remoting SNAPSHOT. Assuming I've found the only source of a leak in the attached image, there isn't a reference chain I have access to within EJB3. As I understand it, this is a prereq for CR2. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Ron Sigal commented on EJBTHREE-1442: ------------------------------------- Ah, do you need the jar in a repository to run your test? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger commented on EJBTHREE-1442: ----------------------------------------------- Ron's suggested changes properly clean up the held reference to an EJB3 Proxy, but the test has transient failure of 1 (about 1/2 the time) likely due to lag in GC. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Carlo de Wolf updated EJBTHREE-1442: ------------------------------------ Fix Version/s: 1.0.0-Beta2 (was: 1.0.0-Beta1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger updated EJBTHREE-1442: ------------------------------------------ Attachment: (was: Ejb3JBoss5Deployment-allocation.png) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger updated EJBTHREE-1442: ------------------------------------------ Attachment: (was: EJBTHREE-1442.png) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger commented on EJBTHREE-1442: ----------------------------------------------- CL Leak persists. My working theory is that the CL is held as "contextClassLoader" field of ServerThread, which is not shut down at end of invocations or upon undeploy. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Adrian Brock updated EJBTHREE-1442: ----------------------------------- Attachment: Proxy.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger commented on EJBTHREE-1442: ----------------------------------------------- Passing in the JDK6 Hudson run: http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-Test... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/EJBTHREE-1442?page=com.atlassian.jira.... ] Andrew Lee Rubinger resolved EJBTHREE-1442. ------------------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira