]
Ken Finnigan commented on WFLY-13127:
-------------------------------------
[~pferraro] it's available ->
NPE in OpenApiAnnotationScanner when OpenTracing TCK war is deployed
--------------------------------------------------------------------
Key: WFLY-13127
URL:
https://issues.redhat.com/browse/WFLY-13127
Project: WildFly
Issue Type: Bug
Components: MP OpenAPI, MP OpenTracing
Affects Versions: 19.0.0.Beta2
Reporter: Brian Stansberry
Assignee: Paul Ferraro
Priority: Blocker
Fix For: 19.0.0.Beta3, 20.0.0.Beta1
I tried running the microprofile-tck/opentracing tests against a config that included the
OpenAPI subsystem. It failed with an NPE:
{code}
2020-02-18 16:36:53,302 INFO [org.jboss.as.repository] (management-handler-thread - 1)
WFLYDR0001: Content added at location
/Users/bstansberry/dev/wildfly/wildfly/testsuite/integration/microprofile-tck/opentracing/target/wildfly/standalone/data/content/85/48e223eb8bfcd73f66458e14a0bbc425998a70/content
2020-02-18 16:36:53,313 INFO [org.jboss.as.server.deployment] (MSC service thread 1-4)
WFLYSRV0027: Starting deployment of "opentracing.war" (runtime-name:
"opentracing.war")
2020-02-18 16:36:54,020 INFO [org.jboss.weld.deployer] (MSC service thread 1-7)
WFLYWELD0003: Processing weld deployment opentracing.war
2020-02-18 16:36:54,114 INFO [org.hibernate.validator.internal.util.Version] (MSC
service thread 1-7) HV000001: Hibernate Validator 6.0.18.Final
2020-02-18 16:36:54,330 INFO [org.jboss.weld.Version] (MSC service thread 1-8)
WELD-000900: 3.1.3 (Final)
2020-02-18 16:36:54,576 INFO [io.smallrye.metrics] (MSC service thread 1-5)
MicroProfile: Metrics activated (SmallRye Metrics version: 2.4.0)
2020-02-18 16:36:54,992 WARN [org.wildfly.extension.undertow] (MSC service thread 1-8)
WFLYUT0101: Duplicate servlet mapping /rest/* found
2020-02-18 16:36:55,173 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-3)
MSC000001: Failed to start service
org.wildfly.undertow.host.default-server.default-host./openapi:
org.jboss.msc.service.StartException in service
org.wildfly.undertow.host.default-server.default-host./openapi:
java.lang.NullPointerException
at org.wildfly.clustering.service.FunctionalService.start(FunctionalService.java:66)
at
org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1739)
at
org.jboss.msc.service.ServiceControllerImpl$StartTask.execute(ServiceControllerImpl.java:1701)
at
org.jboss.msc.service.ServiceControllerImpl$ControllerTask.run(ServiceControllerImpl.java:1559)
at
org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:1982)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1486)
at
org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1377)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
at
io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner.createResponseFromJaxRsMethod(OpenApiAnnotationScanner.java:934)
at
io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner.processJaxRsMethod(OpenApiAnnotationScanner.java:688)
at
io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner.lambda$processJaxRsResourceClass$0(OpenApiAnnotationScanner.java:422)
at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
at java.util.HashMap$KeySpliterator.forEachRemaining(HashMap.java:1556)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472)
at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485)
at
io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner.processJaxRsResourceClass(OpenApiAnnotationScanner.java:420)
at
io.smallrye.openapi.runtime.scanner.OpenApiAnnotationScanner.scan(OpenApiAnnotationScanner.java:221)
at
io.smallrye.openapi.runtime.OpenApiProcessor.modelFromAnnotations(OpenApiProcessor.java:72)
at
org.wildfly.extension.microprofile.openapi.deployment.OpenAPIModelServiceConfigurator.get(OpenAPIModelServiceConfigurator.java:173)
at
org.wildfly.extension.microprofile.openapi.deployment.OpenAPIModelServiceConfigurator.get(OpenAPIModelServiceConfigurator.java:94)
at org.wildfly.clustering.service.FunctionalService.start(FunctionalService.java:63)
... 8 more
{code}
I hit this when working on WFLY-13099. I was using a standalone.xml variant equivalent to
what Galleon would generate using the cloud-server, h2-default-datasource,
microprofile-fault-tolerance, microprofile-jwt and microprofile-openapi layers. It
wasn't a slimmed server though.
OpenApiAnnotationScanner L934 seems to assume 'schema' will not be null. But the
'SchemaFactory.typeToSchema' method seems like it's written such that
returning null is a possibility; e.g. L362 in the final 'else' block is doing a
null check on the 'schema' var whose value is ultimately returned. (I don't
see how else the NPE would happen other than SchemaFactory.typeToSchema returning null.)
I put Critical severity on this because I don't know anything about opentracing.war;
i.e. whether it's written in a way that would be a real corner case for OpenAPI.
I'm being conservative and assigning a high priority.
[~ehugonnet] FYI.