11:58 a.m.
Add API to manipulate JChannelFactory stacks member
---------------------------------------------------
Key: JGRP-988
URL: https://jira.jboss.org/jira/browse/JGRP-988
Project: JGroups
Issue Type: Feature Request
Reporter: Brian Stansberry
Assignee: Bela Ban
Fix For: 2.6.11
I'd like to see the following methods added to JChannelFactory to go along with the
existing getConfig and removeConfig. These will allow the JBoss AS-specific subclass to
update the contents of the "stacks" member in response to updates from
management tools like the embedded console or Jopr:
public boolean addConfig(String stack_name, String config, boolean replace) {
boolean added = replace;
if(replace) {
stacks.put(st_name, val);
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(!stacks.containsKey(st_name)) {
stacks.put(st_name, val);
added = true;
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(log.isTraceEnabled())
log.trace("didn't add config '" + st_name + " because
one of the same name already existed");
}
return added;
}
public Set<String> getConfigNames() {
return Collections.unmodifiableSet(stacks.keySet());
}
Bela, I've assigned this to you to get your feedback on it, but I'd be happy to do
it. Just assign back to me.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:46 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-988) Add API to manipulate JChannelFactory stacks member
[
https://jira.jboss.org/jira/browse/JGRP-988?page=com.atlassian.jira.plugi...
]
Bela Ban commented on JGRP-988:
-------------------------------
I have no objection, but I'm questioning in general whether we should trash
JChannelFactory. It is IMO pretty useless, new apps inject channels anyway, and that
mechanism is external.
Can't we move this entire class into JBoss AS ? I'll definitely trash it in
3.0...
Add API to manipulate JChannelFactory stacks member
---------------------------------------------------
Key: JGRP-988
URL: https://jira.jboss.org/jira/browse/JGRP-988
Project: JGroups
Issue Type: Feature Request
Reporter: Brian Stansberry
Assignee: Bela Ban
Fix For: 2.6.11
I'd like to see the following methods added to JChannelFactory to go along with the
existing getConfig and removeConfig. These will allow the JBoss AS-specific subclass to
update the contents of the "stacks" member in response to updates from
management tools like the embedded console or Jopr:
public boolean addConfig(String stack_name, String config, boolean replace) {
boolean added = replace;
if(replace) {
stacks.put(st_name, val);
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(!stacks.containsKey(st_name)) {
stacks.put(st_name, val);
added = true;
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(log.isTraceEnabled())
log.trace("didn't add config '" + st_name + " because
one of the same name already existed");
}
return added;
}
public Set<String> getConfigNames() {
return Collections.unmodifiableSet(stacks.keySet());
}
Bela, I've assigned this to you to get your feedback on it, but I'd be happy to
do it. Just assign back to me.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 p.m.
New subject: [JBoss JIRA] Assigned: (JGRP-988) Add API to manipulate JChannelFactory stacks member
[
https://jira.jboss.org/jira/browse/JGRP-988?page=com.atlassian.jira.plugi...
]
Brian Stansberry reassigned JGRP-988:
-------------------------------------
Assignee: Brian Stansberry (was: Bela Ban)
I'd prefer to have the class in AS. The problem is JBC and JBM use the JGroups
version, so the AS is forced to subclass it to be compatible.
I'll think about it a bit; if you aren't going to ever change this class I could
simply move the entire impl into the AS class and almost treat the JGroups class as an
interface. Save the JGroups project the hassle of making changes, putting them in releases
etc.
Add API to manipulate JChannelFactory stacks member
---------------------------------------------------
Key: JGRP-988
URL: https://jira.jboss.org/jira/browse/JGRP-988
Project: JGroups
Issue Type: Feature Request
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Fix For: 2.6.11
I'd like to see the following methods added to JChannelFactory to go along with the
existing getConfig and removeConfig. These will allow the JBoss AS-specific subclass to
update the contents of the "stacks" member in response to updates from
management tools like the embedded console or Jopr:
public boolean addConfig(String stack_name, String config, boolean replace) {
boolean added = replace;
if(replace) {
stacks.put(st_name, val);
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(!stacks.containsKey(st_name)) {
stacks.put(st_name, val);
added = true;
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(log.isTraceEnabled())
log.trace("didn't add config '" + st_name + " because
one of the same name already existed");
}
return added;
}
public Set<String> getConfigNames() {
return Collections.unmodifiableSet(stacks.keySet());
}
Bela, I've assigned this to you to get your feedback on it, but I'd be happy to
do it. Just assign back to me.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-988) Add API to manipulate JChannelFactory stacks member
[
https://jira.jboss.org/jira/browse/JGRP-988?page=com.atlassian.jira.plugi...
]
Brian Stansberry commented on JGRP-988:
---------------------------------------
Sorry; that last comment was totally off-base. JBC uses the ChannelFactory interface, not
the JChannelFactory class. I have a memory of needing to subclass for some reason, but
perhaps I'm wrong; maybe the AS version just started off as a minor extension that has
now grown so large it shouldn't be a subclass. I'll keep poking.
Add API to manipulate JChannelFactory stacks member
---------------------------------------------------
Key: JGRP-988
URL: https://jira.jboss.org/jira/browse/JGRP-988
Project: JGroups
Issue Type: Feature Request
Reporter: Brian Stansberry
Assignee: Brian Stansberry
Fix For: 2.6.11
I'd like to see the following methods added to JChannelFactory to go along with the
existing getConfig and removeConfig. These will allow the JBoss AS-specific subclass to
update the contents of the "stacks" member in response to updates from
management tools like the embedded console or Jopr:
public boolean addConfig(String stack_name, String config, boolean replace) {
boolean added = replace;
if(replace) {
stacks.put(st_name, val);
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(!stacks.containsKey(st_name)) {
stacks.put(st_name, val);
added = true;
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(log.isTraceEnabled())
log.trace("didn't add config '" + st_name + " because
one of the same name already existed");
}
return added;
}
public Set<String> getConfigNames() {
return Collections.unmodifiableSet(stacks.keySet());
}
Bela, I've assigned this to you to get your feedback on it, but I'd be happy to
do it. Just assign back to me.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:42 p.m.
New subject: [JBoss JIRA] Closed: (JGRP-988) Add API to manipulate JChannelFactory stacks member
[
https://jira.jboss.org/jira/browse/JGRP-988?page=com.atlassian.jira.plugi...
]
Brian Stansberry closed JGRP-988.
---------------------------------
Fix Version/s: (was: 2.6.11)
Resolution: Won't Fix
Never mind; it's better for the AS to stop subclassing; that works fine: JBAS-7009
Add API to manipulate JChannelFactory stacks member
---------------------------------------------------
Key: JGRP-988
URL: https://jira.jboss.org/jira/browse/JGRP-988
Project: JGroups
Issue Type: Feature Request
Reporter: Brian Stansberry
Assignee: Brian Stansberry
I'd like to see the following methods added to JChannelFactory to go along with the
existing getConfig and removeConfig. These will allow the JBoss AS-specific subclass to
update the contents of the "stacks" member in response to updates from
management tools like the embedded console or Jopr:
public boolean addConfig(String stack_name, String config, boolean replace) {
boolean added = replace;
if(replace) {
stacks.put(st_name, val);
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(!stacks.containsKey(st_name)) {
stacks.put(st_name, val);
added = true;
if(log.isTraceEnabled())
log.trace("added config '" + st_name + "'");
}
else {
if(log.isTraceEnabled())
log.trace("didn't add config '" + st_name + " because
one of the same name already existed");
}
return added;
}
public Set<String> getConfigNames() {
return Collections.unmodifiableSet(stacks.keySet());
}
Bela, I've assigned this to you to get your feedback on it, but I'd be happy to
do it. Just assign back to me.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6268
days inactive
6269
days old
4 comments
2 participants
participants (2)
-
Bela Ban (JIRA) -
Brian Stansberry (JIRA)