1:10 a.m.
Incorrect value for boolean parameter
-------------------------------------
Key: JBAS-9140
URL: https://issues.jboss.org/browse/JBAS-9140
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: CLI
Reporter: Brian Stansberry
Assignee: Alexey Loubyansky
With the latest from master, this operation:
/socket-binding-group=standard-sockets/socket-binding=http:write-attribute(name=fixed-port,value=true)
results in this operation on the server (incorrect value):
{
"operation" => "write-attribute",
"name" => "fixed-port",
"value" => false,
"address" => [
("socket-binding-group" => "standard-sockets"),
("socket-binding" => "http")
]
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:09 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-9140) Incorrect value for boolean parameter
[
https://issues.jboss.org/browse/JBAS-9140?page=com.atlassian.jira.plugin....
]
Alexey Loubyansky commented on JBAS-9140:
-----------------------------------------
I guess, you have to quote it. I mentioned it once, that it used to work w/o the quotes
but then something changed (not on the cli side).
Do you want the cli to recognize and add the quotes in case of boolean properties?
Incorrect value for boolean parameter
-------------------------------------
Key: JBAS-9140
URL: https://issues.jboss.org/browse/JBAS-9140
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CLI
Reporter: Brian Stansberry
Assignee: Alexey Loubyansky
With the latest from master, this operation:
/socket-binding-group=standard-sockets/socket-binding=http:write-attribute(name=fixed-port,value=true)
results in this operation on the server (incorrect value):
{
"operation" => "write-attribute",
"name" => "fixed-port",
"value" => false,
"address" => [
("socket-binding-group" => "standard-sockets"),
("socket-binding" => "http")
]
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:15 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-9140) Incorrect value for boolean parameter
[
https://issues.jboss.org/browse/JBAS-9140?page=com.atlassian.jira.plugin....
]
Brian Stansberry commented on JBAS-9140:
----------------------------------------
If you can figure out what changed elsewhere, that would be better than quoting. I'm
concerned it's a jboss-dmr bug.
But if you can't figure it out fairly quickly or it's not a bug, yes, recognizing
and quoting should be fine. That should result in a ModelNode of ModelType.STRING, and if
you call .asBoolean() on that you get back a proper answer. Only negative is if some
OperationHandler directly stores the operation value, the internal model will have, e.g.
"fixed-port" => "true"
instead of
"fixed-port" => true
Not a big deal, just not tidy.
Can you point me where in the CLI this ModelNode gets created? I poked a bit, but
didn't see it. I'm curious to know regardless of how we fix this. :)
Incorrect value for boolean parameter
-------------------------------------
Key: JBAS-9140
URL: https://issues.jboss.org/browse/JBAS-9140
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CLI
Reporter: Brian Stansberry
Assignee: Alexey Loubyansky
With the latest from master, this operation:
/socket-binding-group=standard-sockets/socket-binding=http:write-attribute(name=fixed-port,value=true)
results in this operation on the server (incorrect value):
{
"operation" => "write-attribute",
"name" => "fixed-port",
"value" => false,
"address" => [
("socket-binding-group" => "standard-sockets"),
("socket-binding" => "http")
]
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:17 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-9140) Incorrect value for boolean parameter
[
https://issues.jboss.org/browse/JBAS-9140?page=com.atlassian.jira.plugin....
]
Alexey Loubyansky commented on JBAS-9140:
-----------------------------------------
It's in
org.jboss.as.cli.operation.impl.DefaultOperationRequestBuilder.addProperty(...).
As you can see the default is ModelNode.fromString(value) and in case of exception new
ModelNode().set(value).
I'll look into that.
Incorrect value for boolean parameter
-------------------------------------
Key: JBAS-9140
URL: https://issues.jboss.org/browse/JBAS-9140
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CLI
Reporter: Brian Stansberry
Assignee: Alexey Loubyansky
With the latest from master, this operation:
/socket-binding-group=standard-sockets/socket-binding=http:write-attribute(name=fixed-port,value=true)
results in this operation on the server (incorrect value):
{
"operation" => "write-attribute",
"name" => "fixed-port",
"value" => false,
"address" => [
("socket-binding-group" => "standard-sockets"),
("socket-binding" => "http")
]
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:33 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-9140) Incorrect value for boolean parameter
[
https://issues.jboss.org/browse/JBAS-9140?page=com.atlassian.jira.plugin....
]
Alexey Loubyansky updated JBAS-9140:
------------------------------------
Attachment: diff.log
diff2.log
I think it's a bug in the dmr. It should be tested there, btw.
I don't know what I'm doing but the two attached fixes worked for me.
Incorrect value for boolean parameter
-------------------------------------
Key: JBAS-9140
URL: https://issues.jboss.org/browse/JBAS-9140
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CLI
Reporter: Brian Stansberry
Assignee: Alexey Loubyansky
Attachments: diff.log, diff2.log
With the latest from master, this operation:
/socket-binding-group=standard-sockets/socket-binding=http:write-attribute(name=fixed-port,value=true)
results in this operation on the server (incorrect value):
{
"operation" => "write-attribute",
"name" => "fixed-port",
"value" => false,
"address" => [
("socket-binding-group" => "standard-sockets"),
("socket-binding" => "http")
]
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:54 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-9140) Incorrect value for boolean parameter
[
https://issues.jboss.org/browse/JBAS-9140?page=com.atlassian.jira.plugin....
]
Brian Stansberry commented on JBAS-9140:
----------------------------------------
Thanks for looking at this. I submitted
https://github.com/bstansberry/jboss-dmr/commit/43c66969995112b53eb329ebd...
for review -- based on the simpler looking of your two patches ;) since I'm no expert
on this either but it provides the same semantic as what's their now. The unit test I
added caught a bug in the long handling as well.
Incorrect value for boolean parameter
-------------------------------------
Key: JBAS-9140
URL: https://issues.jboss.org/browse/JBAS-9140
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CLI
Reporter: Brian Stansberry
Assignee: Alexey Loubyansky
Attachments: diff.log, diff2.log
With the latest from master, this operation:
/socket-binding-group=standard-sockets/socket-binding=http:write-attribute(name=fixed-port,value=true)
results in this operation on the server (incorrect value):
{
"operation" => "write-attribute",
"name" => "fixed-port",
"value" => false,
"address" => [
("socket-binding-group" => "standard-sockets"),
("socket-binding" => "http")
]
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:28 p.m.
New subject: [JBoss JIRA] Resolved: (JBAS-9140) Incorrect value for boolean parameter
[
https://issues.jboss.org/browse/JBAS-9140?page=com.atlassian.jira.plugin....
]
Brian Stansberry resolved JBAS-9140.
------------------------------------
Fix Version/s: 7.0.0.Beta2
Resolution: Done
With the resolution of JBAS-9179, this problem is fixed.
Incorrect value for boolean parameter
-------------------------------------
Key: JBAS-9140
URL: https://issues.jboss.org/browse/JBAS-9140
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: CLI
Reporter: Brian Stansberry
Assignee: Alexey Loubyansky
Fix For: 7.0.0.Beta2
Attachments: diff.log, diff2.log
With the latest from master, this operation:
/socket-binding-group=standard-sockets/socket-binding=http:write-attribute(name=fixed-port,value=true)
results in this operation on the server (incorrect value):
{
"operation" => "write-attribute",
"name" => "fixed-port",
"value" => false,
"address" => [
("socket-binding-group" => "standard-sockets"),
("socket-binding" => "http")
]
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4774
days inactive
4781
days old
6 comments
2 participants
participants (2)
-
Alexey Loubyansky (JIRA) -
Brian Stansberry (JIRA)