[ http://jira.jboss.com/jira/browse/JBAS-5623?page=all ] Adrian Brock reopened JBAS-5623: -------------------------------- -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5623?page=comments#action_12416790 ] Adrian Brock commented on JBAS-5623: ------------------------------------ I've changed the title of this since this part of the spec is non-normative. JCA 1.5 section B.2 "The following is a description of the __recommended__ set of JMS ActivationSpec JavaBean properties:" I've re-opened for Jesper to "fix" it properly. You can't just change these values. Other people already make use of the documentated values: http://wiki.jboss.org/wiki/ConfigJMSMessageListener Just changing the accepted values breaks their configurations. But also, it breaks our own mapping of the legacy ejb-jar.xml configuration to the jca 1.5 mechanism which is where the original values came from: http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/trunk/server/src/main/... The correct "fix" would be accept both sets of values. The documentation also needs updating as well. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBAS-5623?page=comments#action_12416795 ] Adrian Brock commented on JBAS-5623: ------------------------------------ Never mind, I didn't read the commit very well. You do accept both values: public void setAcknowledgeMode(String acknowledgeMode) { - if ("DUPS_OK_ACKNOWLEDGE".equals(acknowledgeMode)) + if ("DUPS_OK_ACKNOWLEDGE".equals(acknowledgeMode) || "Dups-ok-acknowledge".equals(acknowledgeMode)) this.acknowledgeMode = Session.DUPS_OK_ACKNOWLEDGE; - else if ("AUTO_ACKNOWLEDGE".equals(acknowledgeMode)) + else if ("AUTO_ACKNOWLEDGE".equals(acknowledgeMode) || "Auto-acknowledge".equals(acknowledgeMode)) this.acknowledgeMode = Session.AUTO_ACKNOWLEDGE; I've updated the WIKI page and will create a JIRA issue to change the main documentation. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira