]
Steve Ebersole commented on JASSIST-261:
----------------------------------------
Here is the exception this time:
{noformat}
java.lang.ClassNotFoundException: org.hibernate.jpa.test.enhancement.cases.domain.Simple
not found
at
org.hibernate.jpa.test.enhancement.InstrumentedClassLoader.loadClassBytes(InstrumentedClassLoader.java:96)
at
org.hibernate.jpa.test.enhancement.InstrumentedClassLoader.loadClass(InstrumentedClassLoader.java:41)
at
org.hibernate.jpa.test.enhancement.InterceptFieldClassFileTransformerTest.testEnhancement(InterceptFieldClassFileTransformerTest.java:62)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
at
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:531)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
at
org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
at
org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at jdk.internal.reflect.GeneratedMethodAccessor46.invoke(Unknown Source)
at
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:531)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at
org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
at
org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at
org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
at jdk.internal.reflect.GeneratedMethodAccessor45.invoke(Unknown Source)
at
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:531)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
at
org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
at
org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(java.base@9-ea/ThreadPoolExecutor.java:1158)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(java.base@9-ea/ThreadPoolExecutor.java:632)
at java.lang.Thread.run(java.base@9-ea/Thread.java:843)
Caused by: org.hibernate.jpa.internal.enhance.EnhancingClassTransformerImpl$1: Error
performing enhancement of org.hibernate.jpa.test.enhancement.cases.domain.Simple
at
org.hibernate.jpa.internal.enhance.EnhancingClassTransformerImpl.transform(EnhancingClassTransformerImpl.java:48)
at
org.hibernate.jpa.test.enhancement.InstrumentedClassLoader.loadClassBytes(InstrumentedClassLoader.java:87)
... 44 more
Caused by: org.hibernate.bytecode.enhance.spi.EnhancementException: Could not enhance
entity class [org.hibernate.jpa.test.enhancement.cases.domain.Simple] to add EntityEntry
getter
at
org.hibernate.bytecode.enhance.internal.EntityEnhancer.addEntityInstanceHandling(EntityEnhancer.java:75)
at
org.hibernate.bytecode.enhance.internal.EntityEnhancer.enhance(EntityEnhancer.java:52)
at org.hibernate.bytecode.enhance.spi.Enhancer.enhance(Enhancer.java:130)
at org.hibernate.bytecode.enhance.spi.Enhancer.enhance(Enhancer.java:73)
at
org.hibernate.jpa.internal.enhance.EnhancingClassTransformerImpl.transform(EnhancingClassTransformerImpl.java:45)
... 45 more
Caused by: javassist.CannotCompileException: [source error] no such class: Object
at javassist.CtNewMethod.make(CtNewMethod.java:79)
at javassist.CtNewMethod.make(CtNewMethod.java:45)
at org.hibernate.bytecode.enhance.internal.MethodWriter.write(MethodWriter.java:41)
at
org.hibernate.bytecode.enhance.internal.EntityEnhancer.addEntityInstanceHandling(EntityEnhancer.java:67)
... 49 more
Caused by: compile error: no such class: Object
at javassist.compiler.MemberResolver.searchImports(MemberResolver.java:470)
at javassist.compiler.MemberResolver.lookupClass(MemberResolver.java:414)
at javassist.compiler.MemberResolver.lookupClassByJvmName(MemberResolver.java:321)
at javassist.compiler.MemberResolver.lookupClass(MemberResolver.java:338)
at javassist.compiler.MemberResolver.lookupClass(MemberResolver.java:325)
at javassist.compiler.Javac.compileMethod(Javac.java:163)
at javassist.compiler.Javac.compile(Javac.java:95)
at javassist.CtNewMethod.make(CtNewMethod.java:74)
... 52 more
{noformat}
Issue with javassist on jdk 9b112
---------------------------------
Key: JASSIST-261
URL:
https://issues.jboss.org/browse/JASSIST-261
Project: Javassist
Issue Type: Bug
Affects Versions: 3.20.0-GA
Environment: Javassist with jdk 9b112
Reporter: Hoang Chuong Tran
Assignee: Shigeru Chiba
I am migrating a project to java 9, which also uses javassist to generate runtime code.
One test of mine fails on jdk 9b112 while it passes on jdk 8u77.
{noformat}
import static javassist.CtClass.voidType;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
import java.util.HashMap;
import java.util.Map;
import org.junit.Test;
import javassist.ClassClassPath;
import javassist.ClassPool;
import javassist.CtClass;
import javassist.CtField;
import javassist.CtMethod;
import javassist.CtNewMethod;
public class MyTests {
public static class MyObject {
protected Object field;
Object getField() {return field;}
public void setField(Object field) {}
}
@Test
public void test() throws InstantiationException, IllegalAccessException {
Class<? extends MyObject> clazz = compile(MyObject.class);
clazz.newInstance().setField(null);
}
/** Compile a transfer class */
public static synchronized Class<? extends MyObject> compile(Class<?>
targetClass) {
// Determine class setters
Map<String, Method> setters = extractSetters(targetClass);
ClassPool classPool = ClassPool.getDefault();
classPool.insertClassPath(new ClassClassPath(targetClass));
try {
// Compile a new transfer class on the fly
CtClass baseClass = classPool.get(MyObject.class.getName());
CtClass proxyClass = classPool.makeClass(targetClass.getName() +
"_Modified", baseClass);
for(Method originalSetter : setters.values()) {
// Create a field to hold the attribute
Class<?> fieldClass = originalSetter.getParameterTypes()[0];
CtClass fieldType = classPool.get(fieldClass.getName());
String fieldName = originalSetter.getName().substring(3);
CtField field = new CtField(fieldType, fieldName, proxyClass);
proxyClass.addField(field);
// Create a setter method to set that field
CtClass[] parameters = new CtClass[] { fieldType };
String setterBody = "{ System.out.println(\"Hello
World\"); }";
CtMethod setter = CtNewMethod.make(voidType, originalSetter.getName(),
parameters, new CtClass[0], setterBody, proxyClass);
proxyClass.addMethod(setter);
}
Class<? extends MyObject> javaClass =
proxyClass.toClass(targetClass.getClassLoader(), targetClass.getProtectionDomain());
return javaClass;
} catch(Exception e) {
throw new RuntimeException("Failure during transfer compilation for
" + targetClass, e);
}
}
/** Extract setter methods from a class */
public static Map<String, Method> extractSetters(Class<?> cls) {
Map<String, Method> setters = new HashMap<String, Method>();
for(Method method : cls.getMethods()) {
// Lookup setter methods
if(method.getName().startsWith("set")) {
// Only public setters
int modifiers = method.getModifiers();
if(Modifier.isPublic(modifiers)) {
Class<?>[] exceptions = method.getExceptionTypes();
Class<?>[] parameters = method.getParameterTypes();
Class<?> returnType = method.getReturnType();
if(exceptions.length <= 0 && parameters.length == 1
&& "void".equals(returnType.getName())) {
setters.put(method.getName(), method);
}
}
}
}
return setters;
}
}
{noformat}
On jdk 8u77, the {{compile()}} function returns with success and "Hello world"
is printed to the console.
On jdk 9b112, I got the following exception
{noformat}
java.lang.RuntimeException: Failure during transfer compilation for class
MyTests$MyObject
at MyTests.compile(MyTests.java:68)
at MyTests.test(MyTests.java:29)
at sun.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:531)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at
org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:670)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
at
org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)
Caused by: javassist.NotFoundException: java.lang.Object
at javassist.ClassPool.get(ClassPool.java:450)
at MyTests.compile(MyTests.java:51)
... 24 more
{noformat}
I suspect that is due to the jigsaw integration into the jdk.