[JBoss JIRA] Created: (JBMESSAGING-542) Closing connection inside MessageListener's onMessage() causes deadlock
5:59 p.m.
Closing connection inside MessageListener's onMessage() causes deadlock
-----------------------------------------------------------------------
Key: JBMESSAGING-542
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-542
Project: JBoss Messaging
Issue Type: Bug
Components: JMS Facade
Affects Versions: 1.0.1.CR4
Reporter: Ovidiu Feodorov
Assigned To: Ovidiu Feodorov
Fix For: 1.0.1.CR5, 1.2.0.Alpha1
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:37 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-542) Closing connection inside MessageListener's onMessage() causes deadlock
[ http://jira.jboss.com/jira/browse/JBMESSAGING-542?page=comments#action_12... ]
Ovidiu Feodorov commented on JBMESSAGING-542:
---------------------------------------------
Paliative fix:
if (Thread.currentThread().equals(sessionExecutor.getThread()))
{
// the current thread already closing this MessageCallbackHandler, so no need to
register
// another Closer (see http://jira.jboss.org/jira/browse/JBMESSAGING-542)
return;
}
in MessageCallbackHandler.waitForOnMessageToComplete()
However, if we allow the listener to close the connection within onMessage(), then
postDeliver() won't be able to pass by session's ClosedInterceptor, which now is
"closed", so we'll get an ERROR "Failed to deliver message" in the
logs. It's harmless, but ugly.
Closing connection inside MessageListener's onMessage() causes
deadlock
-----------------------------------------------------------------------
Key: JBMESSAGING-542
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-542
Project: JBoss Messaging
Issue Type: Bug
Components: JMS Facade
Affects Versions: 1.0.1.CR4
Reporter: Ovidiu Feodorov
Assigned To: Ovidiu Feodorov
Fix For: 1.2.0.Alpha1, 1.0.1.CR5
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:39 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-542) Closing connection inside MessageListener's onMessage() causes deadlock
[ http://jira.jboss.com/jira/browse/JBMESSAGING-542?page=all ]
Ovidiu Feodorov updated JBMESSAGING-542:
----------------------------------------
Comment: was deleted
Closing connection inside MessageListener's onMessage() causes
deadlock
-----------------------------------------------------------------------
Key: JBMESSAGING-542
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-542
Project: JBoss Messaging
Issue Type: Bug
Components: JMS Facade
Affects Versions: 1.0.1.CR4
Reporter: Ovidiu Feodorov
Assigned To: Ovidiu Feodorov
Fix For: 1.2.0.Alpha1, 1.0.1.CR5
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:39 p.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-542) Closing connection inside MessageListener's onMessage() causes deadlock
[ http://jira.jboss.com/jira/browse/JBMESSAGING-542?page=comments#action_12... ]
Ovidiu Feodorov commented on JBMESSAGING-542:
---------------------------------------------
Palliative fix:
if (Thread.currentThread().equals(sessionExecutor.getThread()))
{
return;
}
in MessageCallbackHandler.waitForOnMessageToComplete()
However, if we allow the listener to close the connection within onMessage(), then
postDeliver() won't be able to pass by session's ClosedInterceptor, which now is
"closed", so we'll get an ERROR "Failed to deliver message" in the
logs. It's harmless, but ugly.
Closing connection inside MessageListener's onMessage() causes
deadlock
-----------------------------------------------------------------------
Key: JBMESSAGING-542
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-542
Project: JBoss Messaging
Issue Type: Bug
Components: JMS Facade
Affects Versions: 1.0.1.CR4
Reporter: Ovidiu Feodorov
Assigned To: Ovidiu Feodorov
Fix For: 1.2.0.Alpha1, 1.0.1.CR5
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:28 a.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-542) Closing connection inside MessageListener's onMessage() causes deadlock
[ http://jira.jboss.com/jira/browse/JBMESSAGING-542?page=all ]
Ovidiu Feodorov updated JBMESSAGING-542:
----------------------------------------
Fix Version/s: (was: 1.2.0.Alpha1)
Closing connection inside MessageListener's onMessage() causes
deadlock
-----------------------------------------------------------------------
Key: JBMESSAGING-542
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-542
Project: JBoss Messaging
Issue Type: Bug
Components: JMS Facade
Affects Versions: 1.0.1.CR4
Reporter: Ovidiu Feodorov
Assigned To: Ovidiu Feodorov
Fix For: 1.0.1.CR5
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:31 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-542) Closing connection inside MessageListener's onMessage() causes deadlock
[ http://jira.jboss.com/jira/browse/JBMESSAGING-542?page=all ]
Ovidiu Feodorov updated JBMESSAGING-542:
----------------------------------------
Priority: Critical (was: Major)
Closing connection inside MessageListener's onMessage() causes
deadlock
-----------------------------------------------------------------------
Key: JBMESSAGING-542
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-542
Project: JBoss Messaging
Issue Type: Bug
Components: JMS Facade
Affects Versions: 1.0.1.CR4
Reporter: Ovidiu Feodorov
Assigned To: Ovidiu Feodorov
Priority: Critical
Fix For: 1.0.1.CR5
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:55 p.m.
New subject: [JBoss JIRA] Closed: (JBMESSAGING-542) Closing connection inside MessageListener's onMessage() causes deadlock
[ http://jira.jboss.com/jira/browse/JBMESSAGING-542?page=all ]
Ovidiu Feodorov closed JBMESSAGING-542.
---------------------------------------
Resolution: Done
Fixed by modifying the SessionAspect to send to server accumulated AUTO and DUPS_OK
acknowledgments on closing, and then skip postDeliver() to avoid passing through a
"closed" ClosedInterceptor.
Closing connection inside MessageListener's onMessage() causes
deadlock
-----------------------------------------------------------------------
Key: JBMESSAGING-542
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-542
Project: JBoss Messaging
Issue Type: Bug
Components: JMS Facade
Affects Versions: 1.0.1.CR4
Reporter: Ovidiu Feodorov
Assigned To: Ovidiu Feodorov
Priority: Critical
Fix For: 1.0.1.CR5
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7245
days inactive
7254
days old
6 comments
1 participants
participants (1)
-
Ovidiu Feodorov (JIRA)