[JBoss JIRA] Created: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
2:38 p.m.
on Connection Factory components, jndi-name, rar-name, and connection-definition
ManagedPropertys should all be mandatory, in both templates and properties on existing
components
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBAS-6671
URL: https://jira.jboss.org/jira/browse/JBAS-6671
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
When creating or updating a ConnectionFactory component, when the jndi-name prop is not
specified, I get:
DEPLOYMENTS IN ERROR:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
when the rar-name prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null name
and when the connection-definition prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException:
ConnectionDefinition 'null' not found in rar 'null'
which tells me all three of these props are required, so prop.isMandatory() should return
true, but it currently returns false. It should return true for both CF templates and
existing CF components.
Not directly related to management, but all three of the above error messages could also
be significantly improved, e.g.:
The "jndi-name" property was not specified for connection factory
"FooBar" - this property is required.
The "rar-name" property was not specified for connection factory
"FooBar" - this property is required.
The "connection-definition" property was not specified for connection factory
"FooBar" - this property is required.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:06 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
[
https://jira.jboss.org/jira/browse/JBAS-6671?page=com.atlassian.jira.plug...
]
Charles Crouch updated JBAS-6671:
---------------------------------
Priority: Minor (was: Major)
Setting to minor, since now we know which are the required props, we can update our
metadata.
on Connection Factory components, jndi-name, rar-name, and
connection-definition ManagedPropertys should all be mandatory, in both templates and
properties on existing components
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBAS-6671
URL: https://jira.jboss.org/jira/browse/JBAS-6671
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
Priority: Minor
When creating or updating a ConnectionFactory component, when the jndi-name prop is not
specified, I get:
DEPLOYMENTS IN ERROR:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
when the rar-name prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null name
and when the connection-definition prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException:
ConnectionDefinition 'null' not found in rar 'null'
which tells me all three of these props are required, so prop.isMandatory() should return
true, but it currently returns false. It should return true for both CF templates and
existing CF components.
Not directly related to management, but all three of the above error messages could also
be significantly improved, e.g.:
The "jndi-name" property was not specified for connection factory
"FooBar" - this property is required.
The "rar-name" property was not specified for connection factory
"FooBar" - this property is required.
The "connection-definition" property was not specified for connection factory
"FooBar" - this property is required.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
[
https://jira.jboss.org/jira/browse/JBAS-6671?page=com.atlassian.jira.plug...
]
Ian Springer commented on JBAS-6671:
------------------------------------
Also, there are a bunch of other properties which are marked as mandatory in the CF
templates that are not really required:
* name=background-validation, mappedName=null, viewUse=NONE, required=true, value=
SimpleMetaType:java.lang.Boolean:false
* name=blocking-timeout-millis, mappedName=null, viewUse=NONE, required=true, value=
SimpleMetaType:java.lang.Long:30000
* name=idle-timeout-minutes, mappedName=null, viewUse=NONE, required=true, value=
SimpleMetaType:java.lang.Integer:30
* name=isSameRM-override-value, mappedName=null, viewUse=NONE, required=true,
type=SimpleMetaType, value= <<<null>>>
* name=jmx-invoker-name, mappedName=null, viewUse=NONE, required=true,
type=SimpleMetaType, value= <<<null>>>
* name=local-transaction, mappedName=null, viewUse=NONE, required=true,
type=SimpleMetaType, value= <<<null>>>
* name=max-pool-size, mappedName=null, viewUse=NONE, required=true, value=
SimpleMetaType:java.lang.Integer:10
* name=min-pool-size, mappedName=null, viewUse=NONE, required=true, value=
SimpleMetaType:java.lang.Integer:0
* name=no-tx-separate-pools, mappedName=null, viewUse=NONE, required=true,
type=SimpleMetaType, value= <<<null>>>
* name=prefill, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType, value=
<<<null>>>
* name=statistics-formatter, mappedName=null, viewUse=NONE, required=true,
type=SimpleMetaType, value= <<<null>>>
* name=type-mapping, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType,
value= <<<null>>>
* name=use-java-context, mappedName=null, viewUse=NONE, required=true, value=
SimpleMetaType:java.lang.Boolean:true
* name=use-strict-min, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType,
value= <<<null>>>
* name=validate-on-match, mappedName=null, viewUse=NONE, required=true, value=
SimpleMetaType:java.lang.Boolean:true
* name=xa-resource-timeout, mappedName=null, viewUse=NONE, required=true, value=
SimpleMetaType:java.lang.Integer:0
* name=xa-transaction, mappedName=null, viewUse=NONE, required=true, type=SimpleMetaType,
value= <<<null>>>
These properties are not required in the ds.xml file and so should not be marked as
mandatory in the ManagedComponent's metadata either.
I verified that I'm able to create a new CF via applyTemplate() even when all of the
above properties are null or have null values, which further suggests they are optional.
on Connection Factory components, jndi-name, rar-name, and
connection-definition ManagedPropertys should all be mandatory, in both templates and
properties on existing components
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBAS-6671
URL: https://jira.jboss.org/jira/browse/JBAS-6671
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Scott M Stark
Priority: Minor
When creating or updating a ConnectionFactory component, when the jndi-name prop is not
specified, I get:
DEPLOYMENTS IN ERROR:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
when the rar-name prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null name
and when the connection-definition prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException:
ConnectionDefinition 'null' not found in rar 'null'
which tells me all three of these props are required, so prop.isMandatory() should return
true, but it currently returns false. It should return true for both CF templates and
existing CF components.
Not directly related to management, but all three of the above error messages could also
be significantly improved, e.g.:
The "jndi-name" property was not specified for connection factory
"FooBar" - this property is required.
The "rar-name" property was not specified for connection factory
"FooBar" - this property is required.
The "connection-definition" property was not specified for connection factory
"FooBar" - this property is required.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:37 a.m.
New subject: [JBoss JIRA] Assigned: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
[
https://jira.jboss.org/jira/browse/JBAS-6671?page=com.atlassian.jira.plug...
]
Emanuel Muckenhuber reassigned JBAS-6671:
-----------------------------------------
Assignee: Emanuel Muckenhuber (was: Scott M Stark)
on Connection Factory components, jndi-name, rar-name, and
connection-definition ManagedPropertys should all be mandatory, in both templates and
properties on existing components
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBAS-6671
URL: https://jira.jboss.org/jira/browse/JBAS-6671
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Emanuel Muckenhuber
Priority: Minor
When creating or updating a ConnectionFactory component, when the jndi-name prop is not
specified, I get:
DEPLOYMENTS IN ERROR:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
when the rar-name prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null name
and when the connection-definition prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException:
ConnectionDefinition 'null' not found in rar 'null'
which tells me all three of these props are required, so prop.isMandatory() should return
true, but it currently returns false. It should return true for both CF templates and
existing CF components.
Not directly related to management, but all three of the above error messages could also
be significantly improved, e.g.:
The "jndi-name" property was not specified for connection factory
"FooBar" - this property is required.
The "rar-name" property was not specified for connection factory
"FooBar" - this property is required.
The "connection-definition" property was not specified for connection factory
"FooBar" - this property is required.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:50 a.m.
New subject: [JBoss JIRA] Assigned: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
[
https://jira.jboss.org/jira/browse/JBAS-6671?page=com.atlassian.jira.plug...
]
Emanuel Muckenhuber reassigned JBAS-6671:
-----------------------------------------
Assignee: Jesper Pedersen (was: Emanuel Muckenhuber)
Jesper can you review and validate that the ManagedProperties on the mcf metadata are
correct? especially the attribtues 'mandatory=true' and
'includeInTemplate=true'.
Maybe also the default values specified in the DsDataSourceTemplateInfo.
Once you think this is done you can also close the related JIRA task. Thanks!
on Connection Factory components, jndi-name, rar-name, and
connection-definition ManagedPropertys should all be mandatory, in both templates and
properties on existing components
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBAS-6671
URL: https://jira.jboss.org/jira/browse/JBAS-6671
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Jesper Pedersen
Priority: Minor
When creating or updating a ConnectionFactory component, when the jndi-name prop is not
specified, I get:
DEPLOYMENTS IN ERROR:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
when the rar-name prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null name
and when the connection-definition prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException:
ConnectionDefinition 'null' not found in rar 'null'
which tells me all three of these props are required, so prop.isMandatory() should return
true, but it currently returns false. It should return true for both CF templates and
existing CF components.
Not directly related to management, but all three of the above error messages could also
be significantly improved, e.g.:
The "jndi-name" property was not specified for connection factory
"FooBar" - this property is required.
The "rar-name" property was not specified for connection factory
"FooBar" - this property is required.
The "connection-definition" property was not specified for connection factory
"FooBar" - this property is required.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:15 p.m.
New subject: [JBoss JIRA] Updated: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
[
https://jira.jboss.org/jira/browse/JBAS-6671?page=com.atlassian.jira.plug...
]
Charles Crouch updated JBAS-6671:
---------------------------------
Priority: Optional (was: Minor)
on Connection Factory components, jndi-name, rar-name, and
connection-definition ManagedPropertys should all be mandatory, in both templates and
properties on existing components
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBAS-6671
URL: https://jira.jboss.org/jira/browse/JBAS-6671
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Jesper Pedersen
Priority: Optional
When creating or updating a ConnectionFactory component, when the jndi-name prop is not
specified, I get:
DEPLOYMENTS IN ERROR:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
when the rar-name prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null name
and when the connection-definition prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException:
ConnectionDefinition 'null' not found in rar 'null'
which tells me all three of these props are required, so prop.isMandatory() should return
true, but it currently returns false. It should return true for both CF templates and
existing CF components.
Not directly related to management, but all three of the above error messages could also
be significantly improved, e.g.:
The "jndi-name" property was not specified for connection factory
"FooBar" - this property is required.
The "rar-name" property was not specified for connection factory
"FooBar" - this property is required.
The "connection-definition" property was not specified for connection factory
"FooBar" - this property is required.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:57 p.m.
New subject: [JBoss JIRA] Resolved: (JBAS-6671) on Connection Factory components, jndi-name, rar-name, and connection-definition ManagedPropertys should all be mandatory, in both templates and properties on existing components
[
https://jira.jboss.org/jira/browse/JBAS-6671?page=com.atlassian.jira.plug...
]
Jesper Pedersen resolved JBAS-6671.
-----------------------------------
Fix Version/s: JBossAS-5.1.0.CR1
Resolution: Done
on Connection Factory components, jndi-name, rar-name, and
connection-definition ManagedPropertys should all be mandatory, in both templates and
properties on existing components
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: JBAS-6671
URL: https://jira.jboss.org/jira/browse/JBAS-6671
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: ProfileService
Reporter: Ian Springer
Assignee: Jesper Pedersen
Priority: Optional
Fix For: JBossAS-5.1.0.CR1
When creating or updating a ConnectionFactory component, when the jndi-name prop is not
specified, I get:
DEPLOYMENTS IN ERROR:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/notx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null text
when the rar-name prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): java.lang.IllegalArgumentException: Null name
and when the connection-definition prop is not specified, I get:
Deployment
"vfsfile:/C:/opt/jboss-5.1.0.CR1-SNAPSHOT/server/default/deploy/xxx-ds.xml" is
in error due to the following reason(s): org.jboss.deployers.spi.DeploymentException:
ConnectionDefinition 'null' not found in rar 'null'
which tells me all three of these props are required, so prop.isMandatory() should return
true, but it currently returns false. It should return true for both CF templates and
existing CF components.
Not directly related to management, but all three of the above error messages could also
be significantly improved, e.g.:
The "jndi-name" property was not specified for connection factory
"FooBar" - this property is required.
The "rar-name" property was not specified for connection factory
"FooBar" - this property is required.
The "connection-definition" property was not specified for connection factory
"FooBar" - this property is required.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5528
days inactive
5536
days old
6 comments
4 participants
participants (4)
-
Charles Crouch (JIRA) -
Emanuel Muckenhuber (JIRA)
-
Ian Springer (JIRA)
-
Jesper Pedersen (JIRA)