7:50 p.m.
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Ovidiu Feodorov
Fix For: 1.2.0.SP1
When I removeAllMessages from the Queue while the thing is working on the queue, I can get
a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:52 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=all ]
Kurt Stam updated JBMESSAGING-926:
----------------------------------
Attachment: screenshot-1.jpg
negative message count, cute :)
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Ovidiu Feodorov
Fix For: 1.2.0.SP1
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:05 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=comments#action_12... ]
Clebert Suconic commented on JBMESSAGING-926:
---------------------------------------------
Can you define "while the thing is working on the queue"?
What you mean.. you're sending several messages to the queue, then you called
removeAllMessages?
Can you describe how you found the bug a little bit more? (Some info to create a
testcase... or a testcase itself would be even better)
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Ovidiu Feodorov
Fix For: 1.2.0.SP1
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:05 a.m.
New subject: [JBoss JIRA] Assigned: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=all ]
Clebert Suconic reassigned JBMESSAGING-926:
-------------------------------------------
Assignee: Clebert Suconic (was: Ovidiu Feodorov)
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Clebert Suconic
Fix For: 1.2.0.SP1
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:09 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=comments#action_12... ]
Kurt Stam commented on JBMESSAGING-926:
---------------------------------------
1. Fill up the Queue with some large amount of msgs (5000)
2. Have a listener process let's say 1000 msgs/min
3. While this listener is processing, go to the JMX console and hit
"RemoveAllMessages.
4. You will end up woth a message count that is negative.
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Clebert Suconic
Fix For: 1.2.0.SP1
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:17 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=all ]
Clebert Suconic updated JBMESSAGING-926:
----------------------------------------
Fix Version/s: 1.2.0.SP2
(was: 1.2.0.SP1)
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Clebert Suconic
Fix For: 1.2.0.SP2
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:49 p.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=all ]
Tim Fox updated JBMESSAGING-926:
--------------------------------
Assignee: Sergey Koshcheyev (was: Clebert Suconic)
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Sergey Koshcheyev
Fix For: 1.2.0.SP2
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:41 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=comments#action_12... ]
Sergey Koshcheyev commented on JBMESSAGING-926:
-----------------------------------------------
I now have a test case reproducing this bug, but I have no idea how to fix it.
The problem is apparently that if removeAllMessages is called while a session is in
progress, the message count is set to 0 but messages buffered in MessageCallbackHandler
are not cleared and can be received later in the session, so you can in fact receive a
message after all messages have been removed. Receiving such a message causes the queue
message count to go negative.
So, would the solution be to flush the MessageCallbackHandler buffer when
removeAllMessages called? Is this at all possible? From the code it looks like the queue
would have to message all its consumers when all messages are removed so that the
consumers clear their buffers. Is there some other alternative?
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Sergey Koshcheyev
Fix For: 1.2.0.SP2
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:35 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=comments#action_12... ]
Tim Fox commented on JBMESSAGING-926:
-------------------------------------
I don't think it makes sense to allow removeAllMessages when there are stil messages
being delivered.
I suggest that this method should throw an exception if thrown when deliveringCount >
0
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Sergey Koshcheyev
Fix For: 1.2.0.SP2
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=comments#action_12... ]
Tim Fox commented on JBMESSAGING-926:
-------------------------------------
In my previous comment I meant "I suggest that this method should throw an exception
if executed when deliveringCount > 0"
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Sergey Koshcheyev
Fix For: 1.2.0.SP2
Attachments: screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:57 a.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=all ]
Sergey Koshcheyev updated JBMESSAGING-926:
------------------------------------------
Attachment: ChannelSupport.patch
I'm attaching a proposed fix. This breaks QueueManagementTest.testRemoveAllMessages
though - during that test the message count goes to -1. The counter is decremented while
removing the messages but the counter has never been incremented before.
These are the lines in testRemoveAllMessages where the failure occurs:
// Test MessageCount again, should be 0 msg
Integer count = (Integer)ServerManagement.getAttribute(destObjectName,
"MessageCount");
assertEquals(0, count.intValue());
count.intValue() returns -1 here.
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Sergey Koshcheyev
Fix For: 1.2.0.SP2
Attachments: ChannelSupport.patch, screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:30 a.m.
New subject: [JBoss JIRA] Updated: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=all ]
Sergey Koshcheyev updated JBMESSAGING-926:
------------------------------------------
Attachment: NegativeMessageCount.patch
I'm attaching a new version of the patch (NegativeMessageCount.patch), this time all
tests in QueueManagementTest pass. Please review it.
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Sergey Koshcheyev
Fix For: 1.2.0.SP2
Attachments: ChannelSupport.patch, NegativeMessageCount.patch, screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:48 a.m.
New subject: [JBoss JIRA] Commented: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=comments#action_12... ]
Tim Fox commented on JBMESSAGING-926:
-------------------------------------
The patch looks good.
BTW - Sergey - you have commit rights so need to attach patches - just discuss the change
and if it is ok, commit it.
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Sergey Koshcheyev
Fix For: 1.2.0.SP2
Attachments: ChannelSupport.patch, NegativeMessageCount.patch, screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:28 a.m.
New subject: [JBoss JIRA] Closed: (JBMESSAGING-926) Negative message count
[ http://jira.jboss.com/jira/browse/JBMESSAGING-926?page=all ]
Sergey Koshcheyev closed JBMESSAGING-926.
-----------------------------------------
Resolution: Done
Committed.
Negative message count
----------------------
Key: JBMESSAGING-926
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-926
Project: JBoss Messaging
Issue Type: Bug
Affects Versions: 1.2.0.GA
Environment: any
Reporter: Kurt Stam
Assigned To: Sergey Koshcheyev
Fix For: 1.2.0.SP2
Attachments: ChannelSupport.patch, NegativeMessageCount.patch, screenshot-1.jpg
When I removeAllMessages from the Queue while the thing is working on the queue, I can
get a negative message count (see screenshot) I thought this was a funny bug :).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7023
days inactive
7060
days old
13 comments
4 participants
participants (4)
-
Clebert Suconic (JIRA) -
Kurt Stam (JIRA)
-
Sergey Koshcheyev (JIRA)
-
Tim Fox (JIRA)