[
https://issues.jboss.org/browse/WFLY-4850?page=com.atlassian.jira.plugin....
]
Ondřej Chaloupka commented on WFLY-4850:
----------------------------------------
I see. Then what to add to catch block the AssertionError (as ActiveOperationSupport
behaves in such way)
The place where I catch this is extended clustering test {{ClusterPassivationTestCase}}.
Running like
{code}
./integration-tests.sh clean install -Dts.noSmoke -Dts.clust -Dintegration.module
-DextendedTests -Dtest=ClusterPassivationTestCase
{code}
Nevertheless in any test in testsuite where server is managed manually, where the check
for {{isServerInRunningState}} is used and server is stopped at that time will occur that
assertion exception instead of {{false}} is returned.
ManagementClient.isServerInRunningState fails when server is stopped
--------------------------------------------------------------------
Key: WFLY-4850
URL:
https://issues.jboss.org/browse/WFLY-4850
Project: WildFly
Issue Type: Bug
Components: Test Suite
Reporter: Ondřej Chaloupka
Assignee: Tomaz Cerar
Scenario: server is stopped (killed), working with arquillian to check if server is
started or not
Current implementation of the {{ManagementClient.isServerInRunningState}} catches only
{{IOException}} (see [1]) and in such case false is returned. Otherwise exception is
propagated upwards.
That's a problem in case that assertions are enabled - which is true statement for
wildfly testsuite (see pom.xml, surefire configuration and
{{<enableAssertions>true</enableAssertions>}}). As state of the server is
checked with assertions as well [2] then test fails on such assertion instead of getting
false as server is stopped.
In comparision with arquillian client for jboss-eap there is caught {{Throwable}} and
returned false [3] which seems to me more correct.
Could you, please, forwardport arquillian client behaviour from JBoss EAP to WildFly?
[1]
https://github.com/wildfly/wildfly-arquillian/blob/master/common/src/main...
[2]
https://github.com/wildfly/wildfly-core/blob/master/protocol/src/main/jav...
[3]
https://github.com/jbossas/jboss-eap/blob/6.x/arquillian/common/src/main/...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)