[JBoss JIRA] (AS7-5108) Unused Command Line -D parameters should error out and stop boot of JBoss AS
11:52 a.m.
Jim Tyrrell created AS7-5108:
--------------------------------
Summary: Unused Command Line -D parameters should error out and stop boot of
JBoss AS
Key: AS7-5108
URL: https://issues.jboss.org/browse/AS7-5108
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Environment: All
Reporter: Jim Tyrrell
Assignee: Brian Stansberry
When running the clustering lab at JBW hosted by Rich Rapoosa, I mistakeningly typed in
the wrong command line parameters. We were supposed to use dots and with tired eyes I
misread the screen and used dashes. The error message that came up made very little
sense. It would be great to stop the server booting with any unused/injected parameter
that was passed in at the command line. My example command was this, but it should work
for any unused passed in parameter. ./domain.sh --host-config=host-slave.xml
-Djboss.domain.base.dir=/home/jimtyrrell/Servers/machine3/
-Djboss.domain-master-address=127.0.0.1
The error message was this:
[Host Controller] 09:48:27,318 ERROR [org.jboss.as.controller.management-operation]
(Controller Boot Thread) JBAS014613: Operation
("write-remote-domain-controller") failed - address: ([("host" =>
"hostjim2")]) - failure description: "JBAS014802: Cannot resolve expression
'expression \"${jboss.domain.master.address}\"' --
java.lang.IllegalStateException: Failed to resolve expression:
${jboss.domain.master.address}"
[Host Controller] 09:48:27,320 FATAL [org.jboss.as.host.controller] (Controller Boot
Thread) JBAS010933: Host Controller boot has failed in an unrecoverable manner; exiting.
See previous messages for details.
I agree it is mostly right there, however, it took three of us looking at the command line
before we noticed the dashes instead of the dots. Any other unused parameters should
generate a very clear error message that is as close as possible to the starting of the
instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:10 p.m.
[
https://issues.jboss.org/browse/AS7-5108?page=com.atlassian.jira.plugin.s...
]
Jim Tyrrell updated AS7-5108:
-----------------------------
Affects Version/s: 7.1.2.Final (EAP)
Unused Command Line -D parameters should error out and stop boot of
JBoss AS
----------------------------------------------------------------------------
Key: AS7-5108
URL: https://issues.jboss.org/browse/AS7-5108
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Environment: All
Reporter: Jim Tyrrell
Assignee: Brian Stansberry
Labels: eap6-ux
When running the clustering lab at JBW hosted by Rich Rapoosa, I mistakeningly typed in
the wrong command line parameters. We were supposed to use dots and with tired eyes I
misread the screen and used dashes. The error message that came up made very little
sense. It would be great to stop the server booting with any unused/injected parameter
that was passed in at the command line. My example command was this, but it should work
for any unused passed in parameter. ./domain.sh --host-config=host-slave.xml
-Djboss.domain.base.dir=/home/jimtyrrell/Servers/machine3/
-Djboss.domain-master-address=127.0.0.1
The error message was this:
[Host Controller] 09:48:27,318 ERROR [org.jboss.as.controller.management-operation]
(Controller Boot Thread) JBAS014613: Operation
("write-remote-domain-controller") failed - address: ([("host" =>
"hostjim2")]) - failure description: "JBAS014802: Cannot resolve expression
'expression \"${jboss.domain.master.address}\"' --
java.lang.IllegalStateException: Failed to resolve expression:
${jboss.domain.master.address}"
[Host Controller] 09:48:27,320 FATAL [org.jboss.as.host.controller] (Controller Boot
Thread) JBAS010933: Host Controller boot has failed in an unrecoverable manner; exiting.
See previous messages for details.
I agree it is mostly right there, however, it took three of us looking at the command
line before we noticed the dashes instead of the dots. Any other unused parameters should
generate a very clear error message that is as close as possible to the starting of the
instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:53 a.m.
[
https://issues.jboss.org/browse/AS7-5108?page=com.atlassian.jira.plugin.s...
]
Darran Lofthouse commented on AS7-5108:
---------------------------------------
Out of interest how would you suggest we identify all support -D parameters? On the basis
that these are just set as system properties not only would we need the list of properties
supported by the core of AS we would also need to identify every property defined to be
resolved within the configuration, many of these could be user defined - we would also
need to identify any properties set in deployment descriptors which would probably be all
user defined and then we would need to identify every call to System.getProperty in every
single module and in every deployment - some of these items not being available until late
in the deployment process.
Even if we did that there is always the case that the user wants to set a property that
may be used by a future deployment which is not present at boot time.
Unused Command Line -D parameters should error out and stop boot of
JBoss AS
----------------------------------------------------------------------------
Key: AS7-5108
URL: https://issues.jboss.org/browse/AS7-5108
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Environment: All
Reporter: Jim Tyrrell
Assignee: Brian Stansberry
Labels: eap6-ux
When running the clustering lab at JBW hosted by Rich Rapoosa, I mistakeningly typed in
the wrong command line parameters. We were supposed to use dots and with tired eyes I
misread the screen and used dashes. The error message that came up made very little
sense. It would be great to stop the server booting with any unused/injected parameter
that was passed in at the command line. My example command was this, but it should work
for any unused passed in parameter. ./domain.sh --host-config=host-slave.xml
-Djboss.domain.base.dir=/home/jimtyrrell/Servers/machine3/
-Djboss.domain-master-address=127.0.0.1
The error message was this:
[Host Controller] 09:48:27,318 ERROR [org.jboss.as.controller.management-operation]
(Controller Boot Thread) JBAS014613: Operation
("write-remote-domain-controller") failed - address: ([("host" =>
"hostjim2")]) - failure description: "JBAS014802: Cannot resolve expression
'expression \"${jboss.domain.master.address}\"' --
java.lang.IllegalStateException: Failed to resolve expression:
${jboss.domain.master.address}"
[Host Controller] 09:48:27,320 FATAL [org.jboss.as.host.controller] (Controller Boot
Thread) JBAS010933: Host Controller boot has failed in an unrecoverable manner; exiting.
See previous messages for details.
I agree it is mostly right there, however, it took three of us looking at the command
line before we noticed the dashes instead of the dots. Any other unused parameters should
generate a very clear error message that is as close as possible to the starting of the
instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 a.m.
[
https://issues.jboss.org/browse/AS7-5108?page=com.atlassian.jira.plugin.s...
]
Jim Tyrrell commented on AS7-5108:
----------------------------------
When the object/String that represents the passed in flag is used/injected, can't we
increment a counter on that object, and increment it on every use, and then at the end of
booting make sure every object at least has a count of 1 or greater. If not then we error
out or at least output an error before continuing to boot.
That would take care of any random new parameters, our's and any other use case. It
would enable people to easily see the custom parameter they thought they were
using/injecting is in fact not working as they expected.
Of course if they are passing a parameter to their application, then this would generate
an error at boot time, hmmm.
Thoughts?
Unused Command Line -D parameters should error out and stop boot of
JBoss AS
----------------------------------------------------------------------------
Key: AS7-5108
URL: https://issues.jboss.org/browse/AS7-5108
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Environment: All
Reporter: Jim Tyrrell
Assignee: Brian Stansberry
Labels: eap6-ux
When running the clustering lab at JBW hosted by Rich Rapoosa, I mistakeningly typed in
the wrong command line parameters. We were supposed to use dots and with tired eyes I
misread the screen and used dashes. The error message that came up made very little
sense. It would be great to stop the server booting with any unused/injected parameter
that was passed in at the command line. My example command was this, but it should work
for any unused passed in parameter. ./domain.sh --host-config=host-slave.xml
-Djboss.domain.base.dir=/home/jimtyrrell/Servers/machine3/
-Djboss.domain-master-address=127.0.0.1
The error message was this:
[Host Controller] 09:48:27,318 ERROR [org.jboss.as.controller.management-operation]
(Controller Boot Thread) JBAS014613: Operation
("write-remote-domain-controller") failed - address: ([("host" =>
"hostjim2")]) - failure description: "JBAS014802: Cannot resolve expression
'expression \"${jboss.domain.master.address}\"' --
java.lang.IllegalStateException: Failed to resolve expression:
${jboss.domain.master.address}"
[Host Controller] 09:48:27,320 FATAL [org.jboss.as.host.controller] (Controller Boot
Thread) JBAS010933: Host Controller boot has failed in an unrecoverable manner; exiting.
See previous messages for details.
I agree it is mostly right there, however, it took three of us looking at the command
line before we noticed the dashes instead of the dots. Any other unused parameters should
generate a very clear error message that is as close as possible to the starting of the
instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:03 p.m.
[
https://issues.jboss.org/browse/AS7-5108?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-5108:
---------------------------------------
As you saw, we could only track usage properties that are consumed as part of management
processing. Any property that's consumed by something else in the VM (including the
JRE itself), we'd have no idea.
So, the issue is how to distinguish properties where we can be helpful from those where we
can't. A different startup switch (e.g. -Mjboss.foo instead of -Djboss.foo) is a
possibility, but it quickly gets complex as we start talking about the .conf files, the -P
option etc.
Unused Command Line -D parameters should error out and stop boot of
JBoss AS
----------------------------------------------------------------------------
Key: AS7-5108
URL: https://issues.jboss.org/browse/AS7-5108
Project: Application Server 7
Issue Type: Feature Request
Components: Domain Management
Affects Versions: 7.1.2.Final (EAP)
Environment: All
Reporter: Jim Tyrrell
Assignee: Brian Stansberry
Labels: eap6-ux
When running the clustering lab at JBW hosted by Rich Rapoosa, I mistakeningly typed in
the wrong command line parameters. We were supposed to use dots and with tired eyes I
misread the screen and used dashes. The error message that came up made very little
sense. It would be great to stop the server booting with any unused/injected parameter
that was passed in at the command line. My example command was this, but it should work
for any unused passed in parameter. ./domain.sh --host-config=host-slave.xml
-Djboss.domain.base.dir=/home/jimtyrrell/Servers/machine3/
-Djboss.domain-master-address=127.0.0.1
The error message was this:
[Host Controller] 09:48:27,318 ERROR [org.jboss.as.controller.management-operation]
(Controller Boot Thread) JBAS014613: Operation
("write-remote-domain-controller") failed - address: ([("host" =>
"hostjim2")]) - failure description: "JBAS014802: Cannot resolve expression
'expression \"${jboss.domain.master.address}\"' --
java.lang.IllegalStateException: Failed to resolve expression:
${jboss.domain.master.address}"
[Host Controller] 09:48:27,320 FATAL [org.jboss.as.host.controller] (Controller Boot
Thread) JBAS010933: Host Controller boot has failed in an unrecoverable manner; exiting.
See previous messages for details.
I agree it is mostly right there, however, it took three of us looking at the command
line before we noticed the dashes instead of the dots. Any other unused parameters should
generate a very clear error message that is as close as possible to the starting of the
instance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5046
days inactive
5048
days old
4 comments
3 participants
participants (3)
-
Brian Stansberry (JIRA) -
Darran Lofthouse (JIRA)
-
Jim Tyrrell (JIRA)