[ https://issues.jboss.org/browse/JBRULES-2849?page=com.atlassian.jira.plug... ] Geoffrey De Smet updated JBRULES-2849: -------------------------------------- Component/s: drools-compiler -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2849?page=com.atlassian.jira.plug... ] Geoffrey De Smet commented on JBRULES-2849: ------------------------------------------- Problem is in org.drools.lang.dsl.DefaultExpander#expandLHS -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2849?page=com.atlassian.jira.plug... ] Geoffrey De Smet edited comment on JBRULES-2849 at 12/24/10 8:31 AM: --------------------------------------------------------------------- Problem is in org.drools.lang.dsl.DefaultExpander#expandLHS (lines[i].equals( expanded[lastExpanded]) gives a different result in both JDK's. Looking deeper, it's in org.drools.lang.dsl.DefaultExpander#substitute on this line: while( startPos < exp.length() && m.find( startPos ) ){ The m.find() method acts differently was (Author: ge0ffrey): Problem is in org.drools.lang.dsl.DefaultExpander#expandLHS (lines[i].equals( expanded[lastExpanded]) gives a different result in both JDK's. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2849?page=com.atlassian.jira.plug... ] Geoffrey De Smet commented on JBRULES-2849: ------------------------------------------- I believe the usage of "?" in the regexes is wrong (which is causing the issue). For example: regex "(?<=\\W|^)-\\s*\\s+(.*?)\\s+is\\s+(.*?)$" The "?" means the character before me might or might not be there. so "ab?c" matches on "abc" and "ac" The "(" means start of a group. So "(?" should fail-fast (but it doesn't, just behave differently in jdk5 and jdk6). Also ".*?" should fail-fast: either you want ".*" (none or more) or ".+" (one ore more). -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBRULES-2849?page=com.atlassian.jira.plug... ] Wolfgang Laun commented on JBRULES-2849: ---------------------------------------- The regular expressions are correct and according to javadoc in java.util.regex.Pattern. This is a bug in JDK 5: it doesn't handle alternatives in zero-width lookbehind assertions. Original code in 5.1.1 was using a complicated technique (in hindsight I can now say: as a workaround). However, there is another, simple workaround: import java.util.regex.*; public class Sandbox { public static void main(String[] args) { System.out.println("java = " + System.getProperty("java.version")); String s1 = "a man"; String s2 = ":a man"; String s3 = "a man:"; String s4 = ":a man:"; String lb = "(?:(?<=^)|(?<=\\W))"; String la = "(?=$|\\W)"; // (?:(?=$)|(?=\\W)) Pattern p1 = Pattern.compile( lb + "a man" ); Pattern p2 = Pattern.compile( "a man" + la ); Pattern p3 = Pattern.compile( lb + "a man" + la ); for( Pattern p: new Pattern[]{ p1, p2, p3 } ){ for( String s: new String[]{ s1, s2, s3, s4 } ){ Matcher m = p.matcher( s ); System.out.println( "\"" + s + "\" =~ /" + p + "/ => " + m.find(0) ); } } } } $ $java Sandbox java = 1.5.0_22 "a man" =~ /(?:(?<=^)|(?<=\W))a man/ => true ":a man" =~ /(?:(?<=^)|(?<=\W))a man/ => true "a man:" =~ /(?:(?<=^)|(?<=\W))a man/ => true ":a man:" =~ /(?:(?<=^)|(?<=\W))a man/ => true "a man" =~ /a man(?=$|\W)/ => true ":a man" =~ /a man(?=$|\W)/ => true "a man:" =~ /a man(?=$|\W)/ => true ":a man:" =~ /a man(?=$|\W)/ => true "a man" =~ /(?:(?<=^)|(?<=\W))a man(?=$|\W)/ => true ":a man" =~ /(?:(?<=^)|(?<=\W))a man(?=$|\W)/ => true "a man:" =~ /(?:(?<=^)|(?<=\W))a man(?=$|\W)/ => true ":a man:" =~ /(?:(?<=^)|(?<=\W))a man(?=$|\W)/ => true -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira