[
https://jira.jboss.org/jira/browse/JGRP-878?page=com.atlassian.jira.plugi...
]
Bela Ban resolved JGRP-878.
---------------------------
Resolution: Done
Fixed by passing a ref rather than a copy to ClientConnectionHandler. Access to the list
is synchronized anyway, so we don't need to use a concurrent version of the list.
FD_SOCK: client connection handlers are not removed from list
-------------------------------------------------------------
Key: JGRP-878
URL:
https://jira.jboss.org/jira/browse/JGRP-878
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.6.8, 2.7
[Igor Postelnik]
I'm working on a system that uses JGroups 2.6.3 to maintain cache
coherency. The system has a mix of long-lived services and short-lived
jobs, both of which join the group. We have noticed OOM errors in our
long-lived services and profiler shows FD_SOCK is the culprit. The
elements of FD_SOCK.ServerSocketHandler.clients are never removed,
even when ClientConnectionHandler terminates. It looks like
ClientConnectionHandler should just hold a reference to the
ServerSocketHandler.clients so that call to remove in the finally
block of run() method modifies the original list. Instead,
ClientConnectionHandler makes a copy of the list and so the original
list held by ServerSocketHandler.is never updated.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira