[JBoss JIRA] Created: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
5:13 a.m.
Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of
jump or branch | goto points to invalid instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 a.m.
New subject: [JBoss JIRA] Updated: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
[
https://jira.jboss.org/jira/browse/JASSIST-79?page=com.atlassian.jira.plu...
]
Martin Burger updated JASSIST-79:
---------------------------------
Attachment: Parser.original.class
Parser.original.dump
Parser.original.java
Original (not instrumented) files:
Parser.original.class - class file as compiled by javac
Parser.original.dump - decompiled dump obtained by calling javap
Parser.original.java - original source file
Editing MethodCall produces incorrect byte code |
java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid
instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
Attachments: Parser.original.class, Parser.original.dump, Parser.original.java
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:33 a.m.
New subject: [JBoss JIRA] Commented: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
[
https://jira.jboss.org/jira/browse/JASSIST-79?page=com.atlassian.jira.plu...
]
Martin Burger commented on JASSIST-79:
--------------------------------------
Interesting part in Parser.original.dump (method statementHelper):
273: getfield #12; //Field nf:Lorg/mozilla/javascript/IRFactory;
276: aload 6
278: aload 7
280: aload 8
282: iload 5
284: invokevirtual #64; //Method
org/mozilla/javascript/IRFactory.createIf:(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;I)Ljava/lang/Object;
287: astore_2
288: goto 2234
Corresponding part in Parser.instrumented.dump:
3069: aload 13
3071: aload 14
3073: aload 15
3075: aload 16
3077: iload 17
3079: invokevirtual #6882; //Method
org/mozilla/javascript/IRFactory.createIf:(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;I)Ljava/lang/Object;
3082: astore 18
3084: goto 3168
...
3196: aload 18
3198: nop
3199: astore_2
3200: goto -29495
Jad could not decompile Parser.instrumented.class:
ERROR: invalid instruction at 3200 in the method statementHelper. The method will be
decompiled incorrectly.
1633 Bus error
Editing MethodCall produces incorrect byte code |
java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid
instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
Attachments: Parser.instrumented.class, Parser.instrumented.dump,
Parser.original.class, Parser.original.dump, Parser.original.jad, Parser.original.java
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:52 a.m.
New subject: [JBoss JIRA] Updated: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
[
https://jira.jboss.org/jira/browse/JASSIST-79?page=com.atlassian.jira.plu...
]
Martin Burger updated JASSIST-79:
---------------------------------
Attachment: jinsi-jassist-79.tgz
Java program that reproduces this failure. Contains README with further information.
Basically, unpack this archive and run test-driver.sh.
I tried to remove as much as possible in order to focus on the failure.
Editing MethodCall produces incorrect byte code |
java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid
instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
Attachments: jinsi-jassist-79.tgz, Parser.instrumented.class,
Parser.instrumented.dump, Parser.original.class, Parser.original.dump,
Parser.original.jad, Parser.original.java
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:54 a.m.
New subject: [JBoss JIRA] Commented: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
[
https://jira.jboss.org/jira/browse/JASSIST-79?page=com.atlassian.jira.plu...
]
Martin Burger commented on JASSIST-79:
--------------------------------------
I hope the attached file jinsi-jassist-79.tgz helps to reproduce this failure. If this is
okay, I will create similar archives for JASSIST-80 and JASSIST-82.
Editing MethodCall produces incorrect byte code |
java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid
instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
Attachments: jinsi-jassist-79.tgz, Parser.instrumented.class,
Parser.instrumented.dump, Parser.original.class, Parser.original.dump,
Parser.original.jad, Parser.original.java
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:11 a.m.
New subject: [JBoss JIRA] Commented: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
[
https://jira.jboss.org/jira/browse/JASSIST-79?page=com.atlassian.jira.plu...
]
Shigeru Chiba commented on JASSIST-79:
--------------------------------------
Thank you for posting jinsi-jassist-79.tgz. I got why the generated class file was
broken.
The bytecode GOTO takes only 16bit offset. Since your instrumented method was bigger than
64K, Javassist could not calculate a valid offset. To fix this problem, GOTO must be
replaced with GOTO_W. Modifying Javassist to do so is not a simple task, give me some
time.
Editing MethodCall produces incorrect byte code |
java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid
instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
Attachments: jinsi-jassist-79.tgz, Parser.instrumented.class,
Parser.instrumented.dump, Parser.original.class, Parser.original.dump,
Parser.original.jad, Parser.original.java
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:52 a.m.
New subject: [JBoss JIRA] Commented: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
[
https://jira.jboss.org/jira/browse/JASSIST-79?page=com.atlassian.jira.plu...
]
Shigeru Chiba commented on JASSIST-79:
--------------------------------------
I fixed this problem (it took long time :-0) and the fix is now in the CVS head. This fix
will be included in the upcoming release 3.11.
Editing MethodCall produces incorrect byte code |
java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid
instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
Attachments: jinsi-jassist-79.tgz, Parser.instrumented.class,
Parser.instrumented.dump, Parser.original.class, Parser.original.dump,
Parser.original.jad, Parser.original.java
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:56 a.m.
New subject: [JBoss JIRA] Resolved: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
[
https://jira.jboss.org/jira/browse/JASSIST-79?page=com.atlassian.jira.plu...
]
Shigeru Chiba resolved JASSIST-79.
----------------------------------
Resolution: Done
Fix Version/s: 3.11.0.GA
Editing MethodCall produces incorrect byte code |
java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid
instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
Fix For: 3.11.0.GA
Attachments: jinsi-jassist-79.tgz, Parser.instrumented.class,
Parser.instrumented.dump, Parser.original.class, Parser.original.dump,
Parser.original.jad, Parser.original.java
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:59 a.m.
New subject: [JBoss JIRA] Closed: (JASSIST-79) Editing MethodCall produces incorrect byte code | java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid instruction
[
https://jira.jboss.org/jira/browse/JASSIST-79?page=com.atlassian.jira.plu...
]
Shigeru Chiba closed JASSIST-79.
--------------------------------
Editing MethodCall produces incorrect byte code |
java.lang.VerifyError: Illegal target of jump or branch | goto points to invalid
instruction
----------------------------------------------------------------------------------------------------------------------------------------------
Key: JASSIST-79
URL: https://jira.jboss.org/jira/browse/JASSIST-79
Project: Javassist
Issue Type: Bug
Affects Versions: 3.10.0.GA
Environment: $ java -version
java version "1.6.0_07"
Java(TM) SE Runtime Environment (build 1.6.0_07-b06-153)
Java HotSpot(TM) 64-Bit Server VM (build 1.6.0_07-b06-57, mixed mode)
Reporter: Martin Burger
Assignee: Shigeru Chiba
Fix For: 3.11.0.GA
Attachments: jinsi-jassist-79.tgz, Parser.instrumented.class,
Parser.instrumented.dump, Parser.original.class, Parser.original.dump,
Parser.original.jad, Parser.original.java
I instrument method calls in a class called org.mozilla.javascript.Parser.
If I run (or, load) this class, a java.lang.VerifyError will be thrown:
Exception in thread "main" java.lang.VerifyError: (class:
org/mozilla/javascript/Parser, method: statementHelper signature:
(Lorg/mozilla/javascript/TokenStream;)Ljava/lang/Object;) Illegal target of jump or
branch
It seems Javassist introduces a defective goto statement at position 3200 in method
statementHelper:
3200: goto -29495
Obviously, offset -29495 is an invalid opcode address.
The corresponding Java code (excerpt):
switch(tt) {
case TokenStream.IF: {
skipsemi = true;
sourceAdd((char)ts.IF);
int lineno = ts.getLineno();
Object cond = condition(ts);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
Object ifTrue = statement(ts);
Object ifFalse = null;
if (ts.matchToken(ts.ELSE)) {
sourceAdd((char)ts.RC);
sourceAdd((char)ts.ELSE);
sourceAdd((char)ts.LC);
sourceAdd((char)ts.EOL);
ifFalse = statement(ts);
}
sourceAdd((char)ts.RC);
sourceAdd((char)ts.EOL);
pn = nf.createIf(cond, ifTrue, ifFalse, lineno);
break;
}
case TokenStream.SWITCH: {
I think the break statement is related to this defect.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5903
days inactive
6267
days old
8 comments
2 participants
participants (2)
-
Martin Burger (JIRA) -
Shigeru Chiba (JIRA)