[JBoss JIRA] Created: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
10:05 p.m.
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Cache loaders
Affects Versions: 1.4.0.SP1, 1.4.0, 1.3.0.SP3, 1.3.0.SP2, 1.3.0.SP1, 1.3.0, 1.2.4SP2,
1.2.4SP1, 1.2.4, 1.2.3
Reporter: Brian Stansberry
Assigned To: Manik Surtani
Priority: Minor
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:33 p.m.
New subject: [JBoss JIRA] Updated: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry updated JBCACHE-769:
-------------------------------------
Fix Version/s: 2.0.0
Assignee: Brian Stansberry (was: Manik Surtani)
JDBCCacheLoader is fixed; need to check the other cache loaders.
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 2.0.0
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:42 a.m.
New subject: [JBoss JIRA] Commented: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=comments#action_12343359 ]
Manik Surtani commented on JBCACHE-769:
---------------------------------------
Do we want to backport this for 1.4.x as well?
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 2.0.0
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:18 a.m.
New subject: [JBoss JIRA] Updated: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry updated JBCACHE-769:
-------------------------------------
Fix Version/s: 1.4.0.SP2
Yep.
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 2.0.0, 1.4.0.SP2
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:51 p.m.
New subject: [JBoss JIRA] Closed: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry closed JBCACHE-769.
------------------------------------
Resolution: Done
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 1.4.0.SP2, 2.0.0
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:13 p.m.
New subject: [JBoss JIRA] Reopened: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry reopened JBCACHE-769:
--------------------------------------
Reopening; forget to check BdbjeCacheLoader and JdbmCacheLoader.
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 2.0.0, 1.4.0.SP2
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:47 p.m.
New subject: [JBoss JIRA] Updated: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry updated JBCACHE-769:
-------------------------------------
Comment: was deleted
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 2.0.0, 1.4.0.SP2
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:47 p.m.
New subject: [JBoss JIRA] Updated: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry updated JBCACHE-769:
-------------------------------------
Comment: was deleted
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 2.0.0, 1.4.0.SP2
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:47 p.m.
New subject: [JBoss JIRA] Updated: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry updated JBCACHE-769:
-------------------------------------
Comment: was deleted
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 2.0.0, 1.4.0.SP2
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:47 p.m.
New subject: [JBoss JIRA] Updated: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry updated JBCACHE-769:
-------------------------------------
Comment: was deleted
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 2.0.0, 1.4.0.SP2
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:49 p.m.
New subject: [JBoss JIRA] Closed: (JBCACHE-769) JDBCCacheLoader should not directly serialize a map passed to put
[ http://jira.jboss.com/jira/browse/JBCACHE-769?page=all ]
Brian Stansberry closed JBCACHE-769.
------------------------------------
Resolution: Done
JDBCCacheLoader, AsyncCacheLoader, and BdbjeCacheLoader were fixed in both HEAD and
Branch_1_4_0. In HEAD the new AbstractCacheLoader was fixed as well. Other CacheLoader
impls were already OK.
JDBCCacheLoader should not directly serialize a map passed to put
-----------------------------------------------------------------
Key: JBCACHE-769
URL: http://jira.jboss.com/jira/browse/JBCACHE-769
Project: JBoss Cache
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: Cache loaders
Affects Versions: 1.2.3, 1.3.0, 1.2.4, 1.4.0, 1.2.4SP1, 1.2.4SP2, 1.3.0.SP1,
1.3.0.SP2, 1.3.0.SP3, 1.4.0.SP1
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Priority: Minor
Fix For: 1.4.0.SP2, 2.0.0
If a user calls TreeCache.put(Fqn, Map), the passed in Map gets passed to
JDBCCacheLoader.put() which then directly serializes it to the database. Then if a later
put(fqn, key, value) comes in and the cache loader needs to deserialize the node data, the
Map that was originally passed in gets deserialized and directly modified with the new
key/value.
Problem here is if the map originally passed in as an UnmodifiableMap, the update will
fail. Customer reported this happening. FileCacheLoader didn't have the problem, as
it makes a copy of the map before serializing.
Solution is to do what FileCacheLoader does and make a defensive copy of the map before
serializing.
The other cache loaders should be checked as well.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7241
days inactive
7244
days old
10 comments
2 participants
participants (2)
-
Brian Stansberry (JIRA) -
Manik Surtani (JIRA)