[JBoss JIRA] Created: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
4:11 p.m.
SuggestionCompletionEngine to be populated from rule object model classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Reporter: Michael Neale
Assigned To: Michael Neale
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:54 p.m.
New subject: [JBoss JIRA] Updated: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=all ]
Michael Neale updated JBRULES-629:
----------------------------------
Component/s: drools-brms
Fix Version/s: 3.1-m2
Description:
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Michael Neale
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:27 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=comments#action_12353340 ]
Michael Neale commented on JBRULES-629:
---------------------------------------
This will happen in the context of a package, so the imports can drive this, as well as
any deftemplates/globals.
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Michael Neale
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:50 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=all ]
Edson Tirelli reassigned JBRULES-629:
-------------------------------------
Assignee: Edson Tirelli (was: Michael Neale)
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Edson Tirelli
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:50 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=comments#action_12354855 ]
Edson Tirelli commented on JBRULES-629:
---------------------------------------
Michael, how "imports" are represented/stored in a package?
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Edson Tirelli
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:01 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=comments#action_12354856 ]
Edson Tirelli commented on JBRULES-629:
---------------------------------------
Michael,
Looking at the SuggestionCompletionEngine, it is a quite heavy object o populate. I
imagine if a package has a model with just a few tens of classes, it will take a long time
to inspect them, populate the map with all the attributes and transmit over the network,
reparsing it in the browser side before presenting it to the user.
Wouldn't be the case to do it on demand? Since each rule uses just a few facts, we
could possibly inspect and offer completion for the classes effectivelly in use by the
rule. What do you think?
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Edson Tirelli
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:23 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=comments#action_12354927 ]
Michael Neale commented on JBRULES-629:
---------------------------------------
Some answers:
* The package has a "header" attribute - which just will contain whatever goes
at the top of a package - imports and globals.
So perhaps the current parser can be used for this?
* As for the "heavyness" - it is needed - at least at the package level - as if
you are starting a rule from scratch, you need to have that info available on hand.
Some possibly ways of improving it:
1) "cache" a streamed out version of this (using xpath) into the package node -
when the package is changed, this gets updated, then it can be just read out and
supplied.
Also, the "front end" can (if needed) load and cache this for a whole package at
a time.
2) Break it down - so there simpler objects, FactDefinitions, and you load each fact
definiton on demand.
I am favouring 1 - as its simpler, but am prepared to discuss other options.
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Edson Tirelli
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:42 p.m.
New subject: [JBoss JIRA] Commented: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=comments#action_12354929 ]
Edson Tirelli commented on JBRULES-629:
---------------------------------------
Michael,
Lets talk about this in the IRC. I think it will be way too heavy to parse all this in the
browser side. I would really get a separate service for property code completion. So, when
the user adds Person to a rule and wants to add a field constraint, an assynchronous
request is made to the service to return only the properties of Person.
So, it is more like option 2 above.
Lets talk about it.
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Edson Tirelli
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:31 p.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=all ]
Edson Tirelli resolved JBRULES-629.
-----------------------------------
Resolution: Done
Michael, can you take a look on this one? In my tests, things were correctly populated,
even from different packages. All based on imports, no "automatic" discovery. I
think we may need to change that in the future.
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Edson Tirelli
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:47 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-629) SuggestionCompletionEngine to be populated from rule object model classes
[ http://jira.jboss.com/jira/browse/JBRULES-629?page=comments#action_12355586 ]
Michael Neale commented on JBRULES-629:
---------------------------------------
Looks ok - are there any unit tests covering this? SuggestionCompletionLoaderTest is
really just a basic one I threw together.
SuggestionCompletionEngine to be populated from rule object model
classes
--------------------------------------------------------------------------
Key: JBRULES-629
URL: http://jira.jboss.com/jira/browse/JBRULES-629
Project: JBoss Rules
Issue Type: Sub-task
Security Level: Public(Everyone can see)
Components: drools-brms
Reporter: Michael Neale
Assigned To: Edson Tirelli
Fix For: 3.1-m2
In drools-jbrms there is a call SuggestionCompletionEngine.
this class needs to be populated from a model. This model will come from the import
statements in a rule package, and also include deftemplates (if possible).
Basiaclly the model classes will need to be interrogated to work out fields, and similar
with templates, and a populated SuggestionCompletionEngine is the output (it will then
have any globals added to it).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7074
days inactive
7118
days old
9 comments
3 participants
participants (3)
-
Edson Tirelli (JIRA) -
Michael Neale (JIRA)
-
Michael Neale (JIRA)