[ http://jira.jboss.com/jira/browse/JBMESSAGING-554?page=comments#action_12... ] Richard Achmatowicz commented on JBMESSAGING-554: ------------------------------------------------- After discussion about the relative merits of providing generic JMS test cases which can run in the application server only (against JMX), versus JMS testcases which can run in more diverse configurations (against MC), decided to take the shorter approach of getting generic test cases running in AS first. I outlined the basic approach I wanted to take for this in: http://www.jboss.com/index.html?module=bb&op=viewtopic&t=91386 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBMESSAGING-554?page=comments#action_12... ] Richard Achmatowicz commented on JBMESSAGING-554: ------------------------------------------------- 1. I've now implented JBossMessagingAdmin class, which was essentially making a copy of Adrian's JBossMQAdmin class and adjusting the JMX calls to create destinations to use the Messaging ServerPeer class. Instead of including an instance of JBossTestServices to get access to JMX, I just picked up a copy of the MBeanServerConnection object from the JNDI nameserver. 2. I've also implemented the JMSTestCase class: /** * JMSTestCase. * A base test case for all JMS generic test cases. * * @author <a href=&quot;richard.achmatowicz(a)jboss.com&quot;&gt;Richard Achmatowicz</a> * @version $Revision: 38213 $ */ public class JMSTestCase extends JBossTestCase { private Logger log = Logger.getLogger(JMSTestCase.class); protected Admin admin; /** * Constructor for JMSTestCase object * @param name test case name */ public JMSTestCase(String name) throws Exception { super(name); } /** * Create the Admin object to perform all JMS adminsitrative functions * in a JMS provider-independent manner */ protected void setUp() { try { // get the Admin implementation for the current JMS provider // specified in provider.properties admin = AdminFactory.getAdmin() ; } catch (Exception e) { e.printStackTrace() ; } } public void createQueue(String name) { try { admin.createQueue(String name) ; } catch (Exception e) { e.printStackTrace() ; } } and so on. I'll start on refactoring my first test case tomorrow. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBMESSAGING-554?page=comments#action_12... ] Ovidiu Feodorov commented on JBMESSAGING-554: --------------------------------------------- Where are you currently checking in your changes? The 4.0 branch or the head? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBMESSAGING-554?page=comments#action_12... ] Richard Achmatowicz commented on JBMESSAGING-554: ------------------------------------------------- I'm checking in changes into head, aka https://svn.jboss.org/repos/jbossas/trunk. I committed some changes on Monday 16 Oct to execute a single test case against a messaging configuration. This was a JBQA task, so you probably won't have seen it: http://jira.jboss.com/jira/browse/JBQA-434 Richard -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBMESSAGING-554?page=comments#action_12... ] Richard Achmatowicz commented on JBMESSAGING-554: ------------------------------------------------- At present, the JBossMQ tests are initiated in various targets within the testsuite - for example, some of the basic tests are in the tests-standard-unit target, and others in the tests-standard-stress. There is no target for executing all JBossMQ tests as a group. This can be easily changed so that a separate JBossMQ target is defined and this will initiate the JMS tests for JBossMQ. The Messaging tests have already been set up as you describe, except that you don't need to create the Messaging configuration by hand - the target calls release-admin.xml on your behalf. How close am I to that way of executing the tests? Very close. I would just need to create a new target for JBossMQ. That's 10 minutes work, but i'd rather leave it until I finish getting the refactoring done, if you don't mind. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira