[ https://jira.jboss.org/jira/browse/JBDEPLOY-229?page=com.atlassian.jira.p... ] Ales Justin commented on JBDEPLOY-229: -------------------------------------- A simple *initial* solution could be to add a addDeployers(List<Deployer>) method and only do the sort once. WebServices adds like 29 deployers. I'm not saying this is bad, just that there's no reason the sort can't be done for those 29 deployers once and only once. Maybe even create a bean: DeploymentList and each subsystem (EJB, WebServicdes, etc.) could use that to deploy all their deployers. Then, after this simple thing is done, you can takle the harder problem of sorting. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDEPLOY-229?page=com.atlassian.jira.p... ] Bill Burke commented on JBDEPLOY-229: ------------------------------------- I've written a new sorter. It improves boot time of AppServer default/ profile by 15%. This is with trunk and Deployers 2.0.9.GA. I still have 2 tests failing: cycles, and one other. Although The other I think I can rewrite the test because the ordering is ok, just doesn't fully match that of the original test. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDEPLOY-229?page=com.atlassian.jira.p... ] Bill Burke updated JBDEPLOY-229: -------------------------------- Attachment: StagedSortedDeployers.java -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDEPLOY-229?page=com.atlassian.jira.p... ] Bill Burke updated JBDEPLOY-229: -------------------------------- Attachment: OldStagedSortedDeployers.java -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDEPLOY-229?page=com.atlassian.jira.p... ] Richard Opalka commented on JBDEPLOY-229: ----------------------------------------- I fixed the issue (also Carlo's Khan algorithm). Here are the measurement results. ----- iteration 1 ----- Exhaustive deployer sorting (TopologicalOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (TopologicalOrderingUnitTestCase) took: 149 milliseconds Exhaustive deployer sorting (KahnOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (KahnOrderingUnitTestCase) took: 214 milliseconds Exhaustive deployer sorting (DominoOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (DominoOrderingUnitTestCase) took: 6918 milliseconds Exhaustive deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 12000 milliseconds Deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 28 milliseconds ----- iteration 2 ----- Exhaustive deployer sorting (TopologicalOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (TopologicalOrderingUnitTestCase) took: 196 milliseconds Exhaustive deployer sorting (KahnOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (KahnOrderingUnitTestCase) took: 166 milliseconds Exhaustive deployer sorting (DominoOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (DominoOrderingUnitTestCase) took: 5895 milliseconds Exhaustive deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 11598 milliseconds Deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 46 milliseconds ----- iteration 3 ----- Exhaustive deployer sorting (TopologicalOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (TopologicalOrderingUnitTestCase) took: 345 milliseconds Exhaustive deployer sorting (KahnOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (KahnOrderingUnitTestCase) took: 310 milliseconds Exhaustive deployer sorting (DominoOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (DominoOrderingUnitTestCase) took: 5711 milliseconds Exhaustive deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 12167 milliseconds Deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 30 milliseconds ----- iteration 4 ----- Exhaustive deployer sorting (TopologicalOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (TopologicalOrderingUnitTestCase) took: 408 milliseconds Exhaustive deployer sorting (KahnOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (KahnOrderingUnitTestCase) took: 320 milliseconds Exhaustive deployer sorting (DominoOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (DominoOrderingUnitTestCase) took: 5517 milliseconds Exhaustive deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 12465 milliseconds Deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 55 milliseconds ----- iteration 5 ----- Exhaustive deployer sorting (TopologicalOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (TopologicalOrderingUnitTestCase) took: 174 milliseconds Exhaustive deployer sorting (KahnOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (KahnOrderingUnitTestCase) took: 196 milliseconds Exhaustive deployer sorting (DominoOrderingUnitTestCase) took: NOT MEASURED (too slow) Deployer sorting (DominoOrderingUnitTestCase) took: 6275 milliseconds Exhaustive deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 12442 milliseconds Deployer sorting (OptimizedTopologicalOrderingUnitTestCase) took: 33 milliseconds -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBDEPLOY-229?page=com.atlassian.jira.p... ] Ales Justin resolved JBDEPLOY-229. ---------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira