[JBoss JIRA] (AS7-6049) Where security services in domain management have a dedicated interface provide a ServiceName factory.
5:23 a.m.
Darran Lofthouse created AS7-6049:
-------------------------------------
Summary: Where security services in domain management have a dedicated
interface provide a ServiceName factory.
Key: AS7-6049
URL: https://issues.jboss.org/browse/AS7-6049
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Darran Lofthouse
Assignee: Darran Lofthouse
Fix For: 7.2.0.Alpha1
Update each of the interfaces with a factory for generating the service name.
{code}
public static class ServiceNameFactory {
public ServiceName createServiceName(final String realmName) {
return null;
}
}
{code}
Strictly speaking these are not currently expected to be used outside the AS codebase but
should they be used outside of the domain-management module this will be the recommended
way to generate the service names.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:01 a.m.
[
https://issues.jboss.org/browse/AS7-6049?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-6049:
---------------------------------------
More than that would be nice. The injection contract should be clear as well, a la this in
org.jboss.as.server.Services:
{code}
public static void addServerExecutorDependency(ServiceBuilder<?> builder,
Injector<ExecutorService> injector, boolean optional) {
ServiceBuilder.DependencyType type = optional ?
ServiceBuilder.DependencyType.OPTIONAL : ServiceBuilder.DependencyType.REQUIRED;
builder.addDependency(type, JBOSS_SERVER_EXECUTOR, ExecutorService.class,
injector);
}
{code}
In your case the "realmName" param would be required as well in order to
construct the ServiceName.
If this is nicely arranged, the external service integration contracts exposed by a module
can be very clear and anyone going beyond them is clearly on their own.
Where security services in domain management have a dedicated
interface provide a ServiceName factory.
------------------------------------------------------------------------------------------------------
Key: AS7-6049
URL: https://issues.jboss.org/browse/AS7-6049
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Darran Lofthouse
Assignee: Darran Lofthouse
Fix For: 7.2.0.Alpha1
Update each of the interfaces with a factory for generating the service name.
{code}
public static class ServiceNameFactory {
public ServiceName createServiceName(final String realmName) {
return null;
}
}
{code}
Strictly speaking these are not currently expected to be used outside the AS codebase but
should they be used outside of the domain-management module this will be the recommended
way to generate the service names.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:11 a.m.
[
https://issues.jboss.org/browse/AS7-6049?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry commented on AS7-6049:
---------------------------------------
That addServerExecutorDependency should actually return the result of
builder.addDependency(...) so the caller can use it in a chain.
Where security services in domain management have a dedicated
interface provide a ServiceName factory.
------------------------------------------------------------------------------------------------------
Key: AS7-6049
URL: https://issues.jboss.org/browse/AS7-6049
Project: Application Server 7
Issue Type: Task
Components: Domain Management
Reporter: Darran Lofthouse
Assignee: Darran Lofthouse
Fix For: 7.2.0.Alpha1
Update each of the interfaces with a factory for generating the service name.
{code}
public static class ServiceNameFactory {
public ServiceName createServiceName(final String realmName) {
return null;
}
}
{code}
Strictly speaking these are not currently expected to be used outside the AS codebase but
should they be used outside of the domain-management module this will be the recommended
way to generate the service names.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4165
days inactive
4165
days old
2 comments
2 participants
participants (2)
-
Brian Stansberry (JIRA) -
Darran Lofthouse (JIRA)