]
Scott Marlow updated WFLY-11991:
--------------------------------
Summary: Applications that extend certain Hibernate classes should be updated to use
type SharedSessionContractImplementor instead of SessionImplementor (was: Add Hibernate
ORM transformer option to transform any method parameter of type
org.hibernate.engine.spi.SessionImplementor)
Applications that extend certain Hibernate classes should be updated
to use type SharedSessionContractImplementor instead of SessionImplementor
-----------------------------------------------------------------------------------------------------------------------------------------------
Key: WFLY-11991
URL:
https://issues.jboss.org/browse/WFLY-11991
Project: WildFly
Issue Type: Bug
Components: JPA / Hibernate
Reporter: Scott Marlow
Assignee: Scott Marlow
Priority: Major
Fix For: 17.0.0.Final
Attachments: afterchange.zip, beforechange.zip
The idea is to transform any class method parameter of type
org.hibernate.engine.spi.SessionImplementor, in user application, to instead use type
org.hibernate.engine.spi.SharedSessionContractImplementor.
The test case (change) is for this enhancement is
[
https://github.com/simkam/wildfly/compare/hibernate_transformer].
The test case change is adding an internalNullSafeGet method that should also be
transformed to use the SharedSessionContractImplementor type but was not, which led to an
application failure with code:
{code}
public Object nullSafeGet(ResultSet rs, String[] names, SessionImplementor session,
Object owner) throws HibernateException, SQLException {
return internalNullSafeGet(rs, names, session, owner);
}
private Object internalNullSafeGet(ResultSet rs, String[] names, SessionImplementor
session, Object owner) throws HibernateException, SQLException {
internalSessionImplementorUsingMethod(session);
session.isTransactionInProgress();
int result = rs.getInt( names[0] );
if ( rs.wasNull() ) return null;
return State.values()[result];
}
}
{code}