7:54 p.m.
James Livingston created AS7-5718:
-------------------------------------
Summary: Client deserialising objects using wrong classloader
Key: AS7-5718
URL: https://issues.jboss.org/browse/AS7-5718
Project: Application Server 7
Issue Type: Bug
Components: Naming
Affects Versions: 7.1.3.Final (EAP)
Reporter: James Livingston
Assignee: Eduardo Martins
The commands in org.jboss.naming.remote.protocol.v1.Protocol deserialize objects using the
Unmarshaller from ReadUtil. That does not explicitly set a ClassResolver, so it defaults
to using the TCCL. Since the handle*Message methods are run in a thread pool, the TCCL
could be set to anything, so the commands need to ensure that the correct classloader
(presumably the one calling the Context methods) is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:42 p.m.
[
https://issues.jboss.org/browse/AS7-5718?page=com.atlassian.jira.plugin.s...
]
James Livingston reassigned AS7-5718:
-------------------------------------
Assignee: James Livingston (was: Eduardo Martins)
Client deserialising objects using wrong classloader
----------------------------------------------------
Key: AS7-5718
URL: https://issues.jboss.org/browse/AS7-5718
Project: Application Server 7
Issue Type: Bug
Components: Naming
Affects Versions: 7.1.3.Final (EAP)
Reporter: James Livingston
Assignee: James Livingston
The commands in org.jboss.naming.remote.protocol.v1.Protocol deserialize objects using
the Unmarshaller from ReadUtil. That does not explicitly set a ClassResolver, so it
defaults to using the TCCL. Since the handle*Message methods are run in a thread pool, the
TCCL could be set to anything, so the commands need to ensure that the correct classloader
(presumably the one calling the Context methods) is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:03 a.m.
[
https://issues.jboss.org/browse/AS7-5718?page=com.atlassian.jira.plugin.s...
]
James Livingston commented on AS7-5718:
---------------------------------------
To go with the remote-naming PR, there is a test for the AS testsuite in
https://github.com/doctau/jboss-as/tree/test-remotenaming-multiclient. I haven't
created a PR yet because it's going to fail builds until remote-naming is fixed.
Client deserialising objects using wrong classloader
----------------------------------------------------
Key: AS7-5718
URL: https://issues.jboss.org/browse/AS7-5718
Project: Application Server 7
Issue Type: Bug
Components: Naming
Affects Versions: 7.1.3.Final (EAP)
Reporter: James Livingston
Assignee: James Livingston
The commands in org.jboss.naming.remote.protocol.v1.Protocol deserialize objects using
the Unmarshaller from ReadUtil. That does not explicitly set a ClassResolver, so it
defaults to using the TCCL. Since the handle*Message methods are run in a thread pool, the
TCCL could be set to anything, so the commands need to ensure that the correct classloader
(presumably the one calling the Context methods) is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:14 a.m.
[
https://issues.jboss.org/browse/AS7-5718?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry updated AS7-5718:
----------------------------------
Fix Version/s: 7.2.0.Alpha1
Git Pull Request: https://github.com/jbossas/jboss-remote-naming/pull/10 (was:
https://github.com/jbossas/jboss-remote-naming/pull/10)
Since the remote-naming PR has been merged into that repo, I'm scheduling this for
7.2.0.Alpha1. A remote-naming upgrade will be needed.
Client deserialising objects using wrong classloader
----------------------------------------------------
Key: AS7-5718
URL: https://issues.jboss.org/browse/AS7-5718
Project: Application Server 7
Issue Type: Bug
Components: Naming
Affects Versions: 7.1.3.Final (EAP)
Reporter: James Livingston
Assignee: James Livingston
Fix For: 7.2.0.Alpha1
The commands in org.jboss.naming.remote.protocol.v1.Protocol deserialize objects using
the Unmarshaller from ReadUtil. That does not explicitly set a ClassResolver, so it
defaults to using the TCCL. Since the handle*Message methods are run in a thread pool, the
TCCL could be set to anything, so the commands need to ensure that the correct classloader
(presumably the one calling the Context methods) is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:53 p.m.
[
https://issues.jboss.org/browse/AS7-5718?page=com.atlassian.jira.plugin.s...
]
James Livingston reopened AS7-5718:
-----------------------------------
Did you want to add the integration test for this? It's at
https://github.com/jbossas/jboss-as/pull/3302 if you did, feel free to re-close the issue
if it's okay without it. I hadn't submitted the PR previously because it would
fail without the remote-naming fix.
Client deserialising objects using wrong classloader
----------------------------------------------------
Key: AS7-5718
URL: https://issues.jboss.org/browse/AS7-5718
Project: Application Server 7
Issue Type: Bug
Components: Naming
Affects Versions: 7.1.3.Final (EAP)
Reporter: James Livingston
Assignee: James Livingston
Fix For: 7.2.0.Alpha1, 7.1.4.Final (EAP)
The commands in org.jboss.naming.remote.protocol.v1.Protocol deserialize objects using
the Unmarshaller from ReadUtil. That does not explicitly set a ClassResolver, so it
defaults to using the TCCL. Since the handle*Message methods are run in a thread pool, the
TCCL could be set to anything, so the commands need to ensure that the correct classloader
(presumably the one calling the Context methods) is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:03 p.m.
[
https://issues.jboss.org/browse/AS7-5718?page=com.atlassian.jira.plugin.s...
]
Brian Stansberry resolved AS7-5718.
-----------------------------------
Resolution: Done
The test pull request was merged.
Thanks!
Client deserialising objects using wrong classloader
----------------------------------------------------
Key: AS7-5718
URL: https://issues.jboss.org/browse/AS7-5718
Project: Application Server 7
Issue Type: Bug
Components: Naming
Affects Versions: 7.1.3.Final (EAP)
Reporter: James Livingston
Assignee: James Livingston
Fix For: 7.2.0.Alpha1, 7.1.4.Final (EAP)
The commands in org.jboss.naming.remote.protocol.v1.Protocol deserialize objects using
the Unmarshaller from ReadUtil. That does not explicitly set a ClassResolver, so it
defaults to using the TCCL. Since the handle*Message methods are run in a thread pool, the
TCCL could be set to anything, so the commands need to ensure that the correct classloader
(presumably the one calling the Context methods) is used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5018
days inactive
5031
days old
5 comments
2 participants
participants (2)
-
Brian Stansberry (JIRA) -
James Livingston (JIRA)