[JBoss JIRA] Created: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
8:11 a.m.
Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Paul Gier
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he won't
get the required transitive dependencies, such as wagon or aether, so the resolver is
unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 p.m.
New subject: [JBoss JIRA] Commented: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Paul Gier commented on AS7-1403:
--------------------------------
I'm not sure I understand the problem. The transitive dependencies in many cases were
already flattened instead of removed. The ones that were removed were not needed. If the
testsuite requires certain dependencies, can't they be added directly to the testsuite
poms?
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Paul Gier
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:32 p.m.
New subject: [JBoss JIRA] Commented: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
David Lloyd commented on AS7-1403:
----------------------------------
I also don't understand. We've flattened transitive deps pretty much from day
one. It looks to me like the problem is simply that you're missing a dependency.
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Paul Gier
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:48 a.m.
New subject: [JBoss JIRA] Commented: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Karel Piwko commented on AS7-1403:
----------------------------------
I'll try to reword that:
ShrinkWrap Dependency Resolver (SWR) dependencies were not flattened and
shrinkwrap-resolver-impl-maven got to the jboss-as-parent bom as a part of ShrinkWrap
project.
If user wants to use SWR in AS7, he has to add all its dependencies manually, as its
dependencies were excluded and banned. These excluded dependencies are required for SWR to
run, but nobody mentioned that because at time of the excluded/banned list creation this
library was not used in any tests.
My point is that it would make much more sense:
1/ Use SWR as an external utility, e.g. not mentioned in jboss-as-parent at all. This way
user can simply include only shrinkwrap-resolver-impl-maven at place where he wants to use
it
2/ If dependency control is requirement, I can flatten shrinkwrap-resolver-impl end
explicitly enumerate all required dependecies there. Then jboss-as-parent will have to be
modified (e.g. remove excludes from shrinkwrap-resolver-impl). This way user can simply
include shrinkwrap-resolver-impl-amven at place where you wants to use it and you get the
dependency control.
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Paul Gier
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:20 a.m.
New subject: [JBoss JIRA] Commented: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Juergen Zimmermann commented on AS7-1403:
-----------------------------------------
As discussed in https://issues.jboss.org/browse/SHRINKWRAP-295 there is a problem when
Arquillian tests require artifacts from a maven repo, and these artifacts are lookup up
using the ShrinkWrap class MavenDependencyResolver.
Then you'll get this Maven dependency hierarchy:
* jboss-as-arquillian-container-remote:7.0.0.Final
* jboss-as-arquillian-common:7.0.0.Final
* shrinkwrap-resolver-impl-maven:1.0.0-beta-2 (!)
It took me almost a week to realize that not the current ShrinkWrap version is used, but
an old one. After manually extending my pom.xml with the current artifact
shrinkwrap-resolver-impl-maven:1.0.0-beta-5 the issue was gone.
To find this incompatibility is really frustrating. Is there no chance to provide the
up-to-date version of shrinkwrap-resolver-impl-maven?
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Paul Gier
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 p.m.
New subject: [JBoss JIRA] Assigned: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Jason Greene reassigned AS7-1403:
---------------------------------
Assignee: Andrew Rubinger (was: Paul Gier)
Andrew, could you add your thoughts on this? I'm not sure what else we could do here?
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Andrew Rubinger
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:22 p.m.
New subject: [JBoss JIRA] Assigned: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Andrew Rubinger reassigned AS7-1403:
------------------------------------
Assignee: Jason Greene (was: Andrew Rubinger)
I suspect we've run into one of the limitations of being so proactive with banning
transitive dependencies; when they're in place for a reason. :)
Recommend we arm jboss-as-parent with the latest SWR declarations in depMgt, as well as
the runtime dependencies it needs to execute. This can be enforced by adding some use of
SWR into the AS7 Integration TestSuite. In effect, Karel's recommendation 2) above,
plus adding a test to assert all's in place correctly. Drawback: this will amount to
adding more allowed dependencies upon jboss-as-parent, ie. Aether and everything it needs
to run effectively.
WDYT, Jas? If you agree we can submit a patch to get this done. Assigning back to you
for confirmation.
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Jason Greene
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:40 p.m.
New subject: [JBoss JIRA] Updated: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Paul Gier updated AS7-1403:
---------------------------
Attachment: 0001-AS7-1403-Relax-dependency-restrictions-related-to-ma.patch
The deps we try to keep as flat as possible are the ones in the build/pom tree. And since
shrinkwrap-resolver-impl-maven isn't even included in this tree, I think it's fine
to relax the restrictions as suggested. Karel, does the attached patch resolve the
problem for you?
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Jason Greene
Attachments: 0001-AS7-1403-Relax-dependency-restrictions-related-to-ma.patch
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:52 a.m.
New subject: [JBoss JIRA] Commented: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Karel Piwko commented on AS7-1403:
----------------------------------
Hi Paul,
sorry for the late reply...your patch solves the problem I had, tested on
7.1.0-Alpha2-SNAPSHOT, commit 6c047e9e637316efc37c642b410ea835e8fd36ea.
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Jason Greene
Attachments: 0001-AS7-1403-Relax-dependency-restrictions-related-to-ma.patch
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:49 a.m.
New subject: [JBoss JIRA] Updated: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Paul Gier updated AS7-1403:
---------------------------
Assignee: Paul Gier (was: Jason Greene)
Fix Version/s: 7.1.0.Beta1
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Paul Gier
Fix For: 7.1.0.Beta1
Attachments: 0001-AS7-1403-Relax-dependency-restrictions-related-to-ma.patch
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 a.m.
New subject: [JBoss JIRA] Updated: (AS7-1403) Excluded/Banned transitive dependencies for Maven Dependency Resolver are too strict
[
https://issues.jboss.org/browse/AS7-1403?page=com.atlassian.jira.plugin.s...
]
Paul Gier updated AS7-1403:
---------------------------
Git Pull Request: https://github.com/jbossas/jboss-as/pull/345
Excluded/Banned transitive dependencies for Maven Dependency Resolver
are too strict
------------------------------------------------------------------------------------
Key: AS7-1403
URL: https://issues.jboss.org/browse/AS7-1403
Project: Application Server 7
Issue Type: Bug
Components: Build System
Affects Versions: 7.0.0.Final
Reporter: Karel Piwko
Assignee: Paul Gier
Fix For: 7.1.0.Beta1
Attachments: 0001-AS7-1403-Relax-dependency-restrictions-related-to-ma.patch
During 7.0.0.CR1 build, there was a decision to remove transitive dependencies from other
projects and exclude/ban them in jboss-as-parent.
This decision has effectively crippled usage of Maven Dependency Resolver, which
wasn't used in CR1-date based testsuite, so the change passed silently.
If user wants to use the ShrinkWrap Dependency Resolver in the AS7 testsuite, he
won't get the required transitive dependencies, such as wagon or aether, so the
resolver is unusable.
According to disscussion with Vladimir, it would help "to flatten" dependency
tree for ShrinkWrap dependency Resolver, however, that's only the part of the
solution, the restrictions posed in AS7 parent must be relaxed afterwards.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5360
days inactive
5421
days old
10 comments
6 participants
participants (6)
-
Andrew Rubinger (JIRA) -
David Lloyd (JIRA)
-
Jason Greene (JIRA)
-
Juergen Zimmermann (JIRA)
-
Karel Piwko (JIRA)
-
Paul Gier (JIRA)