5:55 p.m.
problem with javac->aopc->javac sequence
----------------------------------------
Key: JBAOP-731
URL: https://jira.jboss.org/jira/browse/JBAOP-731
Project: JBoss AOP
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 2.1.1.GA
Environment: JDK 1.6.0_13/32bit
Reporter: Konstantin Sobolev
I'm trying to switch from JBossAOP 1.5.6 to 2.1.1 and can't build my project,
looks like there are some problems with aop-compiled classes. Here's what happens:
first we build our interface classes, let's say there's *abstract* POJO1 among
them. Then we run AopC on them, and it modifies POJO1.class
Then we compile some more classes, and there's non-abstract POJO2 there, which extends
POJO1. At this time javac fails with this message:
POJO2 is not abstract and does not override abstract method _getAdvisor() in
org.jboss.aop.Advised
javap shows that POJO1 now implements Advisable and indeed contains _getAdvisor() method,
but this method is not abstract! I'm confused.
Running AopC after compiling all of the classes works fine. Making POJO1 non-abstract also
makes javac happy.
I'm attaching a testcase. Unpack it into
jboss-aop-2.1.1.GA/docs/aspect-framework/examples/bug and run ant there to reproduce the
problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:04 p.m.
New subject: [JBoss JIRA] Updated: (JBAOP-731) problem with javac->aopc->javac sequence
[
https://jira.jboss.org/jira/browse/JBAOP-731?page=com.atlassian.jira.plug...
]
Konstantin Sobolev updated JBAOP-731:
-------------------------------------
Attachment: bug.tar.gz
problem with javac->aopc->javac sequence
----------------------------------------
Key: JBAOP-731
URL: https://jira.jboss.org/jira/browse/JBAOP-731
Project: JBoss AOP
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.1.1.GA
Environment: JDK 1.6.0_13/32bit
Reporter: Konstantin Sobolev
Attachments: bug.tar.gz
I'm trying to switch from JBossAOP 1.5.6 to 2.1.1 and can't build my project,
looks like there are some problems with aop-compiled classes. Here's what happens:
first we build our interface classes, let's say there's *abstract* POJO1 among
them. Then we run AopC on them, and it modifies POJO1.class
Then we compile some more classes, and there's non-abstract POJO2 there, which
extends POJO1. At this time javac fails with this message:
POJO2 is not abstract and does not override abstract method _getAdvisor() in
org.jboss.aop.Advised
javap shows that POJO1 now implements Advisable and indeed contains _getAdvisor() method,
but this method is not abstract! I'm confused.
Running AopC after compiling all of the classes works fine. Making POJO1 non-abstract
also makes javac happy.
I'm attaching a testcase. Unpack it into
jboss-aop-2.1.1.GA/docs/aspect-framework/examples/bug and run ant there to reproduce the
problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:35 p.m.
New subject: [JBoss JIRA] Commented: (JBAOP-731) problem with javac->aopc->javac sequence
[
https://jira.jboss.org/jira/browse/JBAOP-731?page=com.atlassian.jira.plug...
]
Konstantin Sobolev commented on JBAOP-731:
------------------------------------------
I've managed to disassemble POJO (POJO1) into Jasmin bytecode
(http://jasmin.sourceforge.net/) and then compile it back. Now javac yells at
POJO2.java:1: POJO2 is not abstract and does not override abstract method
_setInstanceAdvisor(org.jboss.aop.InstanceAdvisor) in org.jboss.aop.InstanceAdvised
public class POJO2 extends POJO
which looks much more reasonable. You can check out yourself, even the original
javac-produced POJO.class doesn't implement _setInstanceAdvisor.
It's interesting that this method implementation doesn't get inserted at all, but
by some reason javac doesn't implain if POJO(1) isn't declared abstract, I guess
they don't check if all method implementations are in place in this case.
So I believe there're 2 bugs here, one probably caused by a bug in javassist, another
- missing _setInstanceAdvisor.
problem with javac->aopc->javac sequence
----------------------------------------
Key: JBAOP-731
URL: https://jira.jboss.org/jira/browse/JBAOP-731
Project: JBoss AOP
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.1.1.GA
Environment: JDK 1.6.0_13/32bit
Reporter: Konstantin Sobolev
Attachments: bug.tar.gz
I'm trying to switch from JBossAOP 1.5.6 to 2.1.1 and can't build my project,
looks like there are some problems with aop-compiled classes. Here's what happens:
first we build our interface classes, let's say there's *abstract* POJO1 among
them. Then we run AopC on them, and it modifies POJO1.class
Then we compile some more classes, and there's non-abstract POJO2 there, which
extends POJO1. At this time javac fails with this message:
POJO2 is not abstract and does not override abstract method _getAdvisor() in
org.jboss.aop.Advised
javap shows that POJO1 now implements Advisable and indeed contains _getAdvisor() method,
but this method is not abstract! I'm confused.
Running AopC after compiling all of the classes works fine. Making POJO1 non-abstract
also makes javac happy.
I'm attaching a testcase. Unpack it into
jboss-aop-2.1.1.GA/docs/aspect-framework/examples/bug and run ant there to reproduce the
problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:37 p.m.
New subject: [JBoss JIRA] Updated: (JBAOP-731) problem with javac->aopc->javac sequence
[
https://jira.jboss.org/jira/browse/JBAOP-731?page=com.atlassian.jira.plug...
]
Konstantin Sobolev updated JBAOP-731:
-------------------------------------
Attachment: POJO.j
decompiled POJO.class
problem with javac->aopc->javac sequence
----------------------------------------
Key: JBAOP-731
URL: https://jira.jboss.org/jira/browse/JBAOP-731
Project: JBoss AOP
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.1.1.GA
Environment: JDK 1.6.0_13/32bit
Reporter: Konstantin Sobolev
Attachments: bug.tar.gz, POJO.j
I'm trying to switch from JBossAOP 1.5.6 to 2.1.1 and can't build my project,
looks like there are some problems with aop-compiled classes. Here's what happens:
first we build our interface classes, let's say there's *abstract* POJO1 among
them. Then we run AopC on them, and it modifies POJO1.class
Then we compile some more classes, and there's non-abstract POJO2 there, which
extends POJO1. At this time javac fails with this message:
POJO2 is not abstract and does not override abstract method _getAdvisor() in
org.jboss.aop.Advised
javap shows that POJO1 now implements Advisable and indeed contains _getAdvisor() method,
but this method is not abstract! I'm confused.
Running AopC after compiling all of the classes works fine. Making POJO1 non-abstract
also makes javac happy.
I'm attaching a testcase. Unpack it into
jboss-aop-2.1.1.GA/docs/aspect-framework/examples/bug and run ant there to reproduce the
problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:59 p.m.
New subject: [JBoss JIRA] Commented: (JBAOP-731) problem with javac->aopc->javac sequence
[
https://jira.jboss.org/jira/browse/JBAOP-731?page=com.atlassian.jira.plug...
]
Konstantin Sobolev commented on JBAOP-731:
------------------------------------------
Adding this 3 lines to POJO2 makes it compilable:
public org.jboss.aop.Advisor _getAdvisor() {return null;}
public void _setInstanceAdvisor(org.jboss.aop.InstanceAdvisor e) {}
public org.jboss.aop.InstanceAdvisor _getInstanceAdvisor() {return null;}
(yes, _getInstanceAdvisor isn't recognized as well, although javap shows it's
there).
POJO.class reconstructed from POJO.j requres only _setInstanceAdvisor to be added to POJO2
(second line)
problem with javac->aopc->javac sequence
----------------------------------------
Key: JBAOP-731
URL: https://jira.jboss.org/jira/browse/JBAOP-731
Project: JBoss AOP
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.1.1.GA
Environment: JDK 1.6.0_13/32bit
Reporter: Konstantin Sobolev
Attachments: bug.tar.gz, POJO.j
I'm trying to switch from JBossAOP 1.5.6 to 2.1.1 and can't build my project,
looks like there are some problems with aop-compiled classes. Here's what happens:
first we build our interface classes, let's say there's *abstract* POJO1 among
them. Then we run AopC on them, and it modifies POJO1.class
Then we compile some more classes, and there's non-abstract POJO2 there, which
extends POJO1. At this time javac fails with this message:
POJO2 is not abstract and does not override abstract method _getAdvisor() in
org.jboss.aop.Advised
javap shows that POJO1 now implements Advisable and indeed contains _getAdvisor() method,
but this method is not abstract! I'm confused.
Running AopC after compiling all of the classes works fine. Making POJO1 non-abstract
also makes javac happy.
I'm attaching a testcase. Unpack it into
jboss-aop-2.1.1.GA/docs/aspect-framework/examples/bug and run ant there to reproduce the
problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 a.m.
New subject: [JBoss JIRA] Commented: (JBAOP-731) problem with javac->aopc->javac sequence
[
https://jira.jboss.org/browse/JBAOP-731?page=com.atlassian.jira.plugin.sy...
]
Andrew Dinn commented on JBAOP-731:
-----------------------------------
I think you are right to be confused that javac complains that
POJO2 is not abstract and does not override abstract method _getAdvisor() in
org.jboss.aop.Advised
when javap shows that POJO1 implements Advisable and indeed contains a non-abstract
_getAdvisor() method. This seems to be very wrong. But it's not an AOP problem. This
is the compiler failign to eat what looks liek legitimate bytecode.
The reason javac is discounting this method is because it is tagged with the SYNTHETIC
attribute -- all AOP -generated methods are so tagged. I checked the javac source code in
OpenJDK and for some reason it explicitly discounts SYNTHETIC implementation methods when
attempting to verify that a non-abstract class implements all inherited abstract methods
(that includes interface methods which are implicitly taken to be abstract).
Now I don't know of anything in the JVM spec which states that a SYNTHETIC
implementation method is not a valid implementation of an abstract method. I believe this
is a bug in javac. What it looks like it is doing (and doing wrongly) is attempting to
discount so-called 'Miranda methods', i.e. pseudo-methods installed during
compilation as markers for an unimplemented abstract method. These are tagged with
attribute flags SYNTHETIC, ABSTRACT and IPROXY, a special flag used only by javac. I
believe the check which discounts an implementation method should look for flag IPROXY,
not flag SYNTHETIC. Thsi may be a hangover form earlier code as IPROXY appears to be a
recent introduction.
I will raise this as an issue with the OpenJDK team and see if we can agree that it is a
bug and push a fix through into OpenJDK and, from there, the Sun JVM. Until this is fixed
we cannot fix AOP. It is not possilble to remove the SYNTHETIC tag from AOP generated
methods as this will cause other problems (see https://jira.jboss.org/browse/JBAOP-642 and
https://jira.jboss.org/browse/JBAOP-782).
problem with javac->aopc->javac sequence
----------------------------------------
Key: JBAOP-731
URL: https://jira.jboss.org/browse/JBAOP-731
Project: JBoss AOP
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.1.1.GA
Environment: JDK 1.6.0_13/32bit
Reporter: Konstantin Sobolev
Attachments: bug.tar.gz, POJO.j
I'm trying to switch from JBossAOP 1.5.6 to 2.1.1 and can't build my project,
looks like there are some problems with aop-compiled classes. Here's what happens:
first we build our interface classes, let's say there's *abstract* POJO1 among
them. Then we run AopC on them, and it modifies POJO1.class
Then we compile some more classes, and there's non-abstract POJO2 there, which
extends POJO1. At this time javac fails with this message:
POJO2 is not abstract and does not override abstract method _getAdvisor() in
org.jboss.aop.Advised
javap shows that POJO1 now implements Advisable and indeed contains _getAdvisor() method,
but this method is not abstract! I'm confused.
Running AopC after compiling all of the classes works fine. Making POJO1 non-abstract
also makes javac happy.
I'm attaching a testcase. Unpack it into
jboss-aop-2.1.1.GA/docs/aspect-framework/examples/bug and run ant there to reproduce the
problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:27 a.m.
New subject: [JBoss JIRA] Commented: (JBAOP-731) problem with javac->aopc->javac sequence
[
https://jira.jboss.org/browse/JBAOP-731?page=com.atlassian.jira.plugin.sy...
]
Andrew Dinn commented on JBAOP-731:
-----------------------------------
One thing you might try as a workaround is to compile the subclass against the superclass
bytecode as it was before applying the AOP transform (assuming that this is an option for
you and/or anyone consuming your code). The resulting bytecode for the subclass should
still be able to be loaded into the target runtime alongside the AOP-transformed version
of the superclass.
problem with javac->aopc->javac sequence
----------------------------------------
Key: JBAOP-731
URL: https://jira.jboss.org/browse/JBAOP-731
Project: JBoss AOP
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.1.1.GA
Environment: JDK 1.6.0_13/32bit
Reporter: Konstantin Sobolev
Attachments: bug.tar.gz, POJO.j
I'm trying to switch from JBossAOP 1.5.6 to 2.1.1 and can't build my project,
looks like there are some problems with aop-compiled classes. Here's what happens:
first we build our interface classes, let's say there's *abstract* POJO1 among
them. Then we run AopC on them, and it modifies POJO1.class
Then we compile some more classes, and there's non-abstract POJO2 there, which
extends POJO1. At this time javac fails with this message:
POJO2 is not abstract and does not override abstract method _getAdvisor() in
org.jboss.aop.Advised
javap shows that POJO1 now implements Advisable and indeed contains _getAdvisor() method,
but this method is not abstract! I'm confused.
Running AopC after compiling all of the classes works fine. Making POJO1 non-abstract
also makes javac happy.
I'm attaching a testcase. Unpack it into
jboss-aop-2.1.1.GA/docs/aspect-framework/examples/bug and run ant there to reproduce the
problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5846
days inactive
6279
days old
6 comments
2 participants
participants (2)
-
Andrew Dinn (JIRA) -
Konstantin Sobolev (JIRA)