[
https://issues.redhat.com/browse/DROOLS-6030?page=com.atlassian.jira.plug...
]
Mario Fusco commented on DROOLS-6030:
-------------------------------------
[~gabriolo]
Thanks for quick reply. I'm giving a look into this. Correct me if I'm wrong but
1) doesn't seem related with this issue because there you're using the addPackage
method of the KnowledgeBuilder, not the KieBase one and that one is perfectly fine. There
you're adding the packages to be built to the builder and then a new KieBase will be
created from there.
What [~lucamolteni] pointed out to be more problematic is the usage of the addPackage
method directly on the KieBase that you have in 2). By doing so you're no longer
adding packages to a builder and then obtaining the KieBase with the required packages
from the builder, but you're adding packages (here I'm generally speaking about
"packages" but of course they're a different thing at this stage) directly
to an already existing KieBase.
I don't know how feasible it is in your context (and if I remember correctly we
already discussed this) but ideally we should have in 2) something similar to what we have
in 1), i.e. putting together the packages to be included in the KieBase at building time.
Evaluate "KieBase.addPackage" replacement effort from PMML
----------------------------------------------------------
Key: DROOLS-6030
URL:
https://issues.redhat.com/browse/DROOLS-6030
Project: Drools
Issue Type: Task
Reporter: Gabriele Cardosi
Assignee: Gabriele Cardosi
Priority: Major
Currently, the method KieBase.addPackage(s) is used inside PMML in two classes
1) PMMLLoaderService.loadPMMLRuleMappers
2) PMMLRuntimeFactoryInternal.getPMMLRuntime(String, String, KieBase)
3) PMMLRuntimeFactoryInternal.createKieBase(KnowledgeBuilderImpl)
In all those cases the needs is to create a "clean" kiebase that contains only
the model-specific packages, to avoid name/session clashing.
Scope of the current ticket is to evaluate an alternative, since the method itself is
going to be deprecated.
--
This message was sent by Atlassian Jira
(v8.13.1#813001)