[JBoss JIRA] Created: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[JBoss JIRA] Created:...

Geoffrey De Smet (JIRA)

Friday, 17 October 2008 Fri, 17 Oct '08

6:54 p.m.

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public (Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.M3 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Show replies by date

Michal Bali (JIRA)

Friday, 17 October Fri, 17 Oct

11:49 p.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Michal Bali commented on JBRULES-1804: -------------------------------------- Interesting issue. There is a small typo on this line: FactHandle sensor3Handle = workingMemory.insert( sensor2 ); I guess it should be: FactHandle sensor3Handle = workingMemory.insert( sensor3 ); class Sensor doesn't override equals/hashCode. In my opinion it should for this test. I've locally overriden them, but the result is still the same. IMHO There may be a bug. Interesting issue.

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.M3 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

Geoffrey De Smet (JIRA)

Saturday, 18 October Sat, 18 Oct

10:04 a.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Geoffrey De Smet commented on JBRULES-1804: ------------------------------------------- Thanks for noticing the typo :) I 've fixed the typo in svn I don't agree that Sensor should override equals/hashCode so it takes temperature into account, though a separate test where another testfact does would be interesting too. My use cases in drools-solver follow the Sensor problem: it's the same Sensor (so equals isn't affected), it's temperature just changes.

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.M3 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Edson Tirelli (JIRA)

10:25 p.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Edson Tirelli commented on JBRULES-1804: ---------------------------------------- Geoffrey, I talked to Mark this morning and he said he already discussed this problem with you some time ago. From the current implementation of TMS, since the rule continues to be true after the change, the logical assertion is still justified, event if it is justifying a new logical assertion at the same time. He said he will add some thoughts here and maybe we can discuss a way to support both approaches. Simply changing behavior is not really an option.

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.M3 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Geoffrey De Smet (JIRA)

10:41 p.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Geoffrey De Smet commented on JBRULES-1804: ------------------------------------------- To me, it looks like the current approach violates the principle of least surprise. As a simple end-user of drools I don't really understand why the current behaviour is intended. But if there's be an option to disable that behaviour that would be good enough for me :) Thanks.

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.M3 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Mark Proctor (JIRA)

11:53 p.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Mark Proctor commented on JBRULES-1804: --------------------------------------- Geoffrey, isn't this what we discussed many months ago? Where I said it wasn't a bug, but maybe just a different approach, but one that would be very hard for us to code for, as it's non trivial, so unlikely we will fix as a priority :( Jess approach is to not preserve a logical assertion on a modify, so when you do a modify on the retract part of the modify all the logical assertions are removed too, and won't be re-added until the consequence fires. We could possible allow this, would that suffice?

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.M3 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Geoffrey De Smet (JIRA)

Sunday, 19 October Sun, 19 Oct

9:39 a.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Geoffrey De Smet commented on JBRULES-1804: ------------------------------------------- Mark, it's indeed what we discussed month ago, but I didn't think I explained it well enough, so I hoped a testcase would clarify the issue. It's been bugging me in drools-solver ever since, consistently giving me hard to track down corrupted scores, and apparently other drools-solver users, such as Tim, too: "exactly! that is the behavior i was expecting (=> the new behaviour). it took me quite some time to find out why my program did not find a solution." After a good night sleep, I still don't get it. 1) Could you give me one example where the original behavior would actually be a good thing? "Jess approach is to not preserve a logical assertion on a modify, so when you do a modify on the retract part of the modify all the logical assertions are removed too, and won't be re-added until the consequence fires. We could possible allow this, would that suffice?" 2) Would the testcase in subversion end up with temperatures of 150 and 200 and not 100? If yes, that would suffice (and would make my day :)).

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.M3 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Edson Tirelli (JIRA)

Wednesday, 26 November Wed, 26 Nov

4:50 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Edson Tirelli updated JBRULES-1804: ----------------------------------- Fix Version/s: 5.0.0.CR1 (was: 5.0.0.M3)

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.CR1 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Mark Proctor (JIRA)

Friday, 23 January Fri, 23 Jan

4:32 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Mark Proctor updated JBRULES-1804: ---------------------------------- Fix Version/s: 5.0.0.CR1 (was: 5.0.0.M5)

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.CR1 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Mark Proctor (JIRA)

Thursday, 19 March Thu, 19 Mar

3:28 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Mark Proctor updated JBRULES-1804: ---------------------------------- Fix Version/s: 5.0.0.GA (was: 5.0.0.CR1)

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.GA This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Geoffrey De Smet (JIRA)

Monday, 13 April Mon, 13 Apr

8:44 p.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.0.0.GA This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Edson Tirelli (JIRA)

Wednesday, 20 May Wed, 20 May

4:07 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Edson Tirelli updated JBRULES-1804: ----------------------------------- Fix Version/s: 5.1.0.M1 (was: 5.0.1.FINAL)

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.1.0.M1 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Geoffrey De Smet (JIRA)

Tuesday, 30 June Tue, 30 Jun

8:10 p.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Geoffrey De Smet commented on JBRULES-1804: ------------------------------------------- Laurent on the mailing list ran into this one too. It happens when you calculate the weight of a constraintoccurrence based on property of a fact and that property isn't stable (although the working memory has been notified that the fact was changes, so it property could have changed)

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: JBoss Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.1.0.M1 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Edson Tirelli (JIRA)

Sunday, 11 October Sun, 11 Oct

9:27 p.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Edson Tirelli updated JBRULES-1804: ----------------------------------- Fix Version/s: 5.1.0.M2 (was: 5.1.0.M1)

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.1.0.M2 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Mark Proctor (JIRA)

Saturday, 3 April Sat, 3 Apr

9:12 p.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Mark Proctor commented on JBRULES-1804: --------------------------------------- "hack" from geoffrey for solver: // All demanded shifts must be assigned to a nurse rule "requiredEmployeeSizePerShift" when $shift : Shift(requiredEmployeeSize > 0, $requiredEmployeeSize : requiredEmployeeSize); $totalEmployeeSize : Number(intValue != $requiredEmployeeSize) from accumulate( $assignment : EmployeeAssignment(shift == $shift), count($assignment) ); // HACK to fix wierd truth maintenance behavior in drools // because making weight part of the equals/hashcode doesn't cut it // Vote for https://jira.jboss.org/jira/browse/JBRULES-1804 not IntConstraintOccurrence( ruleId == "requiredEmployeeSizePerShift", constraintType == ConstraintType.NEGATIVE_HARD, causes contains $shift, eval(weight != Math.abs($requiredEmployeeSize - $totalEmployeeSize.intValue())) ); then insertLogical(new IntConstraintOccurrence("requiredEmployeeSizePerShift", ConstraintType.NEGATIVE_HARD, Math.abs($requiredEmployeeSize - $totalEmployeeSize.intValue()), $shift)); end

...

Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch) ----------------------------------------------------------------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.1.0.M2 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Mark Proctor (JIRA)

Sunday, 4 April Sun, 4 Apr

4:30 a.m.

New subject: [JBoss JIRA] Updated: (JBRULES-1804) Logical dependencies accumulate on recursion

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Mark Proctor updated JBRULES-1804: ---------------------------------- Summary: Logical dependencies accumulate on recursion (was: Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch))

...

Logical dependencies accumulate on recursion -------------------------------------------- Key: JBRULES-1804 URL: https://jira.jboss.org/jira/browse/JBRULES-1804 Project: Drools Issue Type: Bug Security Level: Public(Everyone can see) Components: drools-core (expert) Affects Versions: 5.0.0.M2 Reporter: Geoffrey De Smet Assignee: Edson Tirelli Priority: Critical Fix For: 5.1.0.M2 This one got me headscratching for a while, untill I realized what the problem is. Tim reported on the mailing list he ran into it to. I've commmited a testcase in subversion, in TruthMaintenanceTest, called disabled_testLogicalInsertionsModifySameRuleGivesDifferentLogicalInsertion Remove the "disabled_" to enable it and try it out. Here's what happens in the testcase: 3 sensors with tempature 100, 200 and 200 are inserted. There's a rule which logically inserts all encountered tempatures, so 100 and 200. Then the first sensor modifies to a tempature of 150. As it turns out, the encoutered tempatures should be 150 and 200 now, but instead it's 100, 150 and 200. Even though there is no sensor that has a tempature of 100.

Mark Proctor (JIRA)

4:32 a.m.

New subject: [JBoss JIRA] Commented: (JBRULES-1804) Logical dependencies accumulate on recursion

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Mark Proctor commented on JBRULES-1804: --------------------------------------- Before the first logical insertion we make a copy of the current LogicalDependencies. For each logical insertion we check the copied list and if it exists we remove it and just add it back onto the current activation. After the rule has fired we cancel any remaining LogicalDependencies.

...

Mark Proctor (JIRA)

4:36 a.m.

New subject: [JBoss JIRA] Closed: (JBRULES-1804) Logical dependencies accumulate on recursion

[ https://jira.jboss.org/jira/browse/JBRULES-1804?page=com.atlassian.jira.p... ] Mark Proctor closed JBRULES-1804. --------------------------------- Resolution: Done

...

5144

days inactive

5678

days old

jboss-jira@lists.jboss.org

Manage subscription

17 comments

4 participants

tags (0)

participants (4)

Edson Tirelli (JIRA)
Geoffrey De Smet (JIRA)
Mark Proctor (JIRA)
Michal Bali (JIRA)

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

[JBoss JIRA] Created: (JBRULES-1804) Logical insertion lingers after the rule that inserted it no longer supports it (with testcase patch)