[ https://issues.redhat.com/browse/WFWIP-357?page=com.atlassian.jira.plugin... ] Jan Blizňák updated WFWIP-357: ------------------------------ Steps to Reproduce: Analysis provides this information: {code:java} Test EAP S2I image changes - Import a more recent version of EAP S2I images (test should be done for both the builder and runtime images referenced by the imagestreams) {code} However, in current template configuration there is no trigger upon EAP_RUNTIME_IMAGE imagestream change. This is obvious why it doesn't happen when we look into template: bc ${APPLICATION_IMAGE}-build-artifacts - [https://github.com/jmesnil/jboss-eap-openshift-templates/blob/eap-s2i-bui...] {code:java} triggers: - github: secret: ${GITHUB_WEBHOOK_SECRET} type: GitHub - generic: secret: ${GENERIC_WEBHOOK_SECRET} type: Generic - imageChange: {} type: ImageChange - type: ConfigChange {code} bc ${APPLICATION_IMAGE} - [https://github.com/jmesnil/jboss-eap-openshift-templates/blob/eap-s2i-bui...] {code:java} triggers: - imageChange: from: kind: ImageStreamTag name: ${APPLICATION_IMAGE}-build-artifacts:latest type: ImageChange - type: ConfigChange {code} -> no trigger for EAP_RUNTIME_IMAGE imagestream changes So now the expectation (rebuild app image on both builder or runtime image change) is broken. was: Analysis provides this information: {code:java} Test EAP S2I image changes - Import a more recent version of EAP S2I images (test should be done for both the builder and runtime images referenced by the imagestreams) {code} However, in current template configuration there is no trigger upon EAP_RUNTIME_IMAGE imagestream change. This is obvious why it doesn't happen when we look into template: bc ${APPLICATION_IMAGE}-build-artifacts - [https://github.com/jmesnil/jboss-eap-openshift-templates/blob/eap-s2i-bui...] {code:java} triggers: - github: secret: ${GITHUB_WEBHOOK_SECRET} type: GitHub - generic: secret: ${GENERIC_WEBHOOK_SECRET} type: Generic - imageChange: {} type: ImageChange - type: ConfigChange {code} bc ${APPLICATION_IMAGE} - [https://github.com/jmesnil/jboss-eap-openshift-templates/blob/eap-s2i-bui...] {code:java} triggers: - imageChange: from: kind: ImageStreamTag name: ${APPLICATION_IMAGE}-build-artifacts:latest type: ImageChange - type: ConfigChange {code} -> no trigger for EAP_RUNTIME_IMAGE imagestream changes So now the expectation (rebuild app image on both builder or runtime image change) is broken. This can be probably fixed just by adding additional trigger to either of BuildConfigs, eg. equivalent of this: {code:java} oc set triggers bc autoupgrading-app --from-image=eap7-runtime-imagestream:latest {code} But design decision needs to be made: # leave as is (probably not? - contrary to analysis) ## no rebuild when _only_ runtime image gets updated - we can argue how big issue it is as theoretically what needs to go to runtime image most likely is needed for builder image too, so it gets updated # add trigger to the second-in-chan BuildConfig ## quicker as only one build is triggered and intermediate resources reused ## requires intermediate imagestream to exist ## doesn't suffer from duplicated rebuild # add trigger to the first-in-chain BuildConfig ## safer as everything is build from scratch ## slower as two builds need to be done ## could suffer from double rebuild - when both builder and runtime image is updated -- This message was sent by Atlassian Jira (v7.13.8#713008)