[JBoss JIRA] (JGRP-1980) Improve throughput under contention for FlowControl.Credit
- First Post
- Replies
- Stats
-
Go to
- ----- 2026 -----
- April
- March
- February
- January
- ----- 2025 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2024 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
[
https://issues.jboss.org/browse/JGRP-1980?page=com.atlassian.jira.plugin....
]
Bela Ban resolved JGRP-1980.
----------------------------
Resolution: Partially Completed
Moved a synchronized get() into the if(log.isTraceEnabled()) block.
Other than that, I didn't spot any oppurtunities for improvement... Perhaps replace
synchronized with ReentrantLock and Object.wait()/notifyAll() with
Condition.await()/signalAl()? Googling for the cost of these didn't reveal any
insights...
Feel free to reopen this issue if we see any real contention in flight recorder.
Improve throughput under contention for FlowControl.Credit
----------------------------------------------------------
Key: JGRP-1980
URL: https://issues.jboss.org/browse/JGRP-1980
Project: JGroups
Issue Type: Enhancement
Affects Versions: 3.6.6
Reporter: Sanne Grinovero
Assignee: Bela Ban
Fix For: 3.6.8
Attachments: bla.java
The methods {{org.jgroups.protocols.FlowControl.Credit.decrementIfEnoughCredits(long,
long)}} and {{org.jgroups.protocols.FlowControl.Credit.decrementAndGet(long)}} are
contending the locks on class synchronization when stress testing JGroups.
Wondering if we can think of polishing the implementation, although it looks like
challenging.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
3749
days inactive
3749
days old
0 comments
1 participants
tags (0)
participants (1)
-
Bela Ban (JIRA)