[JBoss JIRA] Created: (JBCACHE-931) Move to JBossAOP rather than hand-wiring interceptor chain for JBoss Cache
11:42 a.m.
Move to JBossAOP rather than hand-wiring interceptor chain for JBoss Cache
--------------------------------------------------------------------------
Key: JBCACHE-931
URL: http://jira.jboss.com/jira/browse/JBCACHE-931
Project: JBoss Cache
Issue Type: Task
Security Level: Public (Everyone can see)
Affects Versions: 2.0.0.GA
Reporter: Manik Surtani
Assigned To: Manik Surtani
Fix For: 2.1.0.GA
This should be a seamless change for end-users, and backward compat should be maintained.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:21 p.m.
New subject: [JBoss JIRA] Updated: (JBCACHE-931) Move to JBossAOP rather than hand-wiring interceptor chain for JBoss Cache
[ http://jira.jboss.com/jira/browse/JBCACHE-931?page=all ]
Manik Surtani updated JBCACHE-931:
----------------------------------
Fix Version/s: 2.2.0.GA
(was: 2.1.0.GA)
Move to JBossAOP rather than hand-wiring interceptor chain for JBoss
Cache
--------------------------------------------------------------------------
Key: JBCACHE-931
URL: http://jira.jboss.com/jira/browse/JBCACHE-931
Project: JBoss Cache
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.GA
Reporter: Manik Surtani
Assigned To: Manik Surtani
Fix For: 2.2.0.GA
This should be a seamless change for end-users, and backward compat should be maintained.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:06 a.m.
New subject: [JBoss JIRA] Commented: (JBCACHE-931) Move to JBossAOP rather than hand-wiring interceptor chain for JBoss Cache
[ http://jira.jboss.com/jira/browse/JBCACHE-931?page=comments#action_12378724 ]
Mircea Markus commented on JBCACHE-931:
---------------------------------------
Another refactoring approach would be using of the visitor pattern in order to support a
clearer and stronger typed way of intercepting.
(I think this is an from-manual usage of visitor pattern actually)
Each intercepted method would be a Visitable and have the following structure:
PutKeyValueMethod implements InterceptedMethod
{
accept(InterceptedMethodVisitor visitor)
{
visitor.visitPut(fqn, key, value)
}
}
Each Interceptor would be a Visitor, able to handle all intercepted operations
EvictionInterceptorVisitor implements MethodInterceptroVisitor
{
visitPut(fqn, key, value)
visitPut(fqn, attrMap)
....
}
Benefits: all the switch statements which are at the base of each interceptor would be
elegantly replaced(this includes the bunch of inner classes needed to handle those
scenarios, like in the case of EvictionInterceptors). The code would be easy to follow, as
for each intercepted method there will be an exact handling place within each
interceptor. Performance might be increased as, for example the PutKeyValueMethod might
perform a direct call to cahe.put(fqn, key, value) rather than doing it through
reflection. Extensibility would be straight forward ... and the effort of implementing it
might be reduced by the fact that code won't change, it will only move(also the task
can be done in parallel, a dev/interceptor).
I think this might be considered as an alternative to the AOP approach.
Move to JBossAOP rather than hand-wiring interceptor chain for JBoss
Cache
--------------------------------------------------------------------------
Key: JBCACHE-931
URL: http://jira.jboss.com/jira/browse/JBCACHE-931
Project: JBoss Cache
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.GA
Reporter: Manik Surtani
Assigned To: Manik Surtani
Fix For: 2.2.0.GA
This should be a seamless change for end-users, and backward compat should be maintained.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 p.m.
New subject: [JBoss JIRA] Updated: (JBCACHE-931) Optimise hand-wired interceptor chain by using a CacheInterceptorDelegate and a NodeInterceptorDelegate
[ http://jira.jboss.com/jira/browse/JBCACHE-931?page=all ]
Manik Surtani updated JBCACHE-931:
----------------------------------
Summary: Optimise hand-wired interceptor chain by using a
CacheInterceptorDelegate and a NodeInterceptorDelegate (was: Move to JBossAOP rather than
hand-wiring interceptor chain for JBoss Cache)
Fix Version/s: 2.1.0.GA
(was: 2.2.0.GA)
Optimise hand-wired interceptor chain by using a
CacheInterceptorDelegate and a NodeInterceptorDelegate
-------------------------------------------------------------------------------------------------------
Key: JBCACHE-931
URL: http://jira.jboss.com/jira/browse/JBCACHE-931
Project: JBoss Cache
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.GA
Reporter: Manik Surtani
Assigned To: Manik Surtani
Fix For: 2.1.0.GA
This should be a seamless change for end-users, and backward compat should be maintained.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:22 p.m.
New subject: [JBoss JIRA] Commented: (JBCACHE-931) Optimise hand-wired interceptor chain by using a CacheInterceptorDelegate and a NodeInterceptorDelegate
[ http://jira.jboss.com/jira/browse/JBCACHE-931?page=comments#action_12391368 ]
Manik Surtani commented on JBCACHE-931:
---------------------------------------
Not going to use a visitor pattern for this
Optimise hand-wired interceptor chain by using a
CacheInterceptorDelegate and a NodeInterceptorDelegate
-------------------------------------------------------------------------------------------------------
Key: JBCACHE-931
URL: http://jira.jboss.com/jira/browse/JBCACHE-931
Project: JBoss Cache
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.GA
Reporter: Manik Surtani
Assigned To: Manik Surtani
Fix For: 2.1.0.GA
This should be a seamless change for end-users, and backward compat should be maintained.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:27 p.m.
New subject: [JBoss JIRA] Commented: (JBCACHE-931) Optimise hand-wired interceptor chain by using a CacheInterceptorDelegate and a NodeInterceptorDelegate
[ http://jira.jboss.com/jira/browse/JBCACHE-931?page=comments#action_12391373 ]
Manik Surtani commented on JBCACHE-931:
---------------------------------------
Instead, going to use a delegate to invoke calls on the cache:
* CacheInvocationDelegate implements Cache and CacheSPI
* This is what users get when creating a cache using a CacheFactory
* Delegates calls to the interceptor chain, and the last interceptor in the chain invokes
the method on CacheImpl
* CacheImpl does not implement Cache/CacheSPI
* NodeInvocationDelegate implements Node and NodeSPI
* This is what users get when creating a cache using a NodeFactory
* Delegates calls to the interceptor chain, and the last interceptor in the chain invokes
the method on UnversionedNode
* UnversionedNode does not implement Node/NodeSPI
* JGroups RPCDIspatcher invokes stuff on RemoteCacheInvocationDelegate
Optimise hand-wired interceptor chain by using a
CacheInterceptorDelegate and a NodeInterceptorDelegate
-------------------------------------------------------------------------------------------------------
Key: JBCACHE-931
URL: http://jira.jboss.com/jira/browse/JBCACHE-931
Project: JBoss Cache
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.GA
Reporter: Manik Surtani
Assigned To: Manik Surtani
Fix For: 2.1.0.GA
This should be a seamless change for end-users, and backward compat should be maintained.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:52 a.m.
New subject: [JBoss JIRA] Resolved: (JBCACHE-931) Optimise hand-wired interceptor chain by using a CacheInterceptorDelegate and a NodeInterceptorDelegate
[ http://jira.jboss.com/jira/browse/JBCACHE-931?page=all ]
Manik Surtani resolved JBCACHE-931.
-----------------------------------
Resolution: Done
Optimise hand-wired interceptor chain by using a
CacheInterceptorDelegate and a NodeInterceptorDelegate
-------------------------------------------------------------------------------------------------------
Key: JBCACHE-931
URL: http://jira.jboss.com/jira/browse/JBCACHE-931
Project: JBoss Cache
Issue Type: Task
Security Level: Public(Everyone can see)
Affects Versions: 2.0.0.GA
Reporter: Manik Surtani
Assigned To: Manik Surtani
Fix For: 2.1.0.GA
This should be a seamless change for end-users, and backward compat should be maintained.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6007
days inactive
6366
days old
6 comments
3 participants
participants (3)
-
Manik Surtani (JIRA) -
Manik Surtani (JIRA) -
Mircea Markus (JIRA)