1:43 a.m.
Use Java annotations to automatically set protocol properties
-------------------------------------------------------------
Key: JGRP-723
URL: http://jira.jboss.com/jira/browse/JGRP-723
Project: JGroups
Issue Type: Feature Request
Affects Versions: 2.7
Reporter: Vladimir Blagojevic
Assigned To: Vladimir Blagojevic
Fix For: 2.7
Currently we use a lot of boiler plate code to read protocol properties specified in
configuration file. We can eliminate this unnecessary code by using annotations and a bit
of Java reflection that would assign protocol property values to matching Java fields,
give warnings for deprecated properties, and so on. We should:
1) introduce @ProtocolProperty annotation
2) annotate Protocol fields that are properties
3) test framework
4) remove all current boilerplate code
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:33 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-723) Use Java annotations to automatically set protocol properties
[ http://jira.jboss.com/jira/browse/JGRP-723?page=comments#action_12404700 ]
Bela Ban commented on JGRP-723:
-------------------------------
I've thought about this before, but one big argument against it is that this would not
work in the J2ME world. Annotations for exposing attrs and ops for JMX are okay, because
this is optional in J2ME, but the protocol config isn't.
Let's discuss this during our Kreuzlingen meeting...
Use Java annotations to automatically set protocol properties
-------------------------------------------------------------
Key: JGRP-723
URL: http://jira.jboss.com/jira/browse/JGRP-723
Project: JGroups
Issue Type: Feature Request
Affects Versions: 2.7
Reporter: Vladimir Blagojevic
Assigned To: Vladimir Blagojevic
Fix For: 2.7
Currently we use a lot of boiler plate code to read protocol properties specified in
configuration file. We can eliminate this unnecessary code by using annotations and a bit
of Java reflection that would assign protocol property values to matching Java fields,
give warnings for deprecated properties, and so on. We should:
1) introduce @ProtocolProperty annotation
2) annotate Protocol fields that are properties
3) test framework
4) remove all current boilerplate code
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:49 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-723) Use Java annotations to automatically set protocol properties
[ http://jira.jboss.com/jira/browse/JGRP-723?page=comments#action_12410536 ]
Bela Ban commented on JGRP-723:
-------------------------------
Okay, here's what Vladimir and I discussed:
@Property
long timeout=5000;
This means we'll take a property "timeout" (parsed from the XML) and set a
field called 'property' in the given protocol.
@Property
void setMaxBundleTimeout(String val) {...}
This means we'll invoke this setter with a property that's either called
"max_bundle_timeout" or "maxBundleTimeout".
Logic:
#1 Get all methods which take a string argument and are annotated with @Property (include
superclasses, up to Protocol).
#2 Invoke any setter M (void setM(String)) with the corresponding property. Remove the
property if successful
#3 Find all attrs annotated with @Property
#4 Set the field from the property, convert the string to the primitive type
#5 If the field is not a primitive type, and there wasn't a setter, throw an
exception
#6 Remove the prop from the props list. If done, and list is not empty, throw an
exception
Add @Deprecated(msg="bla"). If a setter or attr is annotated with @Deprecated,
display the message and remove the property.
For validation or other complex logic, always use a setter, Ditto for non-rpimitive
fields
Use Java annotations to automatically set protocol properties
-------------------------------------------------------------
Key: JGRP-723
URL: http://jira.jboss.com/jira/browse/JGRP-723
Project: JGroups
Issue Type: Feature Request
Affects Versions: 2.7
Reporter: Vladimir Blagojevic
Assigned To: Vladimir Blagojevic
Fix For: 2.7
Currently we use a lot of boiler plate code to read protocol properties specified in
configuration file. We can eliminate this unnecessary code by using annotations and a bit
of Java reflection that would assign protocol property values to matching Java fields,
give warnings for deprecated properties, and so on. We should:
1) introduce @ProtocolProperty annotation
2) annotate Protocol fields that are properties
3) test framework
4) remove all current boilerplate code
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:11 a.m.
New subject: [JBoss JIRA] Resolved: (JGRP-723) Use Java annotations to automatically set protocol properties
[ http://jira.jboss.com/jira/browse/JGRP-723?page=all ]
Vladimir Blagojevic resolved JGRP-723.
--------------------------------------
Resolution: Done
Resolved. The algorithm is slightly changed from Bela's outline:
1) Resolve all Protocol fields with @Property annotation and assign values to fields
2) Resolve all Protocol methods with @Property annotation and invoke those methods
3) Invoke Protocol#setProperties to deal with hard to handle scenarios (cannot be handled
by steps 1 or 2)
Use Java annotations to automatically set protocol properties
-------------------------------------------------------------
Key: JGRP-723
URL: http://jira.jboss.com/jira/browse/JGRP-723
Project: JGroups
Issue Type: Feature Request
Affects Versions: 2.7
Reporter: Vladimir Blagojevic
Assigned To: Vladimir Blagojevic
Fix For: 2.7
Currently we use a lot of boiler plate code to read protocol properties specified in
configuration file. We can eliminate this unnecessary code by using annotations and a bit
of Java reflection that would assign protocol property values to matching Java fields,
give warnings for deprecated properties, and so on. We should:
1) introduce @ProtocolProperty annotation
2) annotate Protocol fields that are properties
3) test framework
4) remove all current boilerplate code
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:15 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-723) Use Java annotations to automatically set protocol properties
[ http://jira.jboss.com/jira/browse/JGRP-723?page=comments#action_12412160 ]
Vladimir Blagojevic commented on JGRP-723:
------------------------------------------
See new classes/interfaces and corresponding javadoc for more details.
Commit set:
Revision Changes Path
1.2 +13 -0 JGroups/src/org/jgroups/conf/PropertyConverter.java
1.2 +17 -3 JGroups/src/org/jgroups/conf/PropertyConverters.java
1.34 +166 -44 JGroups/src/org/jgroups/stack/Configurator.java
1.2 +26 -4 JGroups/src/org/jgroups/annotations/Property.java
Use Java annotations to automatically set protocol properties
-------------------------------------------------------------
Key: JGRP-723
URL: http://jira.jboss.com/jira/browse/JGRP-723
Project: JGroups
Issue Type: Feature Request
Affects Versions: 2.7
Reporter: Vladimir Blagojevic
Assigned To: Vladimir Blagojevic
Fix For: 2.7
Currently we use a lot of boiler plate code to read protocol properties specified in
configuration file. We can eliminate this unnecessary code by using annotations and a bit
of Java reflection that would assign protocol property values to matching Java fields,
give warnings for deprecated properties, and so on. We should:
1) introduce @ProtocolProperty annotation
2) annotate Protocol fields that are properties
3) test framework
4) remove all current boilerplate code
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6658
days inactive
6701
days old
4 comments
2 participants
participants (2)
-
Bela Ban (JIRA) -
Vladimir Blagojevic (JIRA)