[JBoss JIRA] Created: (AS7-1042) Adding interceptors with the same priority leads to non-deterministic behaviour
3 a.m.
Adding interceptors with the same priority leads to non-deterministic behaviour
-------------------------------------------------------------------------------
Key: AS7-1042
URL: https://issues.jboss.org/browse/AS7-1042
Project: Application Server 7
Issue Type: Bug
Components: EE
Reporter: Carlo de Wolf
Priority: Blocker
Fix For: 7.0.0.CR1
{code:java}
public static final int SINGLETON_CONTAINER_MANAGED_CONCURRENCY_INTERCEPTOR = 0x800;
public static final int USER_INTERCEPTORS = 0x800;
{code}
The order of execution between CONCURRENCY and USER is no longer guaranteed.
The EE framework must detect such a setup and fail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:25 a.m.
New subject: [JBoss JIRA] Assigned: (AS7-1042) Adding interceptors with the same priority leads to non-deterministic behaviour
[
https://issues.jboss.org/browse/AS7-1042?page=com.atlassian.jira.plugin.s...
]
Carlo de Wolf reassigned AS7-1042:
----------------------------------
Assignee: Carlo de Wolf
Adding interceptors with the same priority leads to non-deterministic
behaviour
-------------------------------------------------------------------------------
Key: AS7-1042
URL: https://issues.jboss.org/browse/AS7-1042
Project: Application Server 7
Issue Type: Bug
Components: EE
Reporter: Carlo de Wolf
Assignee: Carlo de Wolf
Priority: Blocker
Fix For: 7.0.0.CR1
{code:java}
public static final int SINGLETON_CONTAINER_MANAGED_CONCURRENCY_INTERCEPTOR = 0x800;
public static final int USER_INTERCEPTORS = 0x800;
{code}
The order of execution between CONCURRENCY and USER is no longer guaranteed.
The EE framework must detect such a setup and fail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:08 a.m.
New subject: [JBoss JIRA] Commented: (AS7-1042) Adding interceptors with the same priority leads to non-deterministic behaviour
[
https://issues.jboss.org/browse/AS7-1042?page=com.atlassian.jira.plugin.s...
]
Carlo de Wolf commented on AS7-1042:
------------------------------------
This will prove problematic for not only user interceptors, but also instantiators,
injectors and others. Basically on a single priority level one interceptor is allowed,
what happens within (one priority) that interceptor is an implementation detail. User
interceptors need to have a specific order, others like injectors don't. All will use
a weaved interceptor and hide those details.
Adding interceptors with the same priority leads to non-deterministic
behaviour
-------------------------------------------------------------------------------
Key: AS7-1042
URL: https://issues.jboss.org/browse/AS7-1042
Project: Application Server 7
Issue Type: Bug
Components: EE
Reporter: Carlo de Wolf
Assignee: Carlo de Wolf
Priority: Blocker
Fix For: 7.0.0.CR1
{code:java}
public static final int SINGLETON_CONTAINER_MANAGED_CONCURRENCY_INTERCEPTOR = 0x800;
public static final int USER_INTERCEPTORS = 0x800;
{code}
The order of execution between CONCURRENCY and USER is no longer guaranteed.
The EE framework must detect such a setup and fail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:07 p.m.
New subject: [JBoss JIRA] Commented: (AS7-1042) Adding interceptors with the same priority leads to non-deterministic behaviour
[
https://issues.jboss.org/browse/AS7-1042?page=com.atlassian.jira.plugin.s...
]
Stuart Douglas commented on AS7-1042:
-------------------------------------
Interceptor order is completely deterministic.
The sort used by the interceptors is guaranteed to be stable, so the order that user
interceptors are added is the order they are executed, and the code that adds them is
careful to add in the correct order.
Instantiators and injectors should be order agnostic, if there is a need for a specific
ordering it should be expressed via a new entry in the InterceptorOrder class.
In this case someone entering the wrong priority in InterceptorOrder caused a bug, other
that writing a unit test that checks that the values are different via reflection I
don't really see what else you can do.
Adding interceptors with the same priority leads to non-deterministic
behaviour
-------------------------------------------------------------------------------
Key: AS7-1042
URL: https://issues.jboss.org/browse/AS7-1042
Project: Application Server 7
Issue Type: Bug
Components: EE
Reporter: Carlo de Wolf
Assignee: Carlo de Wolf
Priority: Blocker
Fix For: 7.0.0.CR1
{code:java}
public static final int SINGLETON_CONTAINER_MANAGED_CONCURRENCY_INTERCEPTOR = 0x800;
public static final int USER_INTERCEPTORS = 0x800;
{code}
The order of execution between CONCURRENCY and USER is no longer guaranteed.
The EE framework must detect such a setup and fail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:32 a.m.
New subject: [JBoss JIRA] Commented: (AS7-1042) Adding interceptors with the same priority leads to non-deterministic behaviour
[
https://issues.jboss.org/browse/AS7-1042?page=com.atlassian.jira.plugin.s...
]
Carlo de Wolf commented on AS7-1042:
------------------------------------
https://github.com/wolfc/jboss-as/commit/67e569564b390c8c2f0bcce94a61c425...
Adding interceptors with the same priority leads to non-deterministic
behaviour
-------------------------------------------------------------------------------
Key: AS7-1042
URL: https://issues.jboss.org/browse/AS7-1042
Project: Application Server 7
Issue Type: Bug
Components: EE
Reporter: Carlo de Wolf
Assignee: Carlo de Wolf
Priority: Blocker
Fix For: 7.0.0.CR1
{code:java}
public static final int SINGLETON_CONTAINER_MANAGED_CONCURRENCY_INTERCEPTOR = 0x800;
public static final int USER_INTERCEPTORS = 0x800;
{code}
The order of execution between CONCURRENCY and USER is no longer guaranteed.
The EE framework must detect such a setup and fail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5506
days inactive
5509
days old
4 comments
2 participants
participants (2)
-
Carlo de Wolf (JIRA) -
Stuart Douglas (JIRA)