6:02 p.m.
TP.send() creates a new ByteArrayOutputStream for every message
---------------------------------------------------------------
Key: JGRP-517
URL: http://jira.jboss.com/jira/browse/JGRP-517
Project: JGroups
Issue Type: Bug
Reporter: Michael Newcomb
Assigned To: Bela Ban
Every call to TP.send() results in a new ByteArrayOutputStream being created. This creates
a large amount of garbage. Could TP.send() use a pool of ByteArrayOutputStreams or
something to cut down on generated garbage?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:38 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-517) TP.send() creates a new ByteArrayOutputStream for every message
[ http://jira.jboss.com/jira/browse/JGRP-517?page=comments#action_12363267 ]
Bela Ban commented on JGRP-517:
-------------------------------
I had this before, and called reset() on the output stream. However, if we for example
send a larger message (say 60K), then we end up with a 60K buffer allocated even though it
may not be used later on as we're sending smaller messages. Performance wise, both
solutions were the same.
TP.send() creates a new ByteArrayOutputStream for every message
---------------------------------------------------------------
Key: JGRP-517
URL: http://jira.jboss.com/jira/browse/JGRP-517
Project: JGroups
Issue Type: Bug
Reporter: Michael Newcomb
Assigned To: Bela Ban
Every call to TP.send() results in a new ByteArrayOutputStream being created. This
creates a large amount of garbage. Could TP.send() use a pool of ByteArrayOutputStreams or
something to cut down on generated garbage?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:10 p.m.
New subject: [JBoss JIRA] Updated: (JGRP-517) TP.send() creates a new ByteArrayOutputStream for every message
[ http://jira.jboss.com/jira/browse/JGRP-517?page=all ]
Bela Ban updated JGRP-517:
--------------------------
Issue Type: Task (was: Bug)
Fix Version/s: 2.5
TP.send() creates a new ByteArrayOutputStream for every message
---------------------------------------------------------------
Key: JGRP-517
URL: http://jira.jboss.com/jira/browse/JGRP-517
Project: JGroups
Issue Type: Task
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Every call to TP.send() results in a new ByteArrayOutputStream being created. This
creates a large amount of garbage. Could TP.send() use a pool of ByteArrayOutputStreams or
something to cut down on generated garbage?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:12 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-517) TP.send() creates a new ByteArrayOutputStream for every message
[ http://jira.jboss.com/jira/browse/JGRP-517?page=comments#action_12363313 ]
Bela Ban commented on JGRP-517:
-------------------------------
Another down side of reusing the output stream: access to it needs to get synchronized, so
concurrent sends are not possible.
TP.send() creates a new ByteArrayOutputStream for every message
---------------------------------------------------------------
Key: JGRP-517
URL: http://jira.jboss.com/jira/browse/JGRP-517
Project: JGroups
Issue Type: Task
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Every call to TP.send() results in a new ByteArrayOutputStream being created. This
creates a large amount of garbage. Could TP.send() use a pool of ByteArrayOutputStreams or
something to cut down on generated garbage?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:04 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-517) TP.send() creates a new ByteArrayOutputStream for every message
[ http://jira.jboss.com/jira/browse/JGRP-517?page=comments#action_12363369 ]
Michael Newcomb commented on JGRP-517:
--------------------------------------
My application only uses 1 thread to send messages. Perhaps a flag to reuse a common
output stream? Or an option for an output stream pool? The default could be just creating
a new output stream for each message.
TP.send() creates a new ByteArrayOutputStream for every message
---------------------------------------------------------------
Key: JGRP-517
URL: http://jira.jboss.com/jira/browse/JGRP-517
Project: JGroups
Issue Type: Task
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Every call to TP.send() results in a new ByteArrayOutputStream being created. This
creates a large amount of garbage. Could TP.send() use a pool of ByteArrayOutputStreams or
something to cut down on generated garbage?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:29 a.m.
New subject: [JBoss JIRA] Closed: (JGRP-517) TP.send() creates a new ByteArrayOutputStream for every message
[ http://jira.jboss.com/jira/browse/JGRP-517?page=all ]
Bela Ban closed JGRP-517.
-------------------------
Resolution: Rejected
I'm afraid I have to reject this proposal. Adding yey another flag adds to clutter,
and reduces simplicity. I've run tests with a shared output stream (reset for each
message) and the numbers were not better than creating a new output stream for each
message.
Unless you show me a performance gain for reusing an output stream, I'm not going to
implement this.
TP.send() creates a new ByteArrayOutputStream for every message
---------------------------------------------------------------
Key: JGRP-517
URL: http://jira.jboss.com/jira/browse/JGRP-517
Project: JGroups
Issue Type: Task
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Every call to TP.send() results in a new ByteArrayOutputStream being created. This
creates a large amount of garbage. Could TP.send() use a pool of ByteArrayOutputStreams or
something to cut down on generated garbage?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6193
days inactive
6207
days old
5 comments
2 participants
participants (2)
-
Bela Ban (JIRA) -
Michael Newcomb (JIRA)