[ https://jira.jboss.org/browse/JBAS-8559?page=com.atlassian.jira.plugin.sy... ] jaikiran pai commented on JBAS-8559: ------------------------------------ Adding the details on what exactly is required out of this task. The JavaEE 6 spec (section EE.5.17) states that: <quote> A DataSource resource may be defined in a web module, EJB module, application client module, or application deployment descriptor using the datasource element. For example: <data-source> <description>Sample DataSource definition</description> <name>java:app/MyDataSource</name> <class-name>com.foobar.MyDataSource</class-name> <server-name>myserver.com</server-name> <port-number>6689</port-number> <database-name>myDatabase</database-name> <user>lance</user> <password>secret</password> <property> <name>Property1</name> <value>10</value> </property> <property> <name>Property2</name> <value>20</value> </property> <login-timeout>0</login-timeout> <transactional>false</transactional> <isolation-level>TRANSACTION_READ_COMMITTED</isolation-level> <initial-pool-size>0</initial-pool-size> <max-pool-size>30</max-pool-size> <min-pool-size>20</min-pool-size> <max-idle-time>0</max-idle-time> <max-statements>50</max-statements> </data-source> A DataSource resource may also be defined using the DataSourceDefinition annotation on a container-managed class, such as a servlet or enterprise bean class. For example: @DataSourceDefinition(name="java:app/MyDataSource", className="com.foobar.MyDataSource", portNumber=6689, serverName="myserver.com", user="lance", password="secret") (Of course, we do not recommend including passwords to production systems in the code, but it's often useful while testing. Passwords, or other parts of the DataSource definition, can be overridden by a deployment descriptor when the application is deployed.) </quote> So all that needs to be done is to process this Java EE spec defined datasource deployment descriptor element and the corresponding annotation and create a JBoss specific datasource and bind it to JNDI. That's it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8559?page=com.atlassian.jira.plugin.sy... ] Shelly McGowan commented on JBAS-8559: -------------------------------------- There are TCK tests in Web Profile that depend on this: com.sun.ts.tests.ejb30.lite.packaging.war.datasource -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8559?page=com.atlassian.jira.plugin.sy... ] Ales Justin commented on JBAS-8559: ----------------------------------- Useful links: * http://anonsvn.jboss.org/repos/jbossas/projects/metadata/common/trunk/src... * http://anonsvn.jboss.org/repos/jbossas/projects/metadata/common/trunk/src... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8559?page=com.atlassian.jira.plugin.sy... ] jaikiran pai commented on JBAS-8559: ------------------------------------ I'm not really sure which one to use either. But I guess using local-tx as default would be enough for now. If the user wants XA semantics then we can ask them to use JBoss specific -ds.xml files to configure the datasource. Maybe for AS7, we could allow a JBoss specific @DataSourceDefinition which allows a way to configure xa or local-tx (and maybe other JBoss specific attributes). But that isn't a requirement for now. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBAS-8559?page=com.atlassian.jira.plugin.sy... ] Weston M. Price commented on JBAS-8559: --------------------------------------- I have checked in the latest regarding this task. Now we support datasource/connection creation as well as supporting the properties that override a url as defined by the EE spec (ie serveName, dataBaseName etc). The remaining parts of this task include more testing (primarily against the TCK) as well as the ejb meta data creation to allow for datasource inside the ejb-jar.xml descriptor, or deployed as a @DataSourceDefinition annotation. I will discuss with the EJB team in the AM. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/JBAS-8559?page=com.atlassian.jira.plugin.... ] Weston M. Price commented on JBAS-8559: --------------------------------------- Thanks for catching this. The fix has been committed. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira