]
Eduardo Martins updated WFLY-13463:
-----------------------------------
Git Pull Request:
Issues in readme for microprofile-metrics QS
--------------------------------------------
Key: WFLY-13463
URL:
https://issues.redhat.com/browse/WFLY-13463
Project: WildFly
Issue Type: Bug
Components: Quickstarts
Affects Versions: 19.1.0.Final
Reporter: Martin Stefanko
Assignee: Martin Stefanko
Priority: Critical
Fix For: 20.0.0.Beta1
(1) pom.xml changes show WF BOM instead of EAP one:
{code}
<groupId>org.wildfly.bom</groupId>
<artifactId>wildfly-microprofile</artifactId>
<version>${version.server.bom}</version>
where ${version.server.bom} is the version of your JBoss EAP XP, in our case
"1.0".
{code}
Please notice there's no WF BOM of version 1.0.
(2) {{WildFly}} used several times instead of {{JBoss EAP XP}} or simply {{server}},
e.g.:
{code}
<!-- Import the MicroProfile Metrics API, we use provided scope as the API is included
in WildFly -->
{code}
This is also used in pom.xml.
Some sentences use correct product name, e.g.:
{code}
Even without any direct interaction, JBoss EAP XP server already collects and exposes
some metrics.
{code}
(3) I'm not sure if this sentence is correct: {{You can note that there are custom
metrics exposed by the individual JBoss EAP XP subsystems which are prefixed by wildfly_
or jboss_.}} - when accessing the endpoint as documented with EAP XP, I only see
{{jboss_}} prefix, no {{wildfly_}} ones. Please confirm this is correct.
(4) I think there's mistake in {{You can test it be typing for instance
application_org_quickstart_microprofile_metrics_PrimeNumberChecker_performedChecks_total
as the query expression and executing this query.}} There's no such item. Should it be
{{application_org_wildfly_quickstarts_microprofile_metrics_PrimeNumberChecker_performedChecks_total}}?