[
https://issues.jboss.org/browse/AS7-6035?page=com.atlassian.jira.plugin.s...
]
Ivo Studensky commented on AS7-6035:
------------------------------------
I've checked all the suspicious restartRequired() uses and prepared a fix for some of
them. In particular for webservices/* and logging/* . Remaining ones seem to be correct.
The changes to webservices/* have been already reviewed by #ropalka.
There are two other occurrences of restartRequired() on 7.1 branch, see the list below,
which could also be changed to reloadRequired() I believe. I am not sure, however, if such
a change is worth doing on 7.1 branch at the moment as it will need more testing to see it
does not break anything.
{noformat}
org.jboss.as.logging.handlers.file.HandlerFileChange
org.jboss.as.connector.subsystems.datasources.DataSourceDisable
{noformat}
Improper use of OperationContext.restartRequired()
--------------------------------------------------
Key: AS7-6035
URL:
https://issues.jboss.org/browse/AS7-6035
Project: Application Server 7
Issue Type: Bug
Components: Domain Management
Affects Versions: 7.1.3.Final (EAP)
Reporter: Brian Stansberry
Assignee: Ivo Studensky
Fix For: 7.2.0.Alpha1, 7.1.4.Final (EAP)
Look or an fix uses of OperationContext.restartRequired() that should be using
reloadRequired(). There are very few reasons why a full process restart should be needed
for a configuration model change to take effect. Typically a full process restart would
only be needed for a domain mode server whose JVM configuration settings have been changed
in the host model.
Running "git grep restartRequired()" shows the following suspicious uses:
logging/src/main/java/org/jboss/as/logging/HandlerOperations.java:
context.restartRequired();
logging/src/main/java/org/jboss/as/logging/HandlerOperations.java:
context.restartRequired();
server/src/main/java/org/jboss/as/server/operations/ServerRestartRequiredHandler.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/ClientConfigAdd.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/ClientConfigRemove.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/EndpointConfigAdd.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/EndpointConfigRemove.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/HandlerAdd.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/HandlerChainAdd.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/HandlerChainRemove.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/HandlerRemove.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/PropertyAdd.java:
context.restartRequired();
webservices/server-integration/src/main/java/org/jboss/as/webservices/dmr/PropertyRemove.java:
context.restartRequired();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:
http://www.atlassian.com/software/jira