[JBoss JIRA] (JBRULES-3643) Drools Planner score corruption during construction heuristics if there are rules that check if planning variable is null
5:26 p.m.
Reinis Vicups created JBRULES-3643:
--------------------------------------
Summary: Drools Planner score corruption during construction heuristics if
there are rules that check if planning variable is null
Key: JBRULES-3643
URL: https://issues.jboss.org/browse/JBRULES-3643
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-planner
Affects Versions: 5.4.0.Final
Environment: linux 32bit JavaSE 1.6
Reporter: Reinis Vicups
Assignee: Geoffrey De Smet
Priority: Minor
A score corruption occurs in DEBUG environment Mode during construction heuristics if
there are rules that add constraints if planning variable is null e.g.
{code}
rule "no foo without bar"
when
$foo : Foo(bar == null)
then
insertLogical( new IntConstraintOccurrence("foo without bar",
ConstraintType.NEGATIVE_HARD, 1, $foo) );
end
{code}
Debugging show following sympthoms: While
org.drools.planner.core.constructionheuristic.greedyFit.decider.DefaultGreedyDecider
executed doMove() a deviation between undoScore and lastCompletedStepScore occur (around
the 108th line of code):
{code}
...
if (assertUndoMoveIsUncorrupted) {
GreedyFitSolverPhaseScope greedyFitSolverPhaseScope =
moveScope.getGreedyFitStepScope()
.getGreedyFitSolverPhaseScope();
Score undoScore = greedyFitSolverPhaseScope.calculateScore();
Score lastCompletedStepScore =
greedyFitSolverPhaseScope.getLastCompletedStepScope().getScore();
if (!undoScore.equals(lastCompletedStepScore)) { //<-- HERE scores
deviate!
...
{code}
Again, this occurs only in DEBUG environment mode!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 p.m.
[
https://issues.jboss.org/browse/JBRULES-3643?page=com.atlassian.jira.plug...
]
Geoffrey De Smet commented on JBRULES-3643:
-------------------------------------------
Occurs because undoWM and lastStepWM are different: the entity is inserted but not
retracted.
The undoSolution and the lastStepSolution are equal.
Needs to be fixed with the work for the scalable constr heuristics
Drools Planner score corruption during construction heuristics if
there are rules that check if planning variable is null
-------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-3643
URL: https://issues.jboss.org/browse/JBRULES-3643
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.4.0.Final
Environment: linux 32bit JavaSE 1.6
Reporter: Reinis Vicups
Assignee: Geoffrey De Smet
Priority: Minor
A score corruption occurs in DEBUG environment Mode during construction heuristics if
there are rules that add constraints if planning variable is null e.g.
{code}
rule "no foo without bar"
when
$foo : Foo(bar == null)
then
insertLogical( new IntConstraintOccurrence("foo without bar",
ConstraintType.NEGATIVE_HARD, 1, $foo) );
end
{code}
Debugging show following sympthoms: While
org.drools.planner.core.constructionheuristic.greedyFit.decider.DefaultGreedyDecider
executed doMove() a deviation between undoScore and lastCompletedStepScore occur (around
the 108th line of code):
{code}
...
if (assertUndoMoveIsUncorrupted) {
GreedyFitSolverPhaseScope greedyFitSolverPhaseScope =
moveScope.getGreedyFitStepScope()
.getGreedyFitSolverPhaseScope();
Score undoScore = greedyFitSolverPhaseScope.calculateScore();
Score lastCompletedStepScore =
greedyFitSolverPhaseScope.getLastCompletedStepScope().getScore();
if (!undoScore.equals(lastCompletedStepScore)) { //<-- HERE scores
deviate!
...
{code}
Again, this occurs only in DEBUG environment mode!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1 a.m.
[
https://issues.jboss.org/browse/JBRULES-3643?page=com.atlassian.jira.plug...
]
Reinis Vicups updated JBRULES-3643:
-----------------------------------
Workaround Description: As a possible workaround remove rules that check if planning
variable is null. But, since during construction heuristics rules are checked as well,
consider explicitly checking that the planning variables are NOT null e.g. Foo(bar !=
null) or you will get NPEs. (was: As a possible workaround remove rules that check if
planning variable is null. Normaly planning variables should be initialized during the
solution initialization and need not to be checked against null.)
Drools Planner score corruption during construction heuristics if
there are rules that check if planning variable is null
-------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-3643
URL: https://issues.jboss.org/browse/JBRULES-3643
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.4.0.Final
Environment: linux 32bit JavaSE 1.6
Reporter: Reinis Vicups
Assignee: Geoffrey De Smet
Priority: Minor
A score corruption occurs in DEBUG environment Mode during construction heuristics if
there are rules that add constraints if planning variable is null e.g.
{code}
rule "no foo without bar"
when
$foo : Foo(bar == null)
then
insertLogical( new IntConstraintOccurrence("foo without bar",
ConstraintType.NEGATIVE_HARD, 1, $foo) );
end
{code}
Debugging show following sympthoms: While
org.drools.planner.core.constructionheuristic.greedyFit.decider.DefaultGreedyDecider
executed doMove() a deviation between undoScore and lastCompletedStepScore occur (around
the 108th line of code):
{code}
...
if (assertUndoMoveIsUncorrupted) {
GreedyFitSolverPhaseScope greedyFitSolverPhaseScope =
moveScope.getGreedyFitStepScope()
.getGreedyFitSolverPhaseScope();
Score undoScore = greedyFitSolverPhaseScope.calculateScore();
Score lastCompletedStepScore =
greedyFitSolverPhaseScope.getLastCompletedStepScope().getScore();
if (!undoScore.equals(lastCompletedStepScore)) { //<-- HERE scores
deviate!
...
{code}
Again, this occurs only in DEBUG environment mode!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:34 a.m.
[
https://issues.jboss.org/browse/JBRULES-3643?page=com.atlassian.jira.plug...
]
Reinis Vicups updated JBRULES-3643:
-----------------------------------
Workaround Description: No known workarounds, this issue causes unpredictable results.
(was: As a possible workaround remove rules that check if planning variable is null. But,
since during construction heuristics rules are checked as well, consider explicitly
checking that the planning variables are NOT null e.g. Foo(bar != null) or you will get
NPEs.)
Drools Planner score corruption during construction heuristics if
there are rules that check if planning variable is null
-------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-3643
URL: https://issues.jboss.org/browse/JBRULES-3643
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.4.0.Final
Environment: linux 32bit JavaSE 1.6
Reporter: Reinis Vicups
Assignee: Geoffrey De Smet
Priority: Minor
A score corruption occurs in DEBUG environment Mode during construction heuristics if
there are rules that add constraints if planning variable is null e.g.
{code}
rule "no foo without bar"
when
$foo : Foo(bar == null)
then
insertLogical( new IntConstraintOccurrence("foo without bar",
ConstraintType.NEGATIVE_HARD, 1, $foo) );
end
{code}
Debugging show following sympthoms: While
org.drools.planner.core.constructionheuristic.greedyFit.decider.DefaultGreedyDecider
executed doMove() a deviation between undoScore and lastCompletedStepScore occur (around
the 108th line of code):
{code}
...
if (assertUndoMoveIsUncorrupted) {
GreedyFitSolverPhaseScope greedyFitSolverPhaseScope =
moveScope.getGreedyFitStepScope()
.getGreedyFitSolverPhaseScope();
Score undoScore = greedyFitSolverPhaseScope.calculateScore();
Score lastCompletedStepScore =
greedyFitSolverPhaseScope.getLastCompletedStepScope().getScore();
if (!undoScore.equals(lastCompletedStepScore)) { //<-- HERE scores
deviate!
...
{code}
Again, this occurs only in DEBUG environment mode!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:34 a.m.
[
https://issues.jboss.org/browse/JBRULES-3643?page=com.atlassian.jira.plug...
]
Reinis Vicups updated JBRULES-3643:
-----------------------------------
Priority: Major (was: Minor)
Drools Planner score corruption during construction heuristics if
there are rules that check if planning variable is null
-------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-3643
URL: https://issues.jboss.org/browse/JBRULES-3643
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.4.0.Final
Environment: linux 32bit JavaSE 1.6
Reporter: Reinis Vicups
Assignee: Geoffrey De Smet
A score corruption occurs in DEBUG environment Mode during construction heuristics if
there are rules that add constraints if planning variable is null e.g.
{code}
rule "no foo without bar"
when
$foo : Foo(bar == null)
then
insertLogical( new IntConstraintOccurrence("foo without bar",
ConstraintType.NEGATIVE_HARD, 1, $foo) );
end
{code}
Debugging show following sympthoms: While
org.drools.planner.core.constructionheuristic.greedyFit.decider.DefaultGreedyDecider
executed doMove() a deviation between undoScore and lastCompletedStepScore occur (around
the 108th line of code):
{code}
...
if (assertUndoMoveIsUncorrupted) {
GreedyFitSolverPhaseScope greedyFitSolverPhaseScope =
moveScope.getGreedyFitStepScope()
.getGreedyFitSolverPhaseScope();
Score undoScore = greedyFitSolverPhaseScope.calculateScore();
Score lastCompletedStepScore =
greedyFitSolverPhaseScope.getLastCompletedStepScope().getScore();
if (!undoScore.equals(lastCompletedStepScore)) { //<-- HERE scores
deviate!
...
{code}
Again, this occurs only in DEBUG environment mode!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:38 a.m.
[
https://issues.jboss.org/browse/JBRULES-3643?page=com.atlassian.jira.plug...
]
Reinis Vicups commented on JBRULES-3643:
----------------------------------------
This issue seriously limits usage of drools rule engine for planner. Except for couple of
primitive rules, a real-life examples are failing with this error 100% of time.
Drools Planner score corruption during construction heuristics if
there are rules that check if planning variable is null
-------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-3643
URL: https://issues.jboss.org/browse/JBRULES-3643
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.4.0.Final
Environment: linux 32bit JavaSE 1.6
Reporter: Reinis Vicups
Assignee: Geoffrey De Smet
A score corruption occurs in DEBUG environment Mode during construction heuristics if
there are rules that add constraints if planning variable is null e.g.
{code}
rule "no foo without bar"
when
$foo : Foo(bar == null)
then
insertLogical( new IntConstraintOccurrence("foo without bar",
ConstraintType.NEGATIVE_HARD, 1, $foo) );
end
{code}
Debugging show following sympthoms: While
org.drools.planner.core.constructionheuristic.greedyFit.decider.DefaultGreedyDecider
executed doMove() a deviation between undoScore and lastCompletedStepScore occur (around
the 108th line of code):
{code}
...
if (assertUndoMoveIsUncorrupted) {
GreedyFitSolverPhaseScope greedyFitSolverPhaseScope =
moveScope.getGreedyFitStepScope()
.getGreedyFitSolverPhaseScope();
Score undoScore = greedyFitSolverPhaseScope.calculateScore();
Score lastCompletedStepScore =
greedyFitSolverPhaseScope.getLastCompletedStepScope().getScore();
if (!undoScore.equals(lastCompletedStepScore)) { //<-- HERE scores
deviate!
...
{code}
Again, this occurs only in DEBUG environment mode!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:11 a.m.
[
https://issues.jboss.org/browse/JBRULES-3643?page=com.atlassian.jira.plug...
]
Reinis Vicups updated JBRULES-3643:
-----------------------------------
Git Pull Request: https://github.com/droolsjbpm/drools-planner/pull/12 (was:
https://github.com/droolsjbpm/drools-planner/pull/12)
Affects Version/s: 5.5.0.Beta1
Workaround: (was: Workaround Exists)
Drools Planner score corruption during construction heuristics if
there are rules that check if planning variable is null
-------------------------------------------------------------------------------------------------------------------------
Key: JBRULES-3643
URL: https://issues.jboss.org/browse/JBRULES-3643
Project: Drools
Issue Type: Bug
Security Level: Public(Everyone can see)
Components: drools-planner
Affects Versions: 5.4.0.Final, 5.5.0.Beta1
Environment: linux 32bit JavaSE 1.6
Reporter: Reinis Vicups
Assignee: Geoffrey De Smet
A score corruption occurs in DEBUG environment Mode during construction heuristics if
there are rules that add constraints if planning variable is null e.g.
{code}
rule "no foo without bar"
when
$foo : Foo(bar == null)
then
insertLogical( new IntConstraintOccurrence("foo without bar",
ConstraintType.NEGATIVE_HARD, 1, $foo) );
end
{code}
Debugging show following sympthoms: While
org.drools.planner.core.constructionheuristic.greedyFit.decider.DefaultGreedyDecider
executed doMove() a deviation between undoScore and lastCompletedStepScore occur (around
the 108th line of code):
{code}
...
if (assertUndoMoveIsUncorrupted) {
GreedyFitSolverPhaseScope greedyFitSolverPhaseScope =
moveScope.getGreedyFitStepScope()
.getGreedyFitSolverPhaseScope();
Score undoScore = greedyFitSolverPhaseScope.calculateScore();
Score lastCompletedStepScore =
greedyFitSolverPhaseScope.getLastCompletedStepScope().getScore();
if (!undoScore.equals(lastCompletedStepScore)) { //<-- HERE scores
deviate!
...
{code}
Again, this occurs only in DEBUG environment mode!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4218
days inactive
4221
days old
6 comments
2 participants
participants (2)
-
Geoffrey De Smet (JIRA) -
Reinis Vicups (JIRA)