5:22 p.m.
David Hotham created JGRP-1443:
----------------------------------
Summary: Null pointer exception testing proposed fix for JGRP-1426
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:42 p.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1443:
---------------------------
Fix Version/s: 3.0.9
3.1
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:52 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1443:
--------------------------------
I assume you don't have a simple test to reproduce this ?
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:20 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
David Hotham commented on JGRP-1443:
------------------------------------
Depends what you call simple!
A slight variation on the stress test attached to JGRP-1426 typically reproduces this in a
small number of hours. (To achieve this you'll also want the proposed fix for
JGRP-1426; else you're liable to hit that issue first). Let me know if you'd like
me to attach the current version of that test.
I don't have anything easier than that, though.
If you have a proposed fix that you'd like me to run with, I'd be happy to do so;
likewise if you have some extra diagnostics that you want to get.
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1443:
---------------------------
Attachment: jgroups-3.0.9.Final.jar
Try this version
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:55 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1443:
--------------------------------
The marshalling fix basically prevents the NPE, but we can end up with a view that's
greater than the digest. Should investigate some day, but this is exactly the way it was
before when we marshalled the view and digest separately. It was OK then, so I suppose it
is OK now...
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:57 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
David Hotham commented on JGRP-1443:
------------------------------------
Thanks. I should be able to set this up tomorrow and - if all is well - confirm as much
after running for a few hours without problems.
Couple of questions:
- does this version include the proposed JGRP-1426 fix? If not then, as above, I'm
likely to hit that before getting near JGRP-1443.
- I've been testing with 3.1.0 versions, rather than 3.0.x. I don't suppose it
really matters; but perhaps it would be cleaner to continue to do so?
David
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:01 p.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1443:
--------------------------------
- No, this doesn't fix JGRP1426
- I also fixed this on master, just grab a copy off of github
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:33 p.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
David Hotham commented on JGRP-1443:
------------------------------------
I don't think you did fix this on master, did you?
No matter; I've found the branch with the fix. Just so we're clear about what
I'm testing, I have:
- started with [this|https://github.com/vblagoje/JGroups/commits/t_1426_m] branch
- applied
[this|https://github.com/belaban/JGroups/commit/e9239c55ad084f15cd86f3d275...]
patch
I've kicked the test off. If it's still going in the morning, that'll be very
encouraging.
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:21 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1443:
--------------------------------
Ah, yes, the changes are on branch JGRP-1443 (off of master). I haven't merged yet;
I'll do that when the changes fix your problem.
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:54 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
David Hotham commented on JGRP-1443:
------------------------------------
Still hitting problems, I'm afraid...
Just to remind you of my testcase:
- I have a group with three ever-present members A, B, C
- members D and E take it in turns to try and join the group, wait for the view to
settle, and be killed
- everyone broadcasts a message every few seconds
The NPE reported here was hit by one of the ever-presents.
When I came in this morning, I found that member E was using all of the CPU on one of my
cores (and had failed to join the group). Presumably some thread is tight-looping.
Sadly, jstack / jconsole etc (I'm on Windows) were unable to attach to the process so
I haven't been able to get any more useful insight into where the problem is.
I suppose we have one of:
- something about the fix you've made on the ever-presents causes the joiner to tight
loop
- a new problem
Can you please advise?
- would you like to track this issue under a new ticket, or do you think it's likely
to be all part of the same thing?
- what trace would be useful?
Thanks!
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:03 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1443:
--------------------------------
OK, then I'll have to go back to the drawing board and make sure a JoinRsp has the
same view and digest. The NPE was caused by a view greater than the digest, e.g. {A,B,C,D}
and the digest being {A,B,C}.
The NPE should nto occur anymore though, does it still occur ? If so, can you post the
stack trace again ?
Re: the new issue you ran into. Let's not open a new JIRA if this is a consequence of
(root cause) JGRP-1443. If the new issue is completely separate, open a new issue.
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:35 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
David Hotham commented on JGRP-1443:
------------------------------------
I confirm that I'm no longer hitting the NPE.
To try and figure out whether the tight loop issue is all part of the same thing or not, I
added some trace to your fix so that I would be able to see when we went through it. And
sure enough, just before getting stuck, we ran through the new code.
So I'm pretty convinced that we should tracking this all under the same JIRA; it does
indeed look as though it's something about the new fix that triggers the tight loop.
If there's anything I can do to help eg test fixes or gather trace, please just ask.
David
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.0.9, 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:15 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban updated JGRP-1443:
---------------------------
Fix Version/s: (was: 3.0.9)
No need to fix this in 3.0.9, as JGRP-1426 is assigned to 3.1 only
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:41 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban resolved JGRP-1443.
----------------------------
Resolution: Done
I'm closing this issue, let's continue the discussion of the original problem on
JGRP-1426, or open a new issue
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:40 p.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
David Hotham reopened JGRP-1443:
--------------------------------
Per remarks in JGRP-1426, I've hit this NPE:
- with and without the 1426 fix
- with and without FLUSH being in the stack
So I'm reopening it: I think we should view it as an independent bug.
I'm currently using 3.1.0.Beta1, with a stack that goes:
TCP
TCPPING
MERGE3
FD_SOCK
FD
NACKACK2
UNICAST2
STABLE
SEQUENCER
GMS
UFC
MFC
FRAG2
I don't have a test script that reproduces this without FLUSH being in the stack.
However I am able to hit it live reasonably reliably, by having a cluster of four members
and killing two of them (not the coordinator) as close together as I can.
I can try to work on a scripted repro if necessary. Let me know if you need me to do
that.
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.1
Attachments: jgroups-3.0.9.Final.jar
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:29 p.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
David Hotham updated JGRP-1443:
-------------------------------
Attachment: test.zip
Attaching a stress test that typically produces NPE in a small number of minutes when I
run it.
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.1
Attachments: jgroups-3.0.9.Final.jar, test.zip
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:15 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban commented on JGRP-1443:
--------------------------------
I haven't merged this onto master yet. Can you confirm you're running the right
code ?
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.1
Attachments: jgroups-3.0.9.Final.jar, test.zip
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:40 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
David Hotham commented on JGRP-1443:
------------------------------------
I'm using the released 3.1.0.Beta1. Seeing as how you'd closed this issue, I
assumed that you didn't intend to make any fix for it! If that's wrong, I'm
happy to retest with a version that does include a fix.
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.1
Attachments: jgroups-3.0.9.Final.jar, test.zip
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:34 a.m.
[
https://issues.jboss.org/browse/JGRP-1443?page=com.atlassian.jira.plugin....
]
Bela Ban resolved JGRP-1443.
----------------------------
Resolution: Done
Null pointer exception testing proposed fix for JGRP-1426
---------------------------------------------------------
Key: JGRP-1443
URL: https://issues.jboss.org/browse/JGRP-1443
Project: JGroups
Issue Type: Bug
Affects Versions: 3.0.8
Reporter: David Hotham
Assignee: Bela Ban
Fix For: 3.1
Attachments: jgroups-3.0.9.Final.jar, test.zip
Per email exchange: testing a proposed fix for JGRP-1426, I hit the following exception:
SEVERE: failed sending message to 10.239.0.5 (185 bytes):
java.lang.NullPointerException, cause: null
java.lang.NullPointerException
at org.jgroups.protocols.pbcast.JoinRsp.writeTo(JoinRsp.java:90)
at org.jgroups.util.Util.writeStreamable(Util.java:934)
at org.jgroups.protocols.pbcast.GMS$GmsHeader.writeTo(GMS.java:1155)
at org.jgroups.Message.writeHeader(Message.java:891)
at org.jgroups.Message.writeTo(Message.java:698)
at org.jgroups.protocols.TP.writeMessage(TP.java:1367)
at org.jgroups.protocols.TP.send(TP.java:1279)
at org.jgroups.protocols.TP.down(TP.java:1138)
at org.jgroups.protocols.Discovery.down(Discovery.java:573)
at org.jgroups.protocols.TCPPING.down(TCPPING.java:108)
at org.jgroups.protocols.MERGE3.down(MERGE3.java:242)
at org.jgroups.protocols.FD.down(FD.java:308)
at org.jgroups.protocols.VERIFY_SUSPECT.down(VERIFY_SUSPECT.java:80)
at org.jgroups.protocols.pbcast.NAKACK2.down(NAKACK2.java:493)
at org.jgroups.protocols.UNICAST2.down(UNICAST2.java:502)
at org.jgroups.protocols.pbcast.STABLE.down(STABLE.java:328)
at org.jgroups.protocols.pbcast.GMS.sendJoinResponse(GMS.java:543)
at
org.jgroups.protocols.pbcast.CoordGmsImpl.handleMembershipChange(CoordGmsImpl.java:156)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.process(GMS.java:1390)
at org.jgroups.protocols.pbcast.GMS$ViewHandler.run(GMS.java:1344)
at java.lang.Thread.run(Thread.java:662)
You said:
{quote}
ah, ok, this is a change I made recently, to reduce the size of digests.
Can you open a JIRA so we can track this ?
I'll fix it this week.
{quote}
... so here we are.
Thanks!
David
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5208
days inactive
5234
days old
19 comments
2 participants
participants (2)
-
Bela Ban (JIRA) -
David Hotham (JIRA)