[JBoss JIRA] (DROOLS-1087) KieBase update wrong match for rules containing constraints over the accumulate
12:15 p.m.
[
https://issues.jboss.org/browse/DROOLS-1087?page=com.atlassian.jira.plugi...
]
Mario Fusco resolved DROOLS-1087.
---------------------------------
Resolution: Rejected
To recap, the problem you're reporting (at least for 6.4) is that the accumulate rule
refires after incremental compilation even if you don't expect this. I demonstrated
this behaviour in a simplified way with the following test case.
{code}
@Test
public void testAccumulate() throws Exception {
// DROOLS-1087
String drl1 =
"rule R1 when\n" +
" accumulate ( $s: String(); $n : count($s); $n > 0 )\n"
+
"then\n" +
" System.out.println(\"HERE\");\n" +
"end\n";
String drl2 = drl1 + " "; // just a trivial update
KieServices ks = KieServices.Factory.get();
ReleaseId releaseId1 = ks.newReleaseId( "org.kie",
"test-upgrade", "1.0.0" );
KieModule km = createAndDeployJar( ks, releaseId1, drl1 );
KieContainer kc = ks.newKieContainer( km.getReleaseId() );
KieSession ksession = kc.newKieSession();
ksession.insert( "Hello World" );
assertEquals( 1, ksession.fireAllRules() );
ReleaseId releaseId2 = ks.newReleaseId( "org.kie",
"test-upgrade", "1.1.0" );
km = createAndDeployJar( ks, releaseId2, drl2 );
kc.updateToVersion( releaseId2 );
assertEquals( 0, ksession.fireAllRules() ); // this assertion fails
}
{code}
The problem here is that drools incremental compilation works at resources level. This
means that when a resource is changed all artifacts created from that resource are removed
from the KieBase and recreated. The accumulate rule then behaves like a brand new rule
that has been just added to the KieBase and since the conditions to make it fire for the
first time are met there's no reason why it shouldn't.
One final note on the no-loop attribute. The only purpose of this attribute is avoiding
that the execution of a rule's consequence could re-activate the rule itself. Since
the consequences of your rules just prints on the standard output there's no chance
that this could happen, so using the no-loop in this context is totally irrelevant.
KieBase update wrong match for rules containing constraints over the
accumulate
-------------------------------------------------------------------------------
Key: DROOLS-1087
URL: https://issues.jboss.org/browse/DROOLS-1087
Project: Drools
Issue Type: Bug
Components: core engine
Affects Versions: 6.2.0.Final, 6.3.0.Final, 6.4.0.Beta2
Reporter: Matteo Mortari
Assignee: Mario Fusco
Attachments: 20160309.DROOLS-1087.zip
Ciao, I will attach reproducer with same style as
{{org.drools.compiler.integrationtests.IncrementalCompilationTest.testIncrementalCompilation}}
/ {{testIncrementalCompilationWithRedeclares}}
h2. Executive summary
When performing KieBase update, rules containing constraints over the accumulate Event,
are firing with wrong matches and/or firing for already seen matches and violating the
no-loop.
h2. Detailed description of the reproducer.
Assume a KB starting with only these two rules:
{code}
declare Measurement
@role(event)
end
rule "color RED seen in the last 2 minutes"
no-loop
when
accumulate ( $token: Measurement( id == "color", $colorVal : val, $colorVal ==
"red") over window:time(2m);
$mySet : collectSet( $colorVal ),
$val : count($token) ;
$val >= 1
)
then
System.out.println("I have seen color RED in the last 2m "+$mySet);
end
rule "color GREEN seen in the last 2 minutes"
no-loop
when
accumulate ( $token: Measurement( id == "color", $colorVal : val, $colorVal ==
"green") over window:time(2m);
$mySet : collectSet( $colorVal ),
$val : count($token) ;
$val >= 1
)
then
System.out.println("I have seen color GREEN in the last 2m "+$mySet);
end
{code}
and then on upgrade/update, the same rule as above un-touched, but additionally the
following rule:
{code}
rule "id X seen in the last 2 minutes"
no-loop
when
accumulate ( $token: Measurement( id == "x", $colorVal : val) over
window:time(2m);
$mySet : collectSet( $colorVal ),
$val : count($token) ;
$val >= 1
)
then
System.out.println("I have seen Measurement for id=x in the last 2m
"+$mySet);
end
{code}
Where {{Measurement}} just a POJO as per Kie Artifact, basically containing fields:
{{String id;String val;}}
with the following of Measurement insertions, one at each minute:
{code}
-> Measurement [id=color, val=red]
(KB update here)
-> Measurement [id=x, val=x]
-> Measurement [id=color, val=green]
...
{code}
the following problems are highlighted:
h6. Drools version 6.2.0.Final with Reteoo
The problem is highlighted after the 2nd Measurment event insertion below, the rules
"color GREEN seen in the last 2 minutes" and "id X seen in the last 2
minutes" are firing with wrong matches, because:
* the rule "color GREEN seen in the last 2 minutes" should fire only for
{{Measurement\[id=color, val=green]}} Events, which has not occured, and is matching
instead over {{Measurement\[id=color, val=red]}}
* the rule "id X seen in the last 2 minutes" should fire only for
{{Measurement\[id=x, _]}} Events, but is considering also the {{Measurement\[id=color,
_]}} event which occured earlier.
{code}
2016-03-09 09:33:20,952 INFO [org.drools.compiler.kie.builder.impl.KieRepositoryImpl]
(main) KieModule was added: MemoryKieModule[releaseId=org.test:test:1.0.0]
2016-03-09 09:33:21,240 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) There
should be rules:
2016-03-09 09:33:21,240 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule color RED seen in the last 2 minutes
2016-03-09 09:33:21,240 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule color GREEN seen in the last 2 minutes
2016-03-09 09:33:21,240 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) Creating
kieSession
2016-03-09 09:33:21,319 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) Now
running data
2016-03-09 09:33:21,321 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) advance
clock @ 60000
-> Measurement [id=color, val=red]
I have seen color RED in the last 2m [red]
2016-03-09 09:33:21,539 INFO [org.drools.compiler.kie.builder.impl.KieRepositoryImpl]
(main) KieModule was added: MemoryKieModule[releaseId=org.test:test:1.0.1]
2016-03-09 09:33:21,743 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) Update of
KB performed.
2016-03-09 09:33:21,744 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule color RED seen in the last 2 minutes
2016-03-09 09:33:21,744 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule color GREEN seen in the last 2 minutes
2016-03-09 09:33:21,744 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule id X seen in the last 2 minutes
2016-03-09 09:33:21,744 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) advance
clock @ 120000
-> Measurement [id=x, val=x]
I have seen Measurement for id=x in the last 2m [red, x]
I have seen color GREEN in the last 2m [red]
I have seen color RED in the last 2m [red]
2016-03-09 09:33:21,750 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) advance
clock @ 180000
<- Measurement [id=color, val=red]
-> Measurement [id=color, val=green]
I have seen color GREEN in the last 2m [green]
I have seen Measurement for id=x in the last 2m [x]
2016-03-09 09:33:21,752 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) advance
clock @ 240000
<- Measurement [id=x, val=x]
-> Measurement [id=color, val=blue]
2016-03-09 09:33:21,752 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) Final
checks
{code}
h6. Drools version 6.2.0.Final with Phreak
NPE
{code}
java.lang.NullPointerException
at org.drools.core.reteoo.NodeTypeEnums.isBetaNode(NodeTypeEnums.java:87)
at org.drools.core.phreak.RuleNetworkEvaluator.innerEval(RuleNetworkEvaluator.java:252)
at org.drools.core.phreak.RuleNetworkEvaluator.outerEval(RuleNetworkEvaluator.java:161)
at
org.drools.core.phreak.RuleNetworkEvaluator.evaluateNetwork(RuleNetworkEvaluator.java:116)
at org.drools.core.phreak.RuleExecutor.evaluateNetwork(RuleExecutor.java:92)
at org.drools.core.common.DefaultAgenda.evaluateEagerList(DefaultAgenda.java:1044)
at org.drools.core.common.DefaultAgenda.fireNextItem(DefaultAgenda.java:996)
at org.drools.core.common.DefaultAgenda.fireAllRules(DefaultAgenda.java:1302)
at
org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:1289)
at
org.drools.core.impl.StatefulKnowledgeSessionImpl.fireAllRules(StatefulKnowledgeSessionImpl.java:1262)
at com.acme.accumulateUpgradeTest.RuleTest.test(RuleTest.java:185)
{code}
h6. Drools version 6.3.0.Final with Reteoo
Not in scope of this JIRA record. I think this release had a bug when running with the
setup of this reproducer because if I try I get NPE at
{{org.drools.core.RuleBaseConfiguration.configureReteComponentFactory()}}
h6. Drools version 6.3.0.Final with Phreak
Same NPE as "6.2.0.Final with Phreak"
h6. Drools version 6.4.0.Beta2 with Reteoo
Same problem as "6.2.0.Final with Reteoo"
h6. Drools version 6.4.0.Beta2 with Phreak
Better, but I'm not sure why rule "color RED seen in the last 2 minutes" is
firing again after the rule-update, it is no-loop and the conditions of the rules are the
same as before the rule-update, hence I'm not sure why it fired again.
{code}
2016-03-09 09:45:25,301 INFO [org.drools.compiler.kie.builder.impl.KieRepositoryImpl]
(main) KieModule was added: MemoryKieModule[releaseId=org.test:test:1.0.0]
2016-03-09 09:45:25,594 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) There
should be rules:
2016-03-09 09:45:25,594 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule color RED seen in the last 2 minutes
2016-03-09 09:45:25,594 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule color GREEN seen in the last 2 minutes
2016-03-09 09:45:25,594 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) Creating
kieSession
2016-03-09 09:45:25,696 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) Now
running data
2016-03-09 09:45:25,698 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) advance
clock @ 60000
-> Measurement [id=color, val=red]
I have seen color RED in the last 2m [red]
2016-03-09 09:45:25,854 INFO [org.drools.compiler.kie.builder.impl.KieRepositoryImpl]
(main) KieModule was added: MemoryKieModule[releaseId=org.test:test:1.0.1]
2016-03-09 09:45:26,023 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) Update of
KB performed.
2016-03-09 09:45:26,023 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule color RED seen in the last 2 minutes
2016-03-09 09:45:26,023 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule color GREEN seen in the last 2 minutes
2016-03-09 09:45:26,023 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) kp
[Package name=com.acme.accumulateUpgradeTest] rule id X seen in the last 2 minutes
2016-03-09 09:45:26,023 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) advance
clock @ 120000
-> Measurement [id=x, val=x]
I have seen color RED in the last 2m [red]
I have seen Measurement for id=x in the last 2m [x]
2016-03-09 09:45:26,029 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) advance
clock @ 180000
-> Measurement [id=color, val=green]
<- Measurement [id=color, val=red]
I have seen color GREEN in the last 2m [green]
2016-03-09 09:45:26,033 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) advance
clock @ 240000
-> Measurement [id=color, val=blue]
<- Measurement [id=x, val=x]
2016-03-09 09:45:26,033 INFO [com.acme.accumulateUpgradeTest.RuleTest] (main) Final
checks
{code}
h2. Final note.
Please notice in the reproducer I've used {{setSourcePath}} to ".txt"
because I'm aliging with the Drool's JUnit tests:
https://github.com/droolsjbpm/drools/blob/master/drools-compiler/src/test...
However changing {{setSourcePath}} to ".drl" would NOT solve the problem, at
least for the rule "id X seen in the last 2 minutes".
Can you kindly advise, please?
Thank you
Ciao,
MM
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
3765
days inactive
3765
days old
0 comments
1 participants
participants (1)
-
Mario Fusco (JIRA)