[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Brian Stansberry updated JBAS-7563: ----------------------------------- Description: UnifiedInvoker has been the default legacy invoker since 4.2; JRMP is legacy of legacy. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Brian Stansberry updated JBAS-7563: ----------------------------------- Fix Version/s: JBossAS-6.0.0.M4 (was: JBossAS-6.0.0.M3) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow commented on JBAS-7563: ------------------------------------ Brian, Lets coordinate our actions between JBAS-7563 & JBAS-7831, as there is some overlap. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow commented on JBAS-7563: ------------------------------------ Do we need to remove JRMPInvokerProxyHA JRMPInvokerProxy? I assume yes but wanted to see if others agree. Class JRMPInvoker has the following method which tells me that we do want to remove the proxies for JRMPInvoker: protected Invoker createDelegateInvoker() { return new JRMPInvokerProxy(this); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow commented on JBAS-7563: ------------------------------------ ConnectionFactoryBindingService looks too cool to delete :-) Maybe we should create a separate jira for porting that to use remoting instead of JMX based connector. Or if there is a need for using JMX, use our JSR-160 support. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow commented on JBAS-7563: ------------------------------------ Hmm, not sure about ClientUserTransactionService, either kill it or update it to use a different connector and not use of JRMPProxyFactory. At least it looks like it uses JRMPProxyFactory from the comments. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow commented on JBAS-7563: ------------------------------------ ClientUserTransactionService could be integrated into IIOP, but what do we want for our remaining non-IIOP invokers? related comment in transaction-service.xml: "UserTransaction support. Will be replaced by the DTM once the DTM is made to play nice with JBossTS. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow commented on JBAS-7563: ------------------------------------ I meant the WrapperDataSourceService and not the ConnectionFactoryBindingService. :) Maybe we should create a separate jira for porting that to use remoting instead of JMX based connector. Or if there is a need for using JMX, use our JSR-160 support. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Brian Stansberry commented on JBAS-7563: ---------------------------------------- <bstansberry> smarlow: is that tied to JRMP? or just to Invoker? <bstansberry> smarlow: i.e. i suspect UnifiedInvoker is fine <bstansberry> yeah, it takes a property named "JMXInvokerName" where "JMXInvoker" means a legacy detached invoker that calls through the JMX bus <bstansberry> UnifiedInvoker meets the requirements <smarlow> well, it uses the Invoker interface but the comment mentions creating a JRMPInvokerProxy <bstansberry> where? <smarlow> around line 273 <smarlow> bstansberry: line 273 of WrapperDataSourceService.java <bstansberry> smarlow: ok, but it actually calls into GenericProxyFactory, which can create a proxy that can deal with any legacy detached invoker <bstansberry> a lot of code comments are from the early days when JRMP was the only detached invoker <smarlow> bstansberry: okay, so we should be good just updating the comment <bstansberry> yes -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Brian Stansberry commented on JBAS-7563: ---------------------------------------- The testsuite has a target "jrmp-invoker-tests" that can go. It creates a server config using the contents of src/resources/tests-configs/jrmp-invoker; that dir can also go. That target basically replaces standardjboss.xml with one that uses JRMPInvoker for everything and then re-runs some EJB2 tests. That and the test stuff in your patch should be the bulk of the JRMPInvoker usage in the testsuite; may be some odd thing elsewhere. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Brian Stansberry commented on JBAS-7563: ---------------------------------------- Those patternsets can be removed; they are only used by the jrmp-invoker-tests target. The same tests get run w/ unified invoker as part of the various other targets (since it's the default invoker), so nothing needs to be added to get coverage with unified invoker. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow updated JBAS-7563: ------------------------------- Attachment: (was: kill_jrmpInvoker.patch) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow commented on JBAS-7563: ------------------------------------ Nice, passed smoke tests and also passed tests-clustering-non-http Giving tests-clustering a shot and will checkin if that passes. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBAS-7563?page=com.atlassian.jira.plug... ] Scott Marlow commented on JBAS-7563: ------------------------------------ testsuite/src/resources/invokers/service-inf/jboss-service.xml uses org.jboss.invocation.jrmp.server.JRMPInvoker. There are unit tests that depend on jboss:service=invoker,type=jrmp,socketType=CompressionSocketFactory, which depends on the above reference to JRMPInvoker. I wonder if we could switch to using UnifiedInvoker instead of JRMPInvoker. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira