[ http://jira.jboss.com/jira/browse/GPD-77?page=all ] John Ruud updated GPD-77: ------------------------- Component/s: jpdl JBoss Forum Reference: http://www.jboss.org/index.html?module=bb&op=viewtopic&t=108175 Affects Version/s: jBPM JPDL Designer 3.1.0.alpha4 Complexity: Low -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/GPD-77?page=all ] John Ruud updated GPD-77: ------------------------- Attachment: GPD-77.patch Included a patch, while the JBoss "contributor agreement" web site seems to be having some problems right now. I'll let you know once I'm officially added as a contributor -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/GPD-77?page=all ] Koen Aers updated GPD-77: ------------------------- Fix Version/s: jBPM JPDL Designer 3.1.0.beta2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/GPD-77?page=comments#action_12371105 ] John Ruud commented on GPD-77: ------------------------------ Koen, Moving the initialize() call to SemanticElementFactory doesn't seem to work for me, for the following reason: While initialize() is correctly being invoked when dropping something from my palettte: Decide(AbstractDecide).initialize() line: 21 SemanticElementFactory.createById(String) line: 30 CreationFactory.getNewObject() line: 34 CreateRequest.getNewObject() line: 73 ... it is also invoked as part of reading the diagram (which is not good as it will reset properties that potentially have been modified): Decide(AbstractDecide).initialize() line: 21 SemanticElementFactory.createById(String) line: 30 ProcessDefinitionDomAdapter(XmlAdapter).createSemanticElementFor(XmlAdapter) line: 476 ProcessDefinitionDomAdapter.doModelAdd(XmlAdapter) line: 157 ProcessDefinitionDomAdapter(XmlAdapter).initialize(SemanticElement) line: 462 ProcessDefinitionDomAdapter.initialize(SemanticElement) line: 94 XpdlEditor(Editor).getSemanticElement(StructuredTextEditor) line: 163 XpdlEditor(Editor).initSourcePage() line: 145 XpdlEditor(Editor).createPages() line: 84 XpdlEditor(JpdlEditor).createPages() line: 134 XpdlEditor(MultiPageEditorPart).createPartControl(Composite) line: 276 EditorReference.createPartHelper() line: 596 EditorReference.createPart() line: 372 ... Invoking initialize() (or possibly named: initializeNew/initializeFromPalette etc.) in org.jbpm.gd.common.editor.CreationFactory DOES work, as it will not get invoked when reading the diagram: public Object getNewObject() { String notationElementId = NotationMapping.getNotationElementId(elementId); NotationElement notationElement = notationElementFactory.create(notationElementId); if (notationElement instanceof Node) { Dimension dimension = NotationMapping.getInitialDimension(elementId); if (dimension != null) { Rectangle constraint = ((Node)notationElement).getConstraint(); constraint.setSize(new Dimension(dimension)); } } SemanticElement jpdlElement = semanticElementFactory.createById(elementId); jpdlElement.initializeNew(); // I added my code here... notationElement.setSemanticElement(jpdlElement); return notationElement; } Please let me know if you need more info! John -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/GPD-77?page=comments#action_12371169 ] John Ruud commented on GPD-77: ------------------------------ I've been experimenting with (on and off) adding GD support for "xpdl", which would become a domain specific "extension" of jpdl. Because of its proprietary nature it wouldn't be very useful to the general public. I plan to keep contributing patches and post feature requests that would make it possible/easier to use GD for editing "xpdl", and this would hopfully also make it easier for other developers to add support for their own dsls. Does this sound like a good approach? Thanks, John -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/GPD-77?page=comments#action_12371171 ] John Ruud commented on GPD-77: ------------------------------ LOL - it's a name clash (guess I need to come up with something more original) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/GPD-77?page=comments#action_12372158 ] John Ruud commented on GPD-77: ------------------------------ Koen, XmlAdapter.initialize(SemanticElement) is invoked when loading the PD diagram, but not when adding objects from the palette (which is when I need to initialize my semantic elements), so I don't believe this approach would work. I'm not very familiar with the design behind GD, but my first thought was that it was the semantic elements (the "model objects"?) themselves that should get initialized, and that the xml adapters etc. would just get updated to reflect this (obviously this is not the case when reading the xml, when the xml adapters are used to re-create the semantic elements). Because of this it seems to me like the GD should provide some way of creating initialized semantic elements, for example by invoking some SemanticElement.initializeNew() - like method. This code would get invoked when adding objects from the palette (I think that may be the only case), but not for example while loading the diagram from xml (however, I'm leaving the design up to you - I just need one way to do this). Thanks, John -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/GPD-77?page=comments#action_12372168 ] Koen Aers commented on GPD-77: ------------------------------ So I answered to quickly (it is already past midnight here ;-) ) The solution for your problem is using either the initialize() method or do the initialization in the constructor. If the constructor or the initialize() method gets called when reading the diagram from the xml, you *have* to make sure in the adapter that the proper values for the attributes and nested elements are written into the newly created (and possibly wrongly initialized) semantic element object. This is done by the XmlAdapter.initialze(SemanticElement) method for the XmlAdapter of this particular semantic element. Have e.g. a look at the Task/TaskDomAdapter combo. Newly created instances of a task have attributes initialized to particular values. The initalize(SemanticElement) method in TaskDomAdapter will override these attributes with the values found in the xml. Hope this helps, Koen -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira