[ http://jira.jboss.com/jira/browse/JBMESSAGING-1247?page=all ] Brian Stansberry updated JBMESSAGING-1247: ------------------------------------------ Description: The current JGroups integration uses JMX to get ahold of a Channel: public Channel createControlChannel() throws Exception { return (Channel) server.invoke(this.channelFactory, MUX_OPERATION, new Object[]{controlStack, uniqueID + "-CTRL", Boolean.TRUE, uniqueID}, MUX_SIGNATURE); } The channelFactory member is an ObjectName injected into MessagingPostOfficeService. Better is to expose a property of type org.jgroups.ChannelFactory and inject an instance of that. That's the POJI interface for an object that provides JGroups channels. Background: JGroups intends to remove the legacy org.jgroups.jmx.JChannelFactoryMBean interface that is being invoked in the above code. That code is reflection based, so as long as a service that exposes the MUX_OPERATION signature is registered in JMX, the call will still work. AS 5 will ensure that such a service is registered, without using the org.jgroups.jmx.JChannelFactoryMBean itself. So, the above JMX-based code will work, and this isn't an urgent issue. But, this usage does tie JBM clustering to JMX, rather than allowing simple MC integration or even manual instantiation. was: The current JGroups integration uses JMX to get ahold of a Channel: public Channel createControlChannel() throws Exception { return (Channel) server.invoke(this.channelFactory, MUX_OPERATION, new Object[]{controlStack, uniqueID + "-CTRL", Boolean.TRUE, uniqueID}, MUX_SIGNATURE); } The channelFactory member is an ObjectName injected into MessagingPostOfficeService. Better is to expose a property of type org.jgroups.ChannelFactory and inject an instance of that. That's the POJI interface for an object that provides JGroups channels. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBMESSAGING-1247?page=comments#action_1... ] Jeff Mesnil commented on JBMESSAGING-1247: ------------------------------------------ as part of this task, we should also clean up MessagingPostOfficeService API. ChannelPartitionName and GroupName serve the same purpose: identify the JGroups channels used by JBoss Messaging. - ChannelPartitionName is used by AS 5 config in the multiplexer case - GroupName is used for all the other use case There should be only one property to set to uniquely identify the channels regardless of the use cases -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBMESSAGING-1247?page=all ] Jeff Mesnil updated JBMESSAGING-1247: ------------------------------------- Brian, I did what you suggested (replacing the ObjectName property channelFactory by a property of type org.jgroups.ChannelFactory). However, I still need to figure out 2 things: * how to I describe this new property in JBAPP postgresql-persistence-service.xml? <depends optional-attribute-name="JChannelFactory">jgroups.mux:name=Multiplexer</depends> <attribute name="ControlChannelName">udp-sync</attribute> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBMESSAGING-1247?page=comments#action_1... ] Jeff Mesnil commented on JBMESSAGING-1247: ------------------------------------------ Brian, I did what you suggested (replacing the ObjectName property channelFactory by a property of type org.jgroups.ChannelFactory). However, I still need to figure out 2 things: * how to I inject this new property in JBAPP postgresql-persistence-service.xml? if I replace <attribute name="ChannelFactoryName">jgroups.mux:name=Multiplexer</attribute> by <depends optional-attribute-name="JChannelFactory">jgroups.mux:name=Multiplexer</depends> I still expect to be injected a JChannelFactoryMBean, not a JChannelFactory. * in our own tests, we recreate "manually" a configuration based on the MBean exposed. In that case too, the only thing I can inject is a JChannelFactoryMBean, not a JChannelFactory. Using a MBean instead of an ObjectName is an improvement but it falls short from what you're suggesting. I think I missed something :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBMESSAGING-1247?page=all ] Jeff Mesnil resolved JBMESSAGING-1247. -------------------------------------- Resolution: Won't Fix Removing requirements for JMX is possible using AS 5 by injecting the ChannelFactory bean into JBM -service.xml: <attribute name="ChannelFactory"><inject bean="JChannelFactory"/></attribute> However this syntax is available only for AS 5 and we must remain compatible EAP 4.3. We will keep the code as is and be very careful to never reference directly JChannelFactoryMBean which will be removed in next JGroups release. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira