[ https://issues.jboss.org/browse/AS7-6139?page=com.atlassian.jira.plugin.s... ] Brian Stansberry commented on AS7-6139: --------------------------------------- That should work, yes. Some suggestions: 1) The matches() method should immediately return 'true' if validType == value.getType(). That would be more efficient even with the current code, but with the string manipulation this patch adds, it becomes more important. This method gets invoked a lot during boot, so we want high performance. With this change, the default case can be changed to return false; since the if test will have already done what the default case is doing now. 2) Minor: Please convert the if (x.compareTo(y) != 0) return false; return true; to return x.compareTo(y) == 0; Otherwise our IDEs will suggest we make that change and won't give us the nice "Green" icon for the file until we do. :) 3) Really minor: checkNumericType(value, type); can get the type from "value"; it doesn't need to be a param. Or, if you keep the type from the test in my 1) above you can just use it and not get it again in each case of the switch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira